open.source/magic-wormhole
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test_transit: fix the miscaptured-loop-variable bug I always make

Browse Source
This commit is contained in:
Brian Warner 2017-12-01 13:00:05 -08:00
parent 8a7c6faf4a
commit 1bbd756fa6
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/wormhole/test/test_transit.py
View File

@ -20,8 +20,8 @@ from nacl.exceptions import CryptoError
class Highlander(unittest.TestCase): class Highlander(unittest.TestCase):
def test_one_winner(self): def test_one_winner(self):
cancelled = set() cancelled = set()
contenders = [defer.Deferred(lambda d: cancelled.add(i)) contenders = [defer.Deferred(lambda d, i=i: cancelled.add(i))
for i in range(4)] for i in range(5)]
d = transit.there_can_be_only_one(contenders) d = transit.there_can_be_only_one(contenders)
self.assertNoResult(d) self.assertNoResult(d)
contenders[0].errback(ValueError()) contenders[0].errback(ValueError())
@ -30,11 +30,11 @@ class Highlander(unittest.TestCase):
self.assertNoResult(d) self.assertNoResult(d)
contenders[2].callback("yay") contenders[2].callback("yay")
self.assertEqual(self.successResultOf(d), "yay") self.assertEqual(self.successResultOf(d), "yay")
self.assertEqual(cancelled, set([3])) self.assertEqual(cancelled, set([3,4]))
def test_there_might_also_be_none(self): def test_there_might_also_be_none(self):
cancelled = set() cancelled = set()
contenders = [defer.Deferred(lambda d: cancelled.add(i)) contenders = [defer.Deferred(lambda d, i=i: cancelled.add(i))
for i in range(4)] for i in range(4)]
d = transit.there_can_be_only_one(contenders) d = transit.there_can_be_only_one(contenders)
self.assertNoResult(d) self.assertNoResult(d)