feat: deal with react 18 update bugs

This commit is contained in:
NunoSempere 2022-06-20 00:23:45 -04:00
parent 529fd25b13
commit a1fb0dd2ca
5 changed files with 42 additions and 42 deletions

View File

@ -63,9 +63,8 @@ export function ComparisonsChanger({
}
};
useEffect(async () => {
useEffect(() => {
setValue(JSON.stringify(links, null, 4));
return () => console.log("cleanup");
}, [links]);
return (

View File

@ -191,22 +191,23 @@ export function Graph({
// necessary for themes like spread, which have
// a confusing animation at the beginning
};
useEffect(async () => {
await callEffect({
useEffect(() => {
callEffect({
listOfElements,
links,
isListOrdered,
listAfterMergeSort,
});
return () => console.log("cleanup");
}, [listOfElements, links, isListOrdered, listAfterMergeSort]);
useEffect(async () => {
cs.edges().on("click", (event) => {
let edge = event.target;
alert(JSON.stringify(edge.json()));
});
});
useEffect(() => {
if (cs != null) {
cs.edges().on("click", (event) => {
let edge = event.target;
alert(JSON.stringify(edge.json()));
});
}
}, [cs]);
return (
<div className="">
<div className={visibility + "grid grid-cols-1 place-items-center "}>

View File

@ -67,19 +67,22 @@ export function ResultsTable({ isListOrdered, listAfterMergeSort, links }) {
const [isTableComputed, setIsTableComputed] = useState(false);
const [tableContents, setTableContents] = useState([]);
useEffect(async () => {
if (isListOrdered && listAfterMergeSort.length > 0) {
// both comparisons aren't strictly necessary,
// but it bit me once, so I'm leaving it
let tableContentsResult = await fullResultsTable({
listAfterMergeSort,
links,
});
console.log(tableContentsResult);
setTableContents(tableContentsResult);
setIsTableComputed(true);
}
return () => console.log("cleanup");
useEffect(() => {
let iAsync = async () => {
if (isListOrdered && listAfterMergeSort.length > 0) {
// both comparisons aren't strictly necessary,
// but it bit me once, so I'm leaving it
let tableContentsResult = await fullResultsTable({
listAfterMergeSort,
links,
});
console.log(tableContentsResult);
setTableContents(tableContentsResult);
setIsTableComputed(true);
}
return () => console.log("cleanup");
};
iAsync();
}, [isListOrdered, listAfterMergeSort, links]);
return !(isListOrdered && isTableComputed) ? (

View File

@ -20,10 +20,10 @@
"cytoscape-spread": "^3.0.0",
"next": "latest",
"path": "^0.12.7",
"react": "^17.0.1",
"react": "^18.0.1",
"react-code-blocks": "^0.0.9-0",
"react-compound-slider": "^3.3.1",
"react-dom": "17.0.1",
"react-dom": "^18.0.1",
"react-markdown": "^6.0.2",
"remark-gfm": "^1.0.0",
"simple-react-cytoscape": "^1.0.4",

View File

@ -3414,14 +3414,13 @@ react-compound-slider@^3.3.1:
d3-array "^2.8.0"
warning "^4.0.3"
react-dom@17.0.1:
version "17.0.1"
resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-17.0.1.tgz#1de2560474ec9f0e334285662ede52dbc5426fc6"
integrity sha512-6eV150oJZ9U2t9svnsspTMrWNyHc6chX0KzDeAOXftRa8bNeOKTTfCJ7KorIwenkHd2xqVTBTCZd79yk/lx/Ug==
react-dom@^18.0.1:
version "18.2.0"
resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-18.2.0.tgz#22aaf38708db2674ed9ada224ca4aa708d821e3d"
integrity sha512-6IMTriUmvsjHUjNtEDudZfuDQUoWXVxKHhlEGSk81n4YFS+r/Kl99wXiwlVXtPBtJenozv2P+hxDsw9eA7Xo6g==
dependencies:
loose-envify "^1.1.0"
object-assign "^4.1.1"
scheduler "^0.20.1"
scheduler "^0.23.0"
react-is@^16.13.1, react-is@^16.7.0:
version "16.13.1"
@ -3473,13 +3472,12 @@ react-transition-group@^4.4.2:
loose-envify "^1.4.0"
prop-types "^15.6.2"
react@^17.0.1:
version "17.0.2"
resolved "https://registry.yarnpkg.com/react/-/react-17.0.2.tgz#d0b5cc516d29eb3eee383f75b62864cfb6800037"
integrity sha512-gnhPt75i/dq/z3/6q/0asP78D0u592D5L1pd7M8P+dck6Fu/jJeL6iVVK23fptSUZj8Vjf++7wXA8UNclGQcbA==
react@^18.0.1:
version "18.2.0"
resolved "https://registry.yarnpkg.com/react/-/react-18.2.0.tgz#555bd98592883255fa00de14f1151a917b5d77d5"
integrity sha512-/3IjMdb2L9QbBdWiW5e3P2/npwMBaU9mHCSCUzNln0ZCYbcfTsGbTJrU/kGemdH2IWmB2ioZ+zkxtmq6g09fGQ==
dependencies:
loose-envify "^1.1.0"
object-assign "^4.1.1"
readable-stream@^2.1.4:
version "2.3.7"
@ -3634,13 +3632,12 @@ safe-buffer@~5.1.0, safe-buffer@~5.1.1:
resolved "https://registry.yarnpkg.com/safe-buffer/-/safe-buffer-5.1.2.tgz#991ec69d296e0313747d59bdfd2b745c35f8828d"
integrity sha512-Gd2UZBJDkXlY7GbJxfsE8/nvKkUEU1G38c1siN6QP6a9PT9MmHB8GnpscSmMJSoF8LOIrt8ud/wPtojys4G6+g==
scheduler@^0.20.1:
version "0.20.2"
resolved "https://registry.yarnpkg.com/scheduler/-/scheduler-0.20.2.tgz#4baee39436e34aa93b4874bddcbf0fe8b8b50e91"
integrity sha512-2eWfGgAqqWFGqtdMmcL5zCMK1U8KlXv8SQFGglL3CEtd0aDVDWgeF/YoCmvln55m5zSk3J/20hTaSBeSObsQDQ==
scheduler@^0.23.0:
version "0.23.0"
resolved "https://registry.yarnpkg.com/scheduler/-/scheduler-0.23.0.tgz#ba8041afc3d30eb206a487b6b384002e4e61fdfe"
integrity sha512-CtuThmgHNg7zIZWAXi3AsyIzA3n4xx7aNyjwC2VJldO2LMVDhFK+63xGqq6CsJH4rTAt6/M+N4GhZiDYPx9eUw==
dependencies:
loose-envify "^1.1.0"
object-assign "^4.1.1"
seedrandom@^3.0.5:
version "3.0.5"