From fc3108c289a39559696538817979e06f862e0c03 Mon Sep 17 00:00:00 2001
From: Ozzie Gooen <ozzieagooen@gmail.com>
Date: Mon, 10 Feb 2020 21:16:17 +0000
Subject: [PATCH] Minor cleanup

---
 src/lib/Prop.re       |  7 +++++
 src/models/EAFunds.re | 67 +++++++++++++++++++------------------------
 2 files changed, 37 insertions(+), 37 deletions(-)

diff --git a/src/lib/Prop.re b/src/lib/Prop.re
index 3420f7c1..768f9526 100644
--- a/src/lib/Prop.re
+++ b/src/lib/Prop.re
@@ -155,6 +155,13 @@ module Combo = {
 
     let update = (t: t, key: string, onUpdate: option(Value.t)) =>
       ValueMap.update(t.inputValues, key, onUpdate);
+
+    let toValueArray = (t: t) => {
+      t.model.inputTypes
+      |> E.A.fmap((r: TypeWithMetadata.t) =>
+           ValueMap.get(t.inputValues, r.id)
+         );
+    };
   };
 
   let updateInputValue = (t: t, k, u) => {
diff --git a/src/models/EAFunds.re b/src/models/EAFunds.re
index f2e97db0..368311d6 100644
--- a/src/models/EAFunds.re
+++ b/src/models/EAFunds.re
@@ -115,43 +115,37 @@ module Model = {
 
 module Interface = {
   open Data;
-  let convertChoice = (s: string) =>
-    switch (s) {
-    | "animal" => Fund(ANIMAL_WELFARE)
-    | "globalHealth" => Fund(GLOBAL_HEALTH)
-    | "longTerm" => Fund(LONG_TERM_FUTURE)
-    | "meta" => Fund(META)
-    | _ => All
-    };
 
-  let convertOutput = (s: string) =>
+  let fundKey = "Fund";
+  let dayKey = "Day";
+  let outputKey = "Output";
+
+  let choiceFromString = (s: string) =>
+    funds |> E.A.getBy(_, r => r.name == s);
+
+  let outputFromString = (s: string) =>
     switch (s) {
     | "donations" => DONATIONS
     | _ => PAYOUTS
     };
 
   let run = (p: Prop.Combo.t) => {
-    let get = Prop.ValueMap.get(p.inputValues);
-    switch (
-      get("Fund"),
-      get("Day"),
-      get(Prop.TypeWithMetadata.currentYear.id),
-      get("Output"),
-    ) {
-    | (
+    switch (Prop.Combo.InputValues.toValueArray(p)) {
+    | [|
         Some(SelectSingle(fund)),
         Some(DateTime(intendedYear)),
         Some(DateTime(currentYear)),
         Some(SelectSingle(output)),
-      ) =>
-      Some(
-        Model.make(
-          convertChoice(fund),
-          intendedYear,
-          currentYear,
-          convertOutput(output),
-        ),
-      )
+      |] =>
+      choiceFromString(fund)
+      |> E.O.fmap(fund =>
+           Model.make(
+             fund.group,
+             intendedYear,
+             currentYear,
+             outputFromString(output),
+           )
+         )
     | _ => None
     };
   };
@@ -164,22 +158,21 @@ module Interface = {
       author: "Ozzie Gooen",
       inputTypes: [|
         TypeWithMetadata.make(
-          ~name="Fund",
+          ~name=fundKey,
           ~type_=
             SelectSingle({
-              default: Some("total"),
-              options: [
-                {name: "Animal Welfare Fund", id: "animal"},
-                {name: "Global Health Fund", id: "globalHealth"},
-                {name: "Long Term Future Fund", id: "longTerm"},
-                {name: "Meta Fund", id: "longterm"},
-                {name: "All", id: "all"},
-              ],
+              default: Some(Array.unsafe_get(Data.funds, 0).name),
+              options:
+                Data.funds
+                |> E.A.fmap((r) =>
+                     ({name: r.name, id: r.name}: Prop.Type.selectOption)
+                   )
+                |> Array.to_list,
             }),
           (),
         ),
         TypeWithMetadata.make(
-          ~name="Day",
+          ~name=dayKey,
           ~type_=
             DateTime({
               default:
@@ -208,7 +201,7 @@ module Interface = {
         ),
         TypeWithMetadata.currentYear,
         TypeWithMetadata.make(
-          ~name="Output",
+          ~name=outputKey,
           ~type_=
             SelectSingle({
               default: Some("Output"),