quantified.uncertainty/squiggle
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

improve code generation for jsImports

Browse Source
This commit is contained in:
Vyacheslav Matyukhin 2022-09-01 18:55:15 +04:00
parent 64ed32a17c
commit e2abc53200
No known key found for this signature in database
GPG Key ID: 3D2A774C5489F96C
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/components/src/lib/jsImports.ts
View File

@ -24,7 +24,7 @@ const jsImportsValueToSquiggleCode = (v: JsImportsValue): string => {
return (
"{" +
Object.entries(v)
.map(([k, v]) => `${k}:${jsImportsValueToSquiggleCode(v)},`)
.map(([k, v]) => `${quote(k)}:${jsImportsValueToSquiggleCode(v)},`)
.join("") +
"}"
);
@ -35,7 +35,17 @@ const jsImportsValueToSquiggleCode = (v: JsImportsValue): string => {
};
export const jsImportsToSquiggleCode = (v: JsImports) => {
return Object.entries(v)
.map(([k, v]) => `$${k} = ${jsImportsValueToSquiggleCode(v)}\n`)
const validId = new RegExp("[a-zA-Z][[a-zA-Z0-9]*");
let result = Object.entries(v)
.map(([k, v]) => {
if (!k.match(validId)) {
return ""; // skipping without warnings; can be improved
}
return `$${k} = ${jsImportsValueToSquiggleCode(v)}\n`;
})
.join("");
if (!result) {
result = "$__no_valid_imports__ = 1"; // without this generated squiggle code can be invalid
}
return result;
};