(rebase): Function charting

packages/components/src/components/FunctionChart.tsx

@@ -1,18 +1,24 @@
 import * as React from "react";
 import _ from "lodash";
 import type { Spec } from "vega";
-import type { Distribution, errorValue, result } from "@quri/squiggle-lang";
+import {
+  Distribution,
+  result,
+  lambdaValue,
+  environment,
+  runForeign,
+  errorValueToString,
+} from "@quri/squiggle-lang";
 import { createClassFromSpec } from "react-vega";
 import * as percentilesSpec from "../vega-specs/spec-percentiles.json";
 import { DistributionChart } from "./DistributionChart";
+import { NumberShower } from "./NumberShower";
 import { ErrorBox } from "./ErrorBox";
 
 let SquigglePercentilesChart = createClassFromSpec({
   spec: percentilesSpec as Spec,
 });
 
-type distPlusFn = (a: number) => result<Distribution, errorValue>;
-
 const _rangeByCount = (start: number, stop: number, count: number) => {
   const step = (stop - start) / (count - 1);
   const items = _.range(start, stop, step);
@@ -27,38 +33,36 @@ function unwrap<a, b>(x: result<a, b>): a {
     throw Error("FAILURE TO UNWRAP");
   }
 }
+export type FunctionChartSettings = {
+  start: number;
+  stop: number;
+  count: number;
+};
 
-function mapFilter<a, b>(xs: a[], f: (x: a) => b | undefined): b[] {
+interface FunctionChartProps {
-  let initial: b[] = [];
+  fn: lambdaValue;
-  return xs.reduce((previous, current) => {
+  chartSettings: FunctionChartSettings;
-    let value: b | undefined = f(current);
+  environment: environment;
-    if (value !== undefined) {
-      return previous.concat([value]);
-    } else {
-      return previous;
-    }
-  }, initial);
 }
 
-export const FunctionChart: React.FC<{
+export const FunctionChart: React.FC<FunctionChartProps> = ({
-  distPlusFn: distPlusFn;
+  fn,
-  diagramStart: number;
+  chartSettings,
-  diagramStop: number;
+  environment,
-  diagramCount: number;
+}: FunctionChartProps) => {
-}> = ({ distPlusFn, diagramStart, diagramStop, diagramCount }) => {
   let [mouseOverlay, setMouseOverlay] = React.useState(0);
-  function handleHover(...args) {
+  function handleHover(_name: string, value: unknown) {
-    setMouseOverlay(args[1]);
+    setMouseOverlay(value as number);
   }
   function handleOut() {
     setMouseOverlay(NaN);
   }
   const signalListeners = { mousemove: handleHover, mouseout: handleOut };
-  let mouseItem = distPlusFn(mouseOverlay);
+  let mouseItem = runForeign(fn, [mouseOverlay], environment);
   let showChart =
-    mouseItem.tag === "Ok" ? (
+    mouseItem.tag === "Ok" && mouseItem.value.tag == "distribution" ? (
       <DistributionChart
-        distribution={mouseItem.value}
+        distribution={mouseItem.value.value}
         width={400}
         height={140}
         showSummary={false}
@@ -66,13 +70,49 @@ export const FunctionChart: React.FC<{
     ) : (
       <></>
     );
-  let data1 = _rangeByCount(diagramStart, diagramStop, diagramCount);
+  let data1 = _rangeByCount(
-  let valueData = mapFilter(data1, (x) => {
+    chartSettings.start,
-    let result = distPlusFn(x);
+    chartSettings.stop,
+    chartSettings.count
+  );
+  type point = { x: number; value: result<Distribution, string> };
+  let valueData: point[] = data1.map((x) => {
+    let result = runForeign(fn, [x], environment);
     if (result.tag === "Ok") {
-      return { x: x, value: result.value };
+      if (result.value.tag == "distribution") {
+        return { x, value: { tag: "Ok", value: result.value.value } };
+      } else {
+        return {
+          x,
+          value: {
+            tag: "Error",
+            value:
+              "Cannot currently render functions that don't return distributions",
+          },
+        };
+      }
+    } else {
+      return {
+        x,
+        value: { tag: "Error", value: errorValueToString(result.value) },
+      };
     }
-  }).map(({ x, value }) => {
+  });
+
+  let initialPartition: [
+    { x: number; value: Distribution }[],
+    { x: number; value: string }[]
+  ] = [[], []];
+  let [functionImage, errors] = valueData.reduce((acc, current) => {
+    if (current.value.tag === "Ok") {
+      acc[0].push({ x: current.x, value: current.value.value });
+    } else {
+      acc[1].push({ x: current.x, value: current.value.value });
+    }
+    return acc;
+  }, initialPartition);
+
+  let percentiles = functionImage.map(({ x, value }) => {
     return {
       x: x,
       p1: unwrap(value.inv(0.01)),
@@ -91,24 +131,25 @@ export const FunctionChart: React.FC<{
     };
   });
 
-  let errorData = mapFilter(data1, (x) => {
+  let groupedErrors = _.groupBy(errors, (x) => x.value);
-    let result = distPlusFn(x);
-    if (result.tag === "Error") {
-      return { x: x, error: result.value };
-    }
-  });
-  let error2 = _.groupBy(errorData, (x) => x.error);
   return (
     <>
       <SquigglePercentilesChart
-        data={{ facet: valueData }}
+        data={{ facet: percentiles }}
         actions={false}
         signalListeners={signalListeners}
       />
       {showChart}
-      {_.keysIn(error2).map((k) => (
+      {_.entries(groupedErrors).map(([errorName, errorPoints]) => (
-        <ErrorBox heading={k}>
+        <ErrorBox heading={errorName}>
-          {`Values: [${error2[k].map((r) => r.x.toFixed(2)).join(",")}]`}
+          Values:{" "}
+          {errorPoints
+            .map((r) => <NumberShower number={r.x} />)
+            .reduce((a, b) => (
+              <>
+                {a}, {b}
+              </>
+            ))}
         </ErrorBox>
       ))}
     </>

packages/components/src/components/SquiggleChart.tsx

@@ -6,7 +6,7 @@ import {
   errorValueToString,
   squiggleExpression,
   bindings,
-  samplingParams,
+  environment,
   jsImports,
   defaultImports,
   defaultBindings,
@@ -14,6 +14,7 @@ import {
 import { NumberShower } from "./NumberShower";
 import { DistributionChart } from "./DistributionChart";
 import { ErrorBox } from "./ErrorBox";
+import { FunctionChart, FunctionChartSettings } from "./FunctionChart";
 
 const variableBox = {
   Component: styled.div`
@@ -36,7 +37,7 @@ const variableBox = {
 interface VariableBoxProps {
   heading: string;
   children: React.ReactNode;
-  showTypes?: boolean;
+  showTypes: boolean;
 }
 
 export const VariableBox: React.FC<VariableBoxProps> = ({
@@ -68,9 +69,13 @@ export interface SquiggleItemProps {
   /** Whether to show a summary of statistics for distributions */
   showSummary: boolean;
   /** Whether to show type information */
-  showTypes?: boolean;
+  showTypes: boolean;
   /** Whether to show users graph controls (scale etc) */
-  showControls?: boolean;
+  showControls: boolean;
+  /** Settings for displaying functions */
+  chartSettings: FunctionChartSettings;
+  /** Environment for further function executions */
+  environment: environment;
 }
 
 const SquiggleItem: React.FC<SquiggleItemProps> = ({
@@ -80,6 +85,8 @@ const SquiggleItem: React.FC<SquiggleItemProps> = ({
   showSummary,
   showTypes = false,
   showControls = false,
+  chartSettings,
+  environment,
 }: SquiggleItemProps) => {
   switch (expression.tag) {
     case "number":
@@ -147,6 +154,8 @@ const SquiggleItem: React.FC<SquiggleItemProps> = ({
               height={50}
               showTypes={showTypes}
               showControls={showControls}
+              chartSettings={chartSettings}
+              environment={environment}
               showSummary={showSummary}
             />
           ))}
@@ -165,6 +174,8 @@ const SquiggleItem: React.FC<SquiggleItemProps> = ({
                 showTypes={showTypes}
                 showSummary={showSummary}
                 showControls={showControls}
+                chartSettings={chartSettings}
+                environment={environment}
               />
             </>
           ))}
@@ -178,9 +189,11 @@ const SquiggleItem: React.FC<SquiggleItemProps> = ({
       );
     case "lambda":
       return (
-        <ErrorBox heading="No Viewer">
+        <FunctionChart
-          There is no viewer currently available for function types.
+          fn={expression.value}
-        </ErrorBox>
+          chartSettings={chartSettings}
+          environment={environment}
+        />
       );
   }
 };
@@ -191,30 +204,24 @@ export interface SquiggleChartProps {
   /** If the output requires monte carlo sampling, the amount of samples */
   sampleCount?: number;
   /** The amount of points returned to draw the distribution */
-  outputXYPoints?: number;
+  environment: environment;
-  kernelWidth?: number;
+  /** If the result is a function, where the function starts, ends and the amount of stops */
-  pointDistLength?: number;
+  chartSettings?: FunctionChartSettings;
-  /** If the result is a function, where the function starts */
-  diagramStart?: number;
-  /** If the result is a function, where the function ends */
-  diagramStop?: number;
-  /** If the result is a function, how many points along the function it samples */
-  diagramCount?: number;
   /** When the environment changes */
   onChange?(expr: squiggleExpression): void;
   /** CSS width of the element */
   width?: number;
   height?: number;
   /** Bindings of previous variables declared */
-  bindings?: bindings;
+  bindings: bindings;
   /** JS imported parameters */
-  jsImports?: jsImports;
+  jsImports: jsImports;
   /** Whether to show a summary of the distirbution */
   showSummary?: boolean;
   /** Whether to show type information about returns, default false */
-  showTypes?: boolean;
+  showTypes: boolean;
   /** Whether to show graph controls (scale etc)*/
-  showControls?: boolean;
+  showControls: boolean;
 }
 
 const ChartWrapper = styled.div`
@@ -223,10 +230,10 @@ const ChartWrapper = styled.div`
     "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";
 `;
 
+let defaultChartSettings = { start: 0, stop: 10, count: 100 };
 export const SquiggleChart: React.FC<SquiggleChartProps> = ({
   squiggleString = "",
-  sampleCount = 1000,
+  environment,
-  outputXYPoints = 1000,
   onChange = () => {},
   height = 60,
   bindings = defaultBindings,
@@ -235,17 +242,9 @@ export const SquiggleChart: React.FC<SquiggleChartProps> = ({
   width,
   showTypes = false,
   showControls = false,
+  chartSettings = defaultChartSettings,
 }: SquiggleChartProps) => {
-  let samplingInputs: samplingParams = {
+  let expressionResult = run(squiggleString, bindings, environment, jsImports);
-    sampleCount: sampleCount,
-    xyPointLength: outputXYPoints,
-  };
-  let expressionResult = run(
-    squiggleString,
-    bindings,
-    samplingInputs,
-    jsImports
-  );
   let internal: JSX.Element;
   if (expressionResult.tag === "Ok") {
     let expression = expressionResult.value;
@@ -258,6 +257,8 @@ export const SquiggleChart: React.FC<SquiggleChartProps> = ({
         showSummary={showSummary}
         showTypes={showTypes}
         showControls={showControls}
+        chartSettings={chartSettings}
+        environment={environment}
       />
     );
   } else {

packages/components/src/components/SquiggleEditor.tsx

@@ -5,7 +5,7 @@ import { CodeEditor } from "./CodeEditor";
 import styled from "styled-components";
 import type {
   squiggleExpression,
-  samplingParams,
+  environment,
   bindings,
   jsImports,
 } from "@quri/squiggle-lang";
@@ -24,8 +24,6 @@ export interface SquiggleEditorProps {
   sampleCount?: number;
   /** The amount of points returned to draw the distribution */
   outputXYPoints?: number;
-  kernelWidth?: number;
-  pointDistLength?: number;
   /** If the result is a function, where the function starts */
   diagramStart?: number;
   /** If the result is a function, where the function ends */
@@ -57,13 +55,11 @@ const Input = styled.div`
 export let SquiggleEditor: React.FC<SquiggleEditorProps> = ({
   initialSquiggleString = "",
   width,
-  sampleCount,
+  sampleCount = 1000,
-  outputXYPoints,
+  outputXYPoints = 1000,
-  kernelWidth,
+  diagramStart = 0,
-  pointDistLength,
+  diagramStop = 10,
-  diagramStart,
+  diagramCount = 100,
-  diagramStop,
-  diagramCount,
   onChange,
   bindings = defaultBindings,
   jsImports = defaultImports,
@@ -72,6 +68,15 @@ export let SquiggleEditor: React.FC<SquiggleEditorProps> = ({
   showSummary = false,
 }: SquiggleEditorProps) => {
   let [expression, setExpression] = React.useState(initialSquiggleString);
+  let chartSettings = {
+    start: diagramStart,
+    stop: diagramStop,
+    count: diagramCount,
+  };
+  let env: environment = {
+    sampleCount: sampleCount,
+    xyPointLength: outputXYPoints,
+  };
   return (
     <div>
       <Input>
@@ -85,14 +90,10 @@ export let SquiggleEditor: React.FC<SquiggleEditorProps> = ({
       </Input>
       <SquiggleChart
         width={width}
+        environment={env}
         squiggleString={expression}
         sampleCount={sampleCount}
-        outputXYPoints={outputXYPoints}
+        chartSettings={chartSettings}
-        kernelWidth={kernelWidth}
-        pointDistLength={pointDistLength}
-        diagramStart={diagramStart}
-        diagramStop={diagramStop}
-        diagramCount={diagramCount}
         onChange={onChange}
         bindings={bindings}
         jsImports={jsImports}
@@ -169,7 +170,7 @@ export let SquigglePartial: React.FC<SquigglePartialProps> = ({
   outputXYPoints = 1000,
   jsImports = defaultImports,
 }: SquigglePartialProps) => {
-  let samplingInputs: samplingParams = {
+  let samplingInputs: environment = {
     sampleCount: sampleCount,
     xyPointLength: outputXYPoints,
   };

packages/components/src/components/SquigglePlayground.tsx

@@ -4,6 +4,11 @@ import ReactDOM from "react-dom";
 import { SquiggleChart } from "./SquiggleChart";
 import CodeEditor from "./CodeEditor";
 import styled from "styled-components";
+import {
+  defaultBindings,
+  environment,
+  defaultImports,
+} from "@quri/squiggle-lang";
 
 interface FieldFloatProps {
   label: string;
@@ -96,6 +101,15 @@ let SquigglePlayground: FC<PlaygroundProps> = ({
   let [diagramStart, setDiagramStart] = useState(0);
   let [diagramStop, setDiagramStop] = useState(10);
   let [diagramCount, setDiagramCount] = useState(20);
+  let chartSettings = {
+    start: diagramStart,
+    stop: diagramStop,
+    count: diagramCount,
+  };
+  let env: environment = {
+    sampleCount: sampleCount,
+    xyPointLength: outputXYPoints,
+  };
   return (
     <ShowBox height={height}>
       <Row>
@@ -112,16 +126,14 @@ let SquigglePlayground: FC<PlaygroundProps> = ({
           <Display maxHeight={height - 3}>
             <SquiggleChart
               squiggleString={squiggleString}
-              sampleCount={sampleCount}
+              environment={env}
-              outputXYPoints={outputXYPoints}
+              chartSettings={chartSettings}
-              diagramStart={diagramStart}
-              diagramStop={diagramStop}
-              diagramCount={diagramCount}
-              pointDistLength={pointDistLength}
               height={150}
               showTypes={showTypes}
               showControls={showControls}
               showSummary={showSummary}
+              bindings={defaultBindings}
+              jsImports={defaultImports}
             />
           </Display>
         </Col>

packages/squiggle-lang/src/js/index.ts

@@ -1,6 +1,5 @@
 import * as _ from "lodash";
 import {
-  samplingParams,
   environment,
   defaultEnvironment,
   evaluatePartialUsingExternalBindings,
@@ -8,6 +7,7 @@ import {
   externalBindings,
   expressionValue,
   errorValue,
+  foreignFunctionInterface,
 } from "../rescript/TypescriptInterface.gen";
 export {
   makeSampleSetDist,
@@ -15,25 +15,30 @@ export {
   distributionErrorToString,
   distributionError,
 } from "../rescript/TypescriptInterface.gen";
-export type {
+export type { errorValue, externalBindings as bindings, jsImports };
-  samplingParams,
-  errorValue,
-  externalBindings as bindings,
-  jsImports,
-};
 import {
   jsValueToBinding,
+  jsValueToExpressionValue,
   jsValue,
   rescriptExport,
   squiggleExpression,
   convertRawToTypescript,
+  lambdaValue,
 } from "./rescript_interop";
 import { result, resultMap, tag, tagged } from "./types";
 import { Distribution, shape } from "./distribution";
 
-export { Distribution, squiggleExpression, result, resultMap, shape };
+export {
+  Distribution,
+  squiggleExpression,
+  result,
+  resultMap,
+  shape,
+  lambdaValue,
+  environment,
+};
 
-export let defaultSamplingInputs: samplingParams = {
+export let defaultSamplingInputs: environment = {
   sampleCount: 10000,
   xyPointLength: 10000,
 };
@@ -72,6 +77,20 @@ export function runPartial(
   );
 }
 
+export function runForeign(
+  fn: lambdaValue,
+  args: jsValue[],
+  environment?: environment
+): result<squiggleExpression, errorValue> {
+  let e = environment ? environment : defaultEnvironment;
+  let res: result<expressionValue, errorValue> = foreignFunctionInterface(
+    fn,
+    args.map(jsValueToExpressionValue),
+    e
+  );
+  return resultMap(res, (x) => createTsExport(x, e));
+}
+
 function mergeImportsWithBindings(
   bindings: externalBindings,
   imports: jsImports

packages/squiggle-lang/src/js/rescript_interop.ts

@@ -1,5 +1,6 @@
 import * as _ from "lodash";
 import {
+  expressionValue,
   mixedShape,
   sampleSetDist,
   genericDist,
@@ -87,6 +88,8 @@ export type squiggleExpression =
   | tagged<"number", number>
   | tagged<"record", { [key: string]: squiggleExpression }>;
 
+export { lambdaValue };
+
 export function convertRawToTypescript(
   result: rescriptExport,
   environment: environment
@@ -168,3 +171,21 @@ export function jsValueToBinding(value: jsValue): rescriptExport {
     return { TAG: 7, _0: _.mapValues(value, jsValueToBinding) };
   }
 }
+
+export function jsValueToExpressionValue(value: jsValue): expressionValue {
+  if (typeof value === "boolean") {
+    return { tag: "EvBool", value: value as boolean };
+  } else if (typeof value === "string") {
+    return { tag: "EvString", value: value as string };
+  } else if (typeof value === "number") {
+    return { tag: "EvNumber", value: value as number };
+  } else if (Array.isArray(value)) {
+    return { tag: "EvArray", value: value.map(jsValueToExpressionValue) };
+  } else {
+    // Record
+    return {
+      tag: "EvRecord",
+      value: _.mapValues(value, jsValueToExpressionValue),
+    };
+  }
+}

packages/squiggle-lang/src/rescript/TypescriptInterface.res

@@ -84,3 +84,6 @@ type environment = ReducerInterface_ExpressionValue.environment
 
 @genType
 let defaultEnvironment = ReducerInterface_ExpressionValue.defaultEnvironment
+
+@genType
+let foreignFunctionInterface = Reducer.foreignFunctionInterface