quantified.uncertainty/squiggle
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Minor revisions from CR

Browse Source
This commit is contained in:
Ozzie Gooen 2022-04-28 08:09:31 -04:00
parent b2189777d5
commit ab4dcc233c
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/squiggle-lang/src/rescript/Distributions/GenericDist/GenericDist.res
View File

@ -150,8 +150,6 @@ let truncate = Truncate.run
of a new variable that is the result of the operation on A and B. of a new variable that is the result of the operation on A and B.
For instance, normal(0, 1) + normal(1, 1) -> normal(1, 2). For instance, normal(0, 1) + normal(1, 1) -> normal(1, 2).
In general, this is implemented via convolution. In general, this is implemented via convolution.
TODO: It would be useful to be able to pass in a paramater to get this to run either with convolution or monte carlo.
*/ */
module AlgebraicCombination = { module AlgebraicCombination = {
module InputValidator = { module InputValidator = {
@ -181,9 +179,9 @@ module AlgebraicCombination = {
switch items { switch items {
| Error(r) => Some(r) | Error(r) => Some(r)
| Ok([true, _]) => | Ok([true, _]) =>
Some(LogarithmOfDistributionError("First input must completely greater than 0")) Some(LogarithmOfDistributionError("First input must be completely greater than 0"))
| Ok([false, true]) => | Ok([false, true]) =>
Some(LogarithmOfDistributionError("Second input must completely greater than 0")) Some(LogarithmOfDistributionError("Second input must be completely greater than 0"))
| Ok([false, false]) => None | Ok([false, false]) => None
| Ok(_) => Some(Unreachable) | Ok(_) => Some(Unreachable)
} }