From 811c3bd6e71b90425aca115284811411bbc30acc Mon Sep 17 00:00:00 2001
From: Ozzie Gooen <OAGr@users.noreply.github.com>
Date: Mon, 11 Apr 2022 14:53:17 -0400
Subject: [PATCH 1/2] Update CONTRIBUTING to

Added information from our decisions at our last meeting
---
 CONTRIBUTING.md | 74 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 74 insertions(+)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 3c17b1e7..a9327ce8 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -50,3 +50,77 @@ See [here](https://github.com/NixOS/nixpkgs/issues/107375)
 # Pull request protocol
 
 Please work against `staging` branch. **Do not** work against `master`. Please do not merge without approval from some subset of Quinn, Sam, and Ozzie; they will be auto-pinged. 
+
+# Code Quality
+- Aim for at least 8/10* quality in ``/packages/squiggle-lang``, and 7/10 quality in ``/packages/components``. 
+- If you submit a PR that is under a 7, for some reason, describe the reasoning for this in the PR.
+
+* This quality score is subjective.
+
+# Rescript Style
+
+**Use `->` instead of `|>`**  
+Note: Our codebase used to use `|>`, so there's a lot of that in the system. We'll gradually change it.
+
+**Use `x -> y -> z` instead of `let foo = y(x); let bar = z(foo)`**
+
+**Don't use anonymous functions with over three lines**  
+Bad:
+```rescript
+  foo
+  -> E.O.fmap(r => {
+    let a = 34;
+    let b = 35;
+    let c = 48;
+    r + a + b + c
+  }
+```
+Good:
+```rescript
+  let addingFn = (r => {
+    let a = 34;
+    let b = 35;
+    let c = 48;
+    r + a + b + c
+  }
+  foo -> addingFn
+```
+
+**Write out types for everything, even if there's an interface file**  
+We'll try this for one month (ending May 5, 2022), then revisit.
+
+**Use the Rescript optional default syntax**  
+Rescript is clever about function inputs. There's custom syntax for default and optional arguments. In the cases where this applies, use it.
+
+From https://rescript-lang.org/docs/manual/latest/function:
+```rescript
+// radius can be omitted
+let drawCircle = (~color, ~radius=?, ()) => {
+  setColor(color)
+  switch radius {
+  | None => startAt(1, 1)
+  | Some(r_) => startAt(r_, r_)
+  }
+}
+```
+
+**Use named arguments**  
+If a function is called externally (in a different file), and has either:
+1. Two arguments of the same type
+2. Three paramaters or more.
+
+**Module naming: Use x_y as module names**  
+For example: ``Myname__Myproject__Add.res``. Rescript/Ocaml both require files to have unique names, so long names are needed to keep different parts separate from each other.
+
+See [this page](https://dev.to/yawaramin/a-modular-ocaml-project-structure-1ikd) for more information.
+
+**Module naming: Don't rename modules**
+We have some of this in the Reducer code, but generally discourage it. 
+
+**Use interface files (.resi) for files with very public interfaces**
+
+### Recommended Rescript resources  
+- https://dev.to/yawaramin/a-modular-ocaml-project-structure-1ikd 
+- https://github.com/avohq/reasonml-code-style-guide 
+- https://cs.brown.edu/courses/cs017/content/docs/reasonml-style.pdf
+- https://github.com/ostera/reason-design-patterns/ 

From 3c82a88c6a848e96ebd6fc99ac1f12beefe8c13d Mon Sep 17 00:00:00 2001
From: Ozzie Gooen <OAGr@users.noreply.github.com>
Date: Mon, 11 Apr 2022 20:24:46 -0400
Subject: [PATCH 2/2] Update CONTRIBUTING.md

---
 CONTRIBUTING.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index a9327ce8..ab87bca7 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -110,9 +110,9 @@ If a function is called externally (in a different file), and has either:
 2. Three paramaters or more.
 
 **Module naming: Use x_y as module names**  
-For example: ``Myname__Myproject__Add.res``. Rescript/Ocaml both require files to have unique names, so long names are needed to keep different parts separate from each other.
+For example: ``Myname_Myproject_Add.res``. Rescript/Ocaml both require files to have unique names, so long names are needed to keep different parts separate from each other.
 
-See [this page](https://dev.to/yawaramin/a-modular-ocaml-project-structure-1ikd) for more information.
+See [this page](https://dev.to/yawaramin/a-modular-ocaml-project-structure-1ikd) for more information. (Though note that they use two underscores, and we do one. We might refactor that later.
 
 **Module naming: Don't rename modules**
 We have some of this in the Reducer code, but generally discourage it.