quantified.uncertainty/squiggle
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

a fistful of comments

Browse Source
This commit is contained in:
Quinn Dougherty 2022-06-20 11:11:11 -04:00
parent 2c72972097
commit 633bab9c30
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/squiggle-lang/src/rescript/Distributions/PointSetDist/PointSetDist_Scoring.res
View File

@ -124,7 +124,7 @@ module WithScalarAnswer = {
~estimatePdf: float => float, ~estimatePdf: float => float,
~answer: scalar, ~answer: scalar,
~priorPdf: float => float, ~priorPdf: float => float,
): result<float, Operation.Error.t> => { ): result<score, Operation.Error.t> => {
let numerator = answer->estimatePdf let numerator = answer->estimatePdf
let priorDensityOfAnswer = answer->priorPdf let priorDensityOfAnswer = answer->priorPdf
if numerator < 0.0 || priorDensityOfAnswer < 0.0 { if numerator < 0.0 || priorDensityOfAnswer < 0.0 {
@ -162,7 +162,7 @@ module TwoScalars = {
minusScaledLogOfQuotient(~esti=estimate, ~answ=answer) minusScaledLogOfQuotient(~esti=estimate, ~answ=answer)
} }
let scoreWithPrior = (~estimate: float, ~answer: float, ~prior: float) => let scoreWithPrior = (~estimate: scalar, ~answer: scalar, ~prior: scalar) =>
if answer == 0.0 { if answer == 0.0 {
0.0->Ok 0.0->Ok
} else if estimate == 0.0 || prior == 0.0 { } else if estimate == 0.0 || prior == 0.0 {