From 9dc0459b9f32ca4a3ece487e8df5322563ab9a1a Mon Sep 17 00:00:00 2001 From: NunoSempere Date: Thu, 10 Mar 2022 08:03:21 +0000 Subject: [PATCH] fix: small bug not displaying message after user makes comment. Note: Haven't tested this. --- apps/bridge/app.rc | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/apps/bridge/app.rc b/apps/bridge/app.rc index 40477ba..17f6085 100755 --- a/apps/bridge/app.rc +++ b/apps/bridge/app.rc @@ -6,7 +6,7 @@ fn conf_enable_comments { shift } if not if(~ $1 -a) { - bridge_anon_comments=yes + bridge_anon_comments=yes } enable_comments=yes groups_allowed_comments=$* @@ -64,15 +64,18 @@ fn mk_new_comment { if(validate_new_user $"post_arg_comment_user $post_arg_comment_passwd $post_arg_comment_passwd2) { u=$post_arg_comment_user':'$post_arg_comment_passwd dir=$comments_dir^'_pending' - # XXX: This doesn't work because we then do a redirect. - notify_notes='Saved comment and registration info, they will be enabled when approved by an admin.' + # XXX: This doesn't work because we then do a redirect. + # NN: Now it works, but the notify_notes has to be not-empty. + # Kind of a hack, because I'm not really that familiar with rc. + notify_notes='Saved commend.' + _status='Saved comment and registration info, they will be enabled when approved by an admin.' } if not _status=$status } if not if(! ~ $#bridge_anon_comments 0) { if(~ $"post_arg_ima_robot 'not') - u='Glenda' # Anonymous + u='Anonymous' # Anonymous if not _status='You are a robot!' } @@ -84,7 +87,8 @@ fn mk_new_comment { if not _status='You are not a member of a group allowed to comment.' - if(~ $#_status 0) { + # if(~ $#_status 0) { + if (~ $#notify_notes 1){ umask 002 dir=$dir'/'`{date -n} # FIXME Obvious race @@ -94,10 +98,11 @@ fn mk_new_comment { echo $post_arg_comment_text > $dir/body _s=$status if(! ~ $"_s '') { - dprint 'ERROR XXX: Could not create comment: ' $_s + dprint 'ERROR XXX: Could not create comment: ' $_s _status='Could not post comment due internal error, sorry.' } } notify_errors=$_status status=$_status } +