diff --git a/C-optimized/out/samples b/C-optimized/out/samples index 0486ecc6..98384ccc 100755 Binary files a/C-optimized/out/samples and b/C-optimized/out/samples differ diff --git a/C-optimized/samples.c b/C-optimized/samples.c index e8fec1f5..134c7dc2 100644 --- a/C-optimized/samples.c +++ b/C-optimized/samples.c @@ -6,7 +6,7 @@ const float PI = 3.14159265358979323846; -#define N 1000000 +#define N 100000000 //Array helpers @@ -47,54 +47,42 @@ void array_cumsum(float* array_to_sum, float* array_cumsummed, int length) } } -float rand_float(float to) +float rand_float(float to, unsigned int* seed) { - return ((float)rand() / (float)RAND_MAX) * to; + return ((float)rand_r(seed) / (float)RAND_MAX) * to; } -float ur_normal() +float ur_normal(unsigned int* seed) { - float u1 = rand_float(1.0); - float u2 = rand_float(1.0); + float u1 = rand_float(1.0, seed); + float u2 = rand_float(1.0, seed); float z = sqrtf(-2.0 * log(u1)) * sin(2 * PI * u2); return z; } -inline float random_uniform(float from, float to) +inline float random_uniform(float from, float to, unsigned int* seed) { - return ((float)rand() / (float)RAND_MAX) * (to - from) + from; + return ((float) rand_r(seed) / (float)RAND_MAX) * (to - from) + from; } -inline float random_normal(float mean, float sigma) +inline float random_normal(float mean, float sigma, unsigned int* seed) { - return (mean + sigma * ur_normal()); + return (mean + sigma * ur_normal(seed)); } -inline float random_lognormal(float logmean, float logsigma) +inline float random_lognormal(float logmean, float logsigma, unsigned int* seed) { - return expf(random_normal(logmean, logsigma)); + return expf(random_normal(logmean, logsigma, seed)); } -inline float random_to(float low, float high) +inline float random_to(float low, float high, unsigned int* seed) { const float NORMAL95CONFIDENCE = 1.6448536269514722; float loglow = logf(low); float loghigh = logf(high); float logmean = (loglow + loghigh) / 2; float logsigma = (loghigh - loglow) / (2.0 * NORMAL95CONFIDENCE); - return random_lognormal(logmean, logsigma); -} - -void array_random_to(float* array, int length, float low, float high) -{ - int i; - #pragma omp private(i) - { - #pragma omp for - for (i = 0; i < length; i++) { - array[i] = random_to(low, high); - } - } + return random_lognormal(logmean, logsigma, seed); } int split_array_get_my_length(int index, int total_length, int n_threads) @@ -103,6 +91,7 @@ int split_array_get_my_length(int index, int total_length, int n_threads) } //Old version, don't use it!! Optimized version is called mixture_f. This one is just for display +/* void mixture(float* dists[], float* weights, int n_dists, float* results) { float sum_weights = array_sum(weights, n_dists); @@ -145,8 +134,8 @@ void mixture(float* dists[], float* weights, int n_dists, float* results) free(normalized_weights); free(cummulative_weights); } - -void mixture_f(float (*samplers[])(void), float* weights, int n_dists, float** results, int n_threads) +*/ +void mixture_f(float (*samplers[])(unsigned int* ), float* weights, int n_dists, float** results, int n_threads) { float sum_weights = array_sum(weights, n_dists); float* normalized_weights = malloc(n_dists * sizeof(float)); @@ -160,6 +149,11 @@ void mixture_f(float (*samplers[])(void), float* weights, int n_dists, float** r //create var holders float p1; int sample_index, i, own_length; + unsigned int* seeds[n_threads]; + for(unsigned int i=0; i