diff --git a/options/index.js b/options/index.js index a5906bb9..ef581b09 100644 --- a/options/index.js +++ b/options/index.js @@ -10,7 +10,7 @@ function restore() { //$('#show-badge').value = bg.prefs.get('show-badge'); $('#badgeDisabled').value = prefs.get('badgeDisabled'); $('#badgeNormal').value = prefs.get('badgeNormal'); - $('#popupWidth').value = localStorage.getItem('popupWidth') || '246'; + $('#popupWidth').value = prefs.get('popupWidth'); $('#updateInterval').value = prefs.get('updateInterval'); enforceValueRange('popupWidth'); } @@ -19,7 +19,7 @@ function restore() { function save() { prefs.set('badgeDisabled', $('#badgeDisabled').value); prefs.set('badgeNormal', $('#badgeNormal').value); - localStorage.setItem('popupWidth', enforceValueRange('popupWidth')); + prefs.set('popupWidth', enforceValueRange('popupWidth')); prefs.set( 'updateInterval', Math.max(0, Number($('#updateInterval').value)) @@ -38,7 +38,7 @@ function enforceValueRange(id) { element.value = value; } element.onchange = element.onchange || (() => enforceValueRange(id)); - return value; + return value | 0; } diff --git a/popup.js b/popup.js index dd64a4d4..ffbb4d5c 100644 --- a/popup.js +++ b/popup.js @@ -43,7 +43,7 @@ function initPopup(url) { // popup width document.body.style.width = - Math.max(200, Math.min(800, Number(localStorage.popupWidth) || 246)) + 'px'; + Math.max(200, Math.min(800, prefs.get('popupWidth'))) + 'px'; // force Chrome to resize the popup document.body.style.height = '10px'; diff --git a/storage.js b/storage.js index a3688bfc..fa8f303a 100644 --- a/storage.js +++ b/storage.js @@ -540,6 +540,13 @@ function tryRegExp(regexp) { } +function tryJSONparse(jsonString) { + try { + return JSON.parse(jsonString); + } catch (e) {} +} + + function debounce(fn, ...args) { const timers = debounce.timers = debounce.timers || new Map(); debounce.run = debounce.run || ((fn, ...args) => { @@ -592,7 +599,7 @@ prefs = prefs || new function Prefs() { 'badgeDisabled': '#8B0000', // badge background color when disabled 'badgeNormal': '#006666', // badge background color - 'popupWidth': 240, // popup width in pixels + 'popupWidth': 246, // popup width in pixels 'updateInterval': 0 // user-style automatic update interval, hour }; @@ -638,6 +645,9 @@ prefs = prefs || new function Prefs() { if (!noBroadcast && !equal(value, oldValue)) { this.broadcast(key, value, {noSync}); } + localStorage[key] = typeof defaults[key] == 'object' + ? JSON.stringify(value) + : value; }, remove: key => this.set(key, undefined), @@ -651,14 +661,41 @@ prefs = prefs || new function Prefs() { }, }); - Object.keys(defaults).forEach(key => { - this.set(key, defaults[key], {noBroadcast: true}); - }); + // Unlike sync, HTML5 localStorage is ready at browser startup + // so we'll mirror the prefs to avoid using the wrong defaults + // during the startup phase + for (const key in defaults) { + const defaultValue = defaults[key]; + let value = localStorage[key]; + if (typeof value == 'string') { + switch (typeof defaultValue) { + case 'boolean': + value = value.toLowerCase() === 'true'; + break; + case 'number': + value |= 0; + break; + case 'object': + value = tryJSONparse(value) || defaultValue; + break; + } + } else { + value = defaultValue; + } + this.set(key, value, {noBroadcast: true}); + } getSync().get('settings', ({settings: synced}) => { - for (const key in defaults) { - if (synced && (key in synced)) { - this.set(key, synced[key], {noSync: true}); + if (synced) { + for (const key in defaults) { + if (key == 'popupWidth' && synced[key] != values.popupWidth) { + // this is a fix for the period when popupWidth wasn't synced + // TODO: remove it in a couple of months before the summer 2017 + continue; + } + if (key in synced) { + this.set(key, synced[key], {noSync: true}); + } } } if (typeof contextMenus !== 'undefined') {