From c0fd7c53b7662444e87b029595cab23f63c4e518 Mon Sep 17 00:00:00 2001
From: eight04 <eight04@gmail.com>
Date: Sat, 4 Dec 2021 23:32:34 +0800
Subject: [PATCH] Change: use radio instead of select for dark/light mode

---
 edit.html         | 21 ++++++++++++++-------
 edit/settings.css | 17 ++++++++++++++++-
 edit/settings.js  | 22 +++++++++++++++++++++-
 3 files changed, 51 insertions(+), 9 deletions(-)

diff --git a/edit.html b/edit.html
index 4cc9ce66..22471cbb 100644
--- a/edit.html
+++ b/edit.html
@@ -453,15 +453,22 @@
             <span class="form-label" i18n-text="styleUpdateUrlLabel"></span>
             <input type="text">
           </label>
-          <label class="form-group style-prefer-scheme">
+          <div class="form-group style-prefer-scheme radio-group">
             <!-- FIXME: should we use a different message from install page? -->
             <span class="form-label" i18n-text="installPreferSchemeLabel"></span>
-            <select>
-              <option value="none" i18n-text="installPreferSchemeNone"></option>
-              <option value="dark" i18n-text="installPreferSchemeDark"></option>
-              <option value="light" i18n-text="installPreferSchemeLight"></option>
-            </select>
-          </label>
+            <label class="radio-item">
+              <input type="radio" name="preferScheme" value="none">
+              <span class="radio-label" i18n-text="installPreferSchemeNone"></span>
+            </label>
+            <label class="radio-item">
+              <input type="radio" name="preferScheme" value="dark">
+              <span class="radio-label" i18n-text="installPreferSchemeDark"></span>
+            </label>
+            <label class="radio-item">
+              <input type="radio" name="preferScheme" value="light">
+              <span class="radio-label" i18n-text="installPreferSchemeLight"></span>
+            </label>
+          </div>
           <div class="form-group style-include">
             <div class="form-label" i18n-text="styleIncludeLabel"></div>
             <div class="rule-table"></div>
diff --git a/edit/settings.css b/edit/settings.css
index 9b338329..883c8a48 100644
--- a/edit/settings.css
+++ b/edit/settings.css
@@ -28,4 +28,19 @@
   grid-gap: .3em;
   margin: .3em 0;
 }
-
+.radio-group .form-label {
+  display: block;
+}
+.radio-item {
+  display: flex;
+  margin: 0.3em 0 .3em;
+  padding: 0;
+  align-items: center;
+  width: max-content;
+}
+.radio-item input {
+  margin: 0 0.6em 0 0;
+}
+[disabled] .radio-label {
+  opacity: 0.4;
+}
diff --git a/edit/settings.js b/edit/settings.js
index cfb9f2c3..89f34300 100644
--- a/edit/settings.js
+++ b/edit/settings.js
@@ -8,7 +8,7 @@ function StyleSettings(editor) {
   const inputs = [
     createInput('.style-update-url input', () => style.updateUrl || '',
       e => API.styles.config(style.id, 'updateUrl', e.target.value)),
-    createInput('.style-prefer-scheme select', () => style.preferScheme || 'none',
+    createRadio('.style-prefer-scheme input', () => style.preferScheme || 'none',
       e => API.styles.config(style.id, 'preferScheme', e.target.value)),
     createInput('.style-priority input', () => style.priority || 0,
       e => API.styles.config(style.id, 'priority', e.target.valueAsNumber)),
@@ -28,6 +28,26 @@ function StyleSettings(editor) {
     inputs.forEach(i => i.update());
   }
 
+  function createRadio(selector, getter, setter) {
+    const els = document.querySelectorAll(selector);
+    for (const el of els) {
+      el.addEventListener('change', e => {
+        if (el.checked) {
+          setter(e);
+        }
+      });
+    }
+    return {
+      update() {
+        for (const el of els) {
+          if (el.value === getter()) {
+            el.checked = true;
+          }
+        }
+      },
+    };
+  }
+
   function createInput(selector, getter, setter) {
     const el = document.querySelector(selector);
     el.addEventListener('change', setter);