From ad100d42b3349a3253ce12afcb272e0ab8f21be1 Mon Sep 17 00:00:00 2001
From: tophf <tophf@gmx.com>
Date: Sat, 29 Apr 2017 20:58:53 +0300
Subject: [PATCH] optionsUI: equal height of 2-line action buttons

---
 options/index.css  | 11 +++++++----
 options/index.html |  4 +---
 options/index.js   |  5 +----
 3 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/options/index.css b/options/index.css
index db445f10..b1501ed7 100644
--- a/options/index.css
+++ b/options/index.css
@@ -19,7 +19,7 @@ body {
   margin: 0;
   font-family: "Helvetica Neue", Helvetica, sans-serif;
   font-size: 12px;
-  width: calc(16px + 100px + 8px + 240px + 8px + 80px + 4px + 16px);
+  width: calc(16px + 100px + 8px + 260px + 8px + 60px + 4px + 16px);
 }
 
 .firefox .chromium-only {
@@ -61,7 +61,7 @@ label > * {
 }
 
 label > :first-child {
-  width: 240px;
+  width: 260px;
   white-space: normal;
   margin-right: 8px;
 }
@@ -78,7 +78,7 @@ button,
 input[type=number],
 input[type="color"],
 .onoffswitch {
-  width: 80px;
+  width: 60px;
   box-sizing: border-box;
 }
 
@@ -106,10 +106,13 @@ input[type="color"] {
 
 #actions {
   justify-content: space-around;
+  align-items: stretch;
+  padding-right: 8px;
 }
 
 #actions button {
   width: auto;
+  margin-right: 8px;
 }
 
 [data-cmd="check-updates"] button {
@@ -227,7 +230,7 @@ sup {
   position: absolute;
   top: 0;
   bottom: 0;
-  right: 56px;
+  right: 46px;
   border-radius: 18px;
   box-shadow: 0 3px 13px 0 rgba(0, 0, 0, 0.4);
 }
diff --git a/options/index.html b/options/index.html
index 75fd75b4..5812ddc3 100644
--- a/options/index.html
+++ b/options/index.html
@@ -90,9 +90,7 @@
         </button>
         <div id="updates-installed" i18n-text="updatesCurrentlyInstalled"></div>
       </div>
-      <a data-cmd="open-keyboard" class="chromium-only" href="chrome://extensions/configureCommands">
-        <button i18n-text="shortcuts" i18n-title="shortcutsNote"></button>
-      </a>
+      <button data-cmd="open-keyboard" class="chromium-only" i18n-text="shortcuts" i18n-title="shortcutsNote"></button>
     </div>
   </div>
 
diff --git a/options/index.js b/options/index.js
index f9afb81e..3b4dce31 100644
--- a/options/index.js
+++ b/options/index.js
@@ -3,9 +3,6 @@
 setupLivePrefs();
 enforceInputRange($('#popupWidth'));
 
-// overwrite the default URL if browser is Opera
-$('[data-cmd="open-keyboard"]').href = URLS.configureCommands;
-
 // actions
 document.onclick = e => {
   const target = e.target.closest('[data-cmd]');
@@ -25,7 +22,7 @@ document.onclick = e => {
       break;
 
     case 'open-keyboard':
-      openURL({url: target.closest('a').href});
+      openURL({url: URLS.configureCommands});
       e.preventDefault();
       break;