From a7defbfc40c61dbbd6af79f170a2949aa01cf079 Mon Sep 17 00:00:00 2001 From: Rob Garrison Date: Tue, 24 Sep 2019 08:21:36 -0500 Subject: [PATCH] Popup border (#781) * Popup: Fix horizontal scrollbar in Chrome * Hide popup borer option in newer Chrome versions. Closes #780 * Add chrome bug range constant --- js/messaging.js | 3 +++ options.html | 2 +- options/options.css | 4 +++- options/options.js | 10 +++++++++- popup/popup.js | 9 ++++++--- 5 files changed, 22 insertions(+), 6 deletions(-) diff --git a/js/messaging.js b/js/messaging.js index 1ab433b5..2ba9e033 100644 --- a/js/messaging.js +++ b/js/messaging.js @@ -10,6 +10,9 @@ const VIVALDI = Boolean(chrome.app) && navigator.userAgent.includes('Vivaldi'); // const ANDROID = !chrome.windows; let FIREFOX = !chrome.app && parseFloat(navigator.userAgent.match(/\bFirefox\/(\d+\.\d+)|$/)[1]); +// see PR #781 +const CHROME_HAS_BORDER_BUG = CHROME >= 3167 && CHROME <= 3704; + if (!CHROME && !chrome.browserAction.openPopup) { // in FF pre-57 legacy addons can override useragent so we assume the worst // until we know for sure in the async getBrowserInfo() diff --git a/options.html b/options.html index 66b3ea23..af620626 100644 --- a/options.html +++ b/options.html @@ -109,7 +109,7 @@ -