From a0004bb6fd145ed7d04e61dc7f807e5a2fab413c Mon Sep 17 00:00:00 2001 From: eight Date: Wed, 26 Jun 2019 18:04:28 +0800 Subject: [PATCH] Fix: oldValue and newValue should have the same type --- js/dom.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/dom.js b/js/dom.js index 4017bdc0..293b3878 100644 --- a/js/dom.js +++ b/js/dom.js @@ -457,15 +457,15 @@ function setupLivePrefs( } function setInputValue(input, value, force = false) { let oldValue, newValue; - const inputValue = input.dataset.valueType === 'number' ? Number(input.value) : input.value; if (input.type === 'radio') { + const inputValue = input.dataset.valueType === 'number' ? Number(input.value) : input.value; oldValue = input.checked; newValue = input.checked = value === inputValue; } else if (input.type === 'checkbox') { oldValue = input.checked; newValue = input.checked = value; } else { - oldValue = inputValue; + oldValue = input.value; newValue = input.value = value; } if (force || oldValue !== newValue) {