From 9a55e64bbb99c46eba28c7534ad62e89c2ab3d6c Mon Sep 17 00:00:00 2001
From: tophf <tophf@gmx.com>
Date: Tue, 22 Aug 2017 17:22:15 +0300
Subject: [PATCH] autosize filter select element

---
 manage/filters.js | 33 +++++++++++++++++++++++++--------
 manage/manage.css |  4 ++++
 manage/manage.js  | 16 +++++++++++++++-
 3 files changed, 44 insertions(+), 9 deletions(-)

diff --git a/manage/filters.js b/manage/filters.js
index 87723ac6..9ef5de75 100644
--- a/manage/filters.js
+++ b/manage/filters.js
@@ -8,6 +8,17 @@ const filtersSelector = {
   numTotal: 0,
 };
 
+HTMLSelectElement.prototype.adjustWidth = function () {
+  const parent = this.parentNode;
+  const singleSelect = this.cloneNode(false);
+  singleSelect.style.width = '';
+  singleSelect.appendChild(this.selectedOptions[0].cloneNode(true));
+  parent.replaceChild(singleSelect, this);
+  if (this.style.width !== singleSelect.offsetWidth + 'px') {
+    this.style.width = singleSelect.offsetWidth + 'px';
+  }
+  parent.replaceChild(this, singleSelect);
+};
 
 onDOMready().then(onBackgroundReady).then(() => {
   $('#search').oninput = searchStyles;
@@ -19,7 +30,6 @@ onDOMready().then(onBackgroundReady).then(() => {
       [false, slaveData.filter],
       [true, slaveData.filterHide],
     ]);
-    //
     // enable slave control when user switches the value
     el.oninput = () => {
       if (!slave.checked) {
@@ -36,12 +46,18 @@ onDOMready().then(onBackgroundReady).then(() => {
     el.onchange = event => {
       const value = el.value === 'true';
       const filter = valueMap.get(value);
-      if (slaveData.filter !== filter) {
-        slaveData.filter = filter;
-        slaveData.filterHide = valueMap.get(!value);
-        debounce(filterOnChange, 0, event);
+      if (slaveData.filter === filter) {
+        return;
+      }
+      slaveData.filter = filter;
+      slaveData.filterHide = valueMap.get(!value);
+      debounce(filterOnChange, 0, event);
+      // avoid triggering MutationObserver during page load
+      if (document.readyState === 'complete') {
+        el.adjustWidth();
       }
     };
+    el.onchange({target: el});
   });
 
   $$('[data-filter]').forEach(el => {
@@ -51,8 +67,7 @@ onDOMready().then(onBackgroundReady).then(() => {
     }
   });
 
-  // let manage::initGlobalEvents run onDOMready first
-  debounce(filterOnChange, 0, {forceRefilter: true});
+  filterOnChange({forceRefilter: true});
 });
 
 
@@ -78,7 +93,9 @@ function filterOnChange({target: el, forceRefilter}) {
     hide: buildFilter(true),
     unhide: buildFilter(false),
   });
-  reapplyFilter();
+  if (installed) {
+    reapplyFilter();
+  }
 }
 
 
diff --git a/manage/manage.css b/manage/manage.css
index 1dfe22eb..781bc7c2 100644
--- a/manage/manage.css
+++ b/manage/manage.css
@@ -544,6 +544,8 @@ fieldset {
   border-width: 1px;
   border-radius: 6px;
   margin: 1em 0;
+  min-width: 0;
+  max-width: 250px;
 }
 
 fieldset > *:not(legend) {
@@ -572,6 +574,8 @@ fieldset > *:not(legend) {
 #manage\.onlyEnabled\.invert,
 #manage\.onlyLocal\.invert {
   border: none;
+  max-width: calc(100% - 2em);
+  background-color: transparent;
 }
 
 #search {
diff --git a/manage/manage.js b/manage/manage.js
index 573ac3e4..54e5c668 100644
--- a/manage/manage.js
+++ b/manage/manage.js
@@ -507,6 +507,7 @@ function rememberScrollPosition() {
 
 function usePrefsDuringPageLoad() {
   const observer = new MutationObserver(mutations => {
+    const adjustedNodes = [];
     for (const mutation of mutations) {
       for (const node of mutation.addedNodes) {
         // [naively] assuming each element of addedNodes is a childless element
@@ -517,10 +518,23 @@ function usePrefsDuringPageLoad() {
           } else {
             node.value = prefValue;
           }
+          if (node.adjustWidth) {
+            adjustedNodes.push(node);
+          }
         }
       }
     }
+    if (adjustedNodes.length) {
+      observer.disconnect();
+      for (const node of adjustedNodes) {
+        node.adjustWidth();
+      }
+      startObserver();
+    }
   });
-  observer.observe(document, {subtree: true, childList: true});
+  function startObserver() {
+    observer.observe(document, {subtree: true, childList: true});
+  }
+  startObserver();
   onDOMready().then(() => observer.disconnect());
 }