From 92d6530c8f286f5d7cc99bf54c7cb4faef1620ca Mon Sep 17 00:00:00 2001 From: tophf Date: Tue, 7 Aug 2018 20:11:11 +0300 Subject: [PATCH] simplify listener registration since the function reference is constant, only one listener will be registered --- edit/edit.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/edit/edit.js b/edit/edit.js index 45c6b555..8e62f9c6 100644 --- a/edit/edit.js +++ b/edit/edit.js @@ -583,10 +583,8 @@ function showHelp(title = '', body) { window.dispatchEvent(new Event('closeHelp')); }); - if (getComputedStyle(div).display === 'none') { - window.addEventListener('keydown', showHelp.close, true); - $('.dismiss', div).onclick = showHelp.close; - } + window.addEventListener('keydown', showHelp.close, true); + $('.dismiss', div).onclick = showHelp.close; // reset any inline styles div.style = 'display: block';