From 74701810b7ad3b39a2e00b231eeddf342aff1a9d Mon Sep 17 00:00:00 2001
From: tophf <tophf@gmx.com>
Date: Thu, 23 Nov 2017 08:18:55 +0300
Subject: [PATCH] remove cruft; silence eslint

---
 edit.html             |  2 +-
 edit/edit.js          |  4 +++-
 edit/lint.js          | 13 ++-----------
 edit/source-editor.js |  5 ++---
 4 files changed, 8 insertions(+), 16 deletions(-)

diff --git a/edit.html b/edit.html
index 9ade64b6..36393b74 100644
--- a/edit.html
+++ b/edit.html
@@ -235,7 +235,7 @@
           </span>
         </div>
       </details>
-      <details id="lint">
+      <details id="lint" class="hidden">
         <summary>
           <h2 i18n-text="linterIssues">: <span id="issue-count"></span><!-- EAT SPACE
           --><svg id="lint-help" class="svg-icon info intercepts-click">
diff --git a/edit/edit.js b/edit/edit.js
index d25f0ff4..4bf86e99 100644
--- a/edit/edit.js
+++ b/edit/edit.js
@@ -5,11 +5,13 @@
 /* global CSSLint initLint linterConfig updateLintReport renderLintReport updateLinter */
 /* global mozParser createSourceEditor */
 /* global closeCurrentTab regExpTester messageBox */
+/* global initColorpicker */
 'use strict';
 
 onDOMready()
   .then(() => Promise.all([
-    window.initColorpicker(),
+    initColorpicker(),
+    initCollapsibles(),
   ]))
   .then(init);
 
diff --git a/edit/lint.js b/edit/lint.js
index 7ac4dd9c..8b4f6f3c 100644
--- a/edit/lint.js
+++ b/edit/lint.js
@@ -142,11 +142,6 @@ function initLint() {
   $('#linter-settings').addEventListener('click', linterConfig.openOnClick);
   window.addEventListener('resize', resizeLintReport);
 
-  // touch devices don't have onHover events so the element we'll be toggled via clicking (touching)
-  if ('ontouchstart' in document.body) {
-    $('#lint h2').addEventListener('click', toggleLintReport);
-  }
-
   updateLinter();
   linterConfig.watchStorage();
   prefs.subscribe(['editor.linter'], updateLinter);
@@ -164,7 +159,7 @@ function updateLinter({immediately, linter = linterConfig.getDefault()} = {}) {
     loadLinterAssets(linter)
   ]).then(updateEditors);
   $('#linter-settings').style.display = !linter ? 'none' : 'inline-block';
-  $('#lint').style.display = 'none';
+  $('#lint').classList.add('hidden');
 
   function updateEditors() {
     CodeMirror.defaults.lint = linterConfig.getForCodeMirror(linter);
@@ -336,7 +331,7 @@ function renderLintReport(someBlockChanged) {
   if (someBlockChanged || newContent.children.length !== content.children.length) {
     $('#issue-count').textContent = issueCount;
     container.replaceChild(newContent, content);
-    container.style.display = newContent.children.length ? 'block' : 'none';
+    container.classList.toggle('hidden', !newContent.children.length);
     resizeLintReport();
   }
 }
@@ -370,10 +365,6 @@ function gotoLintIssue(event) {
   });
 }
 
-function toggleLintReport() {
-  $('#lint').classList.toggle('collapsed');
-}
-
 function showLintHelp() {
   const linter = linterConfig.getDefault();
   const baseUrl = linter === 'stylelint'
diff --git a/edit/source-editor.js b/edit/source-editor.js
index cda431b3..fe38e30b 100644
--- a/edit/source-editor.js
+++ b/edit/source-editor.js
@@ -1,6 +1,6 @@
 /* global CodeMirror dirtyReporter initLint beautify showKeyMapHelp */
 /* global showToggleStyleHelp goBackToManage updateLintReportIfEnabled */
-/* global hotkeyRerouter setupAutocomplete setupOptionsExpand */
+/* global hotkeyRerouter setupAutocomplete */
 /* global editors linterConfig updateLinter regExpTester mozParser */
 /* global makeLink createAppliesToLineWidget messageBox */
 'use strict';
@@ -9,6 +9,7 @@ function createSourceEditor(style) {
   // a flag for isTouched()
   let hadBeenSaved = false;
 
+  document.documentElement.classList.add('usercss');
   $('#sections').textContent = '';
   $('#name').disabled = true;
   $('#mozilla-format-heading').parentNode.remove();
@@ -22,8 +23,6 @@ function createSourceEditor(style) {
     appendChild: makeLink('https://github.com/openstyles/stylus/wiki/Usercss', t('externalUsercssDocument'))
   }));
 
-  initCollapsibles();
-
   const dirty = dirtyReporter();
   dirty.onChange(() => {
     const DIRTY = dirty.isDirty();