From 54427c498dcf9ac917ee3780ef70e98b68f34229 Mon Sep 17 00:00:00 2001 From: tophf Date: Fri, 13 Aug 2021 12:15:58 +0300 Subject: [PATCH] avoid mutating DOM unnecessarily in toggleDataset() --- js/dom.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/js/dom.js b/js/dom.js index 86ebf7c6..fb82ba8c 100644 --- a/js/dom.js +++ b/js/dom.js @@ -337,10 +337,11 @@ async function showSpinner(parent) { } function toggleDataset(el, prop, state) { + const wasEnabled = el.dataset[prop] != null; // avoids mutating DOM unnecessarily if (state) { - el.dataset[prop] = ''; + if (!wasEnabled) el.dataset[prop] = ''; } else { - delete el.dataset[prop]; + if (wasEnabled) delete el.dataset[prop]; } }