${icon + url}
`);
} else {
partial.push(`${icon}${match}` +
@@ -1898,7 +1898,7 @@ function showHelp(title, text) {
div.querySelector('.contents').innerHTML = text;
div.querySelector('.title').innerHTML = title;
- if (getComputedStyle(div).display == 'none') {
+ if (getComputedStyle(div).display === 'none') {
document.addEventListener('keydown', closeHelp);
div.querySelector('.dismiss').onclick = closeHelp; // avoid chaining on multiple showHelp() calls
}
@@ -1909,8 +1909,8 @@ function showHelp(title, text) {
function closeHelp(e) {
if (
!e ||
- e.type == 'click' ||
- ((e.keyCode || e.which) == 27 && !e.altKey && !e.ctrlKey && !e.shiftKey && !e.metaKey)
+ e.type === 'click' ||
+ ((e.keyCode || e.which) === 27 && !e.altKey && !e.ctrlKey && !e.shiftKey && !e.metaKey)
) {
div.style.display = '';
document.querySelector('.contents').innerHTML = '';
@@ -1944,7 +1944,7 @@ function showCodeMirrorPopup(title, html, options) {
function getParams() {
const params = {};
const urlParts = location.href.split('?', 2);
- if (urlParts.length == 1) {
+ if (urlParts.length === 1) {
return params;
}
urlParts[1].split('&').forEach(keyValue => {
@@ -1959,7 +1959,7 @@ chrome.runtime.onMessage.addListener(onRuntimeMessage);
function onRuntimeMessage(request) {
switch (request.method) {
case 'styleUpdated':
- if (styleId && styleId == request.style.id && request.reason != 'editSave') {
+ if (styleId && styleId === request.style.id && request.reason !== 'editSave') {
if ((request.style.sections[0] || {}).code === null) {
// the code-less style came from notifyAllTabs
onBackgroundReady().then(() => {
@@ -1972,7 +1972,7 @@ function onRuntimeMessage(request) {
}
break;
case 'styleDeleted':
- if (styleId && styleId == request.id) {
+ if (styleId && styleId === request.id) {
window.onbeforeunload = () => {};
window.close();
break;
diff --git a/js/dom.js b/js/dom.js
index 88fd44b6..6a71a10a 100644
--- a/js/dom.js
+++ b/js/dom.js
@@ -27,7 +27,7 @@ navigator.userAgent.includes('Firefox') && setTimeout(() => {
function onDOMready() {
- if (document.readyState != 'loading') {
+ if (document.readyState !== 'loading') {
return Promise.resolve();
}
return new Promise(resolve => {
@@ -79,9 +79,9 @@ function enforceInputRange(element) {
const max = Number(element.max);
const doNotify = () => element.dispatchEvent(new Event('change', {bubbles: true}));
const onChange = ({type}) => {
- if (type == 'input' && element.checkValidity()) {
+ if (type === 'input' && element.checkValidity()) {
doNotify();
- } else if (type == 'change' && !element.checkValidity()) {
+ } else if (type === 'change' && !element.checkValidity()) {
element.value = Math.max(min, Math.min(max, Number(element.value)));
doNotify();
}
@@ -113,7 +113,7 @@ function $element(opt) {
? opt.tag.split('#')
: [null, opt.tag];
const element = ns
- ? document.createElementNS(ns == 'SVG' || ns == 'svg' ? 'http://www.w3.org/2000/svg' : ns, tag)
+ ? document.createElementNS(ns === 'SVG' || ns === 'svg' ? 'http://www.w3.org/2000/svg' : ns, tag)
: document.createElement(tag || 'div');
(opt.appendChild instanceof Array ? opt.appendChild : [opt.appendChild])
.forEach(child => child && element.appendChild(child));
diff --git a/js/localization.js b/js/localization.js
index 0c5f578c..1db7577b 100644
--- a/js/localization.js
+++ b/js/localization.js
@@ -7,7 +7,7 @@ tDocLoader();
function t(key, params) {
const cache = !params && t.cache[key];
const s = cache || chrome.i18n.getMessage(key, params);
- if (s == '') {
+ if (s === '') {
throw `Missing string "${key}"`;
}
if (!params && !cache) {
@@ -20,7 +20,7 @@ function t(key, params) {
function tE(id, key, attr, esc) {
if (attr) {
document.getElementById(id).setAttribute(attr, t(key));
- } else if (typeof esc == 'undefined' || esc) {
+ } else if (typeof esc === 'undefined' || esc) {
document.getElementById(id).appendChild(document.createTextNode(t(key)));
} else {
document.getElementById(id).innerHTML = t(key);
@@ -43,10 +43,10 @@ function tNodeList(nodes) {
for (let n = nodes.length; --n >= 0;) {
const node = nodes[n];
// skip non-ELEMENT_NODE
- if (node.nodeType != 1) {
+ if (node.nodeType !== 1) {
continue;
}
- if (node.localName == 'template') {
+ if (node.localName === 'template') {
const elements = node.content.querySelectorAll('*');
tNodeList(elements);
template[node.dataset.id] = elements[0];
@@ -94,7 +94,7 @@ function tDocLoader() {
// reset L10N cache on UI language change
const UIlang = chrome.i18n.getUILanguage();
- if (t.cache.browserUIlanguage != UIlang) {
+ if (t.cache.browserUIlanguage !== UIlang) {
t.cache = {browserUIlanguage: UIlang};
localStorage.L10N = JSON.stringify(t.cache);
}
@@ -114,7 +114,7 @@ function tDocLoader() {
const onLoad = () => {
tDocLoader.stop();
process(observer.takeRecords());
- if (cacheLength != Object.keys(t.cache).length) {
+ if (cacheLength !== Object.keys(t.cache).length) {
localStorage.L10N = JSON.stringify(t.cache);
}
};
diff --git a/js/messaging.js b/js/messaging.js
index a1e1c4b0..386f7409 100644
--- a/js/messaging.js
+++ b/js/messaging.js
@@ -35,7 +35,7 @@ const URLS = {
let BG = chrome.extension.getBackgroundPage();
-if (!BG || BG != window) {
+if (!BG || BG !== window) {
document.documentElement.classList.toggle('firefox', FIREFOX);
document.documentElement.classList.toggle('opera', OPERA);
// TODO: remove once our manifest's minimum_chrome_version is 50+
@@ -47,7 +47,7 @@ if (!BG || BG != window) {
function notifyAllTabs(msg) {
const originalMessage = msg;
- if (msg.method == 'styleUpdated' || msg.method == 'styleAdded') {
+ if (msg.method === 'styleUpdated' || msg.method === 'styleAdded') {
// apply/popup/manage use only meta for these two methods,
// editor may need the full code but can fetch it directly,
// so we send just the meta to avoid spamming lots of tabs with huge styles
@@ -86,11 +86,11 @@ function notifyAllTabs(msg) {
});
}
// notify self: the message no longer is sent to the origin in new Chrome
- if (typeof onRuntimeMessage != 'undefined') {
+ if (typeof onRuntimeMessage !== 'undefined') {
onRuntimeMessage(originalMessage);
}
// notify apply.js on own pages
- if (typeof applyOnMessage != 'undefined') {
+ if (typeof applyOnMessage !== 'undefined') {
applyOnMessage(originalMessage);
}
// notify background page and all open popups
@@ -134,7 +134,7 @@ function getActiveTabRealURL() {
function getTabRealURL(tab) {
return new Promise(resolve => {
- if (tab.url != 'chrome://newtab/') {
+ if (tab.url !== 'chrome://newtab/') {
resolve(tab.url);
} else {
chrome.webNavigation.getFrame({tabId: tab.id, frameId: 0, processId: -1}, frame => {
@@ -159,13 +159,13 @@ function openURL({url, currentWindow = true}) {
const urlQuery = url.startsWith('moz-extension') ? undefined : url.replace(/#.*/, '');
queryTabs({url: urlQuery, currentWindow}).then(tabs => {
for (const tab of tabs) {
- if (tab.url == url) {
+ if (tab.url === url) {
activateTab(tab).then(resolve);
return;
}
}
getActiveTab().then(tab => {
- if (tab && tab.url == 'chrome://newtab/'
+ if (tab && tab.url === 'chrome://newtab/'
// prevent redirecting incognito NTP to a chrome URL as it crashes Chrome
&& (!url.startsWith('chrome') || !tab.incognito)) {
chrome.tabs.update({url}, resolve);
@@ -250,14 +250,14 @@ const debounce = Object.assign((fn, delay, ...args) => {
function deepCopy(obj) {
- return obj !== null && obj !== undefined && typeof obj == 'object'
- ? deepMerge(typeof obj.slice == 'function' ? [] : {}, obj)
+ return obj !== null && obj !== undefined && typeof obj === 'object'
+ ? deepMerge(typeof obj.slice === 'function' ? [] : {}, obj)
: obj;
}
function deepMerge(target, ...args) {
- const isArray = typeof target.slice == 'function';
+ const isArray = typeof target.slice === 'function';
for (const obj of args) {
if (isArray && obj !== null && obj !== undefined) {
for (const element of obj) {
@@ -267,7 +267,7 @@ function deepMerge(target, ...args) {
}
for (const k in obj) {
const value = obj[k];
- if (k in target && typeof value == 'object' && value !== null) {
+ if (k in target && typeof value === 'object' && value !== null) {
deepMerge(target[k], value);
} else {
target[k] = deepCopy(value);
@@ -346,7 +346,7 @@ function download(url) {
return new Promise((resolve, reject) => {
const xhr = new XMLHttpRequest();
xhr.timeout = 10e3;
- xhr.onloadend = () => (xhr.status == 200
+ xhr.onloadend = () => (xhr.status === 200
? resolve(xhr.responseText)
: reject(xhr.status));
const [mainUrl, query] = url.split('?');
diff --git a/js/prefs.js b/js/prefs.js
index c34a0546..2326036b 100644
--- a/js/prefs.js
+++ b/js/prefs.js
@@ -115,10 +115,10 @@ var prefs = new function Prefs() {
defineReadonlyProperty(this.readOnlyValues, key, value);
const hasChanged = !equal(value, oldValue);
if (!fromBroadcast) {
- if (BG && BG != window) {
+ if (BG && BG !== window) {
BG.prefs.set(key, BG.deepCopy(value), {broadcast, sync});
} else {
- localStorage[key] = typeof defaults[key] == 'object'
+ localStorage[key] = typeof defaults[key] === 'object'
? JSON.stringify(value)
: value;
if (broadcast && hasChanged) {
@@ -166,7 +166,7 @@ var prefs = new function Prefs() {
for (const key in defaults) {
const defaultValue = defaults[key];
let value = localStorage[key];
- if (typeof value == 'string') {
+ if (typeof value === 'string') {
switch (typeof defaultValue) {
case 'boolean':
value = value.toLowerCase() === 'true';
@@ -181,7 +181,7 @@ var prefs = new function Prefs() {
} else {
value = defaultValue;
}
- if (BG == window) {
+ if (BG === window) {
// when in bg page, .set() will write to localStorage
this.set(key, value, {broadcast: false, sync: false});
} else {
@@ -190,13 +190,13 @@ var prefs = new function Prefs() {
}
}
- if (!BG || BG == window) {
+ if (!BG || BG === window) {
affectsIcon.forEach(key => this.broadcast(key, values[key], {sync: false}));
getSync().get('settings', ({settings: synced} = {}) => {
if (synced) {
for (const key in defaults) {
- if (key == 'popupWidth' && synced[key] != values.popupWidth) {
+ if (key === 'popupWidth' && synced[key] !== values.popupWidth) {
// this is a fix for the period when popupWidth wasn't synced
// TODO: remove it in a couple of months
continue;
@@ -209,7 +209,7 @@ var prefs = new function Prefs() {
});
chrome.storage.onChanged.addListener((changes, area) => {
- if (area == 'sync' && 'settings' in changes) {
+ if (area === 'sync' && 'settings' in changes) {
const synced = changes.settings.newValue;
if (synced) {
for (const key in defaults) {
@@ -283,21 +283,21 @@ var prefs = new function Prefs() {
function defineReadonlyProperty(obj, key, value) {
const copy = deepCopy(value);
- if (typeof copy == 'object') {
+ if (typeof copy === 'object') {
Object.freeze(copy);
}
Object.defineProperty(obj, key, {value: copy, configurable: true});
}
function equal(a, b) {
- if (!a || !b || typeof a != 'object' || typeof b != 'object') {
+ if (!a || !b || typeof a !== 'object' || typeof b !== 'object') {
return a === b;
}
- if (Object.keys(a).length != Object.keys(b).length) {
+ if (Object.keys(a).length !== Object.keys(b).length) {
return false;
}
for (const k in a) {
- if (typeof a[k] == 'object') {
+ if (typeof a[k] === 'object') {
if (!equal(a[k], b[k])) {
return false;
}
@@ -315,7 +315,7 @@ var prefs = new function Prefs() {
// Chrome and co.
/Safari\/[\d.]+$/.test(navigator.userAgent) &&
// skip forks with Flash as those are likely to have the menu e.g. CentBrowser
- !Array.from(navigator.plugins).some(p => p.name == 'Shockwave Flash')
+ !Array.from(navigator.plugins).some(p => p.name === 'Shockwave Flash')
);
}
}();
@@ -330,7 +330,7 @@ function setupLivePrefs(
const checkedProps = {};
for (const id of IDs) {
const element = document.getElementById(id);
- checkedProps[id] = element.type == 'checkbox' ? 'checked' : 'value';
+ checkedProps[id] = element.type === 'checkbox' ? 'checked' : 'value';
updateElement({id, element, force: true});
element.addEventListener('change', onChange);
}
@@ -338,7 +338,7 @@ function setupLivePrefs(
function onChange() {
const value = this[checkedProps[this.id]];
- if (prefs.get(this.id) != value) {
+ if (prefs.get(this.id) !== value) {
prefs.set(this.id, value);
}
}
@@ -349,7 +349,7 @@ function setupLivePrefs(
force,
}) {
const prop = checkedProps[id];
- if (force || element[prop] != value) {
+ if (force || element[prop] !== value) {
element[prop] = value;
element.dispatchEvent(new Event('change', {bubbles: true, cancelable: true}));
}
diff --git a/manage/fileSaveLoad.js b/manage/fileSaveLoad.js
index 9d37fc1b..ec54517d 100644
--- a/manage/fileSaveLoad.js
+++ b/manage/fileSaveLoad.js
@@ -53,7 +53,7 @@ function importFromString(jsonString) {
}
// create objects in background context
const json = BG.tryJSONparse(jsonString) || [];
- if (typeof json.slice != 'function') {
+ if (typeof json.slice !== 'function') {
json.length = 0;
}
const oldStyles = json.length && BG.deepCopy(BG.cachedStyles.list || []);
@@ -94,8 +94,8 @@ function importFromString(jsonString) {
}
function analyze(item) {
- if (!item || !item.name || !item.name.trim() || typeof item != 'object'
- || (item.sections && typeof item.sections.slice != 'function')) {
+ if (!item || !item.name || !item.name.trim() || typeof item !== 'object'
+ || (item.sections && typeof item.sections.slice !== 'function')) {
stats.invalid.names.push(`#${index}: ${limitString(item && item.name || '')}`);
return;
}
@@ -117,8 +117,8 @@ function importFromString(jsonString) {
}
const oldStyleKeys = oldStyle && Object.keys(oldStyle);
const metaEqual = oldStyleKeys &&
- oldStyleKeys.length == Object.keys(item).length &&
- oldStyleKeys.every(k => k == 'sections' || oldStyle[k] === item[k]);
+ oldStyleKeys.length === Object.keys(item).length &&
+ oldStyleKeys.every(k => k === 'sections' || oldStyle[k] === item[k]);
const codeEqual = oldStyle && BG.styleSectionsEqual(oldStyle, item);
if (metaEqual && codeEqual) {
stats.unchanged.names.push(oldStyle.name);
@@ -131,7 +131,7 @@ function importFromString(jsonString) {
function sameStyle(oldStyle, newStyle) {
return oldStyle.name.trim() === newStyle.name.trim() ||
['updateUrl', 'originalMd5', 'originalDigest']
- .some(field => oldStyle[field] && oldStyle[field] == newStyle[field]);
+ .some(field => oldStyle[field] && oldStyle[field] === newStyle[field]);
}
function account({style, info, resolve}) {
@@ -196,7 +196,7 @@ function importFromString(jsonString) {
buttons: [t('confirmOK'), numChanged && t('undo')],
onshow: bindClick,
}).then(({button, enter, esc}) => {
- if (button == 1) {
+ if (button === 1) {
undo();
}
});
@@ -224,7 +224,7 @@ function importFromString(jsonString) {
buttons: [t('confirmOK')],
}));
function undoNextId() {
- if (index == newIds.length) {
+ if (index === newIds.length) {
resolve();
return;
}
@@ -250,7 +250,7 @@ function importFromString(jsonString) {
}
};
for (const block of $$('details')) {
- if (block.dataset.id != 'invalid') {
+ if (block.dataset.id !== 'invalid') {
block.style.cursor = 'pointer';
block.onclick = highlightElement;
}
@@ -262,7 +262,7 @@ function importFromString(jsonString) {
}
function reportNameChange(oldStyle, newStyle) {
- return newStyle.name != oldStyle.name
+ return newStyle.name !== oldStyle.name
? oldStyle.name + ' —> ' + newStyle.name
: oldStyle.name;
}
@@ -278,21 +278,21 @@ function importFromString(jsonString) {
for (const tab of tabs) {
// skip lazy-loaded aka unloaded tabs that seem to start loading on message in FF
if (FIREFOX && !tab.width) {
- if (tab == lastTab) {
+ if (tab === lastTab) {
resolve();
}
continue;
}
getStylesSafe({matchUrl: tab.url, enabled: true, asHash: true}).then(styles => {
const message = {method: 'styleReplaceAll', styles};
- if (tab.id == ownTab.id) {
+ if (tab.id === ownTab.id) {
applyOnMessage(message);
} else {
- invokeOrPostpone(tab.id == activeTab.id,
+ invokeOrPostpone(tab.id === activeTab.id,
chrome.tabs.sendMessage, tab.id, message, ignoreChromeError);
}
setTimeout(BG.updateIcon, 0, tab, styles);
- if (tab == lastTab) {
+ if (tab === lastTab) {
resolve();
}
});
@@ -359,7 +359,7 @@ $('#unfile-all-styles').onclick = () => {
Object.assign(document.body, {
ondragover(event) {
const hasFiles = event.dataTransfer.types.includes('Files');
- event.dataTransfer.dropEffect = hasFiles || event.target.type == 'search' ? 'copy' : 'none';
+ event.dataTransfer.dropEffect = hasFiles || event.target.type === 'search' ? 'copy' : 'none';
this.classList.toggle('dropzone', hasFiles);
if (hasFiles) {
event.preventDefault();
diff --git a/manage/manage.js b/manage/manage.js
index e8fcb481..124c7d72 100644
--- a/manage/manage.js
+++ b/manage/manage.js
@@ -73,7 +73,7 @@ function initGlobalEvents() {
// focus search field on / key
document.onkeypress = event => {
- if ((event.keyCode || event.which) == 47
+ if ((event.keyCode || event.which) === 47
&& !event.altKey && !event.shiftKey && !event.ctrlKey && !event.metaKey
&& !event.target.matches('[type="text"], [type="search"]')) {
event.preventDefault();
@@ -114,7 +114,7 @@ function initGlobalEvents() {
function showStyles(styles = []) {
const sorted = styles
.map(style => ({name: style.name.toLocaleLowerCase(), style}))
- .sort((a, b) => (a.name < b.name ? -1 : a.name == b.name ? 0 : 1));
+ .sort((a, b) => (a.name < b.name ? -1 : a.name === b.name ? 0 : 1));
let index = 0;
const scrollY = (history.state || {}).scrollY;
const shouldRenderAll = scrollY > window.innerHeight || sessionStorage.justEditedStyleId;
@@ -228,18 +228,18 @@ function createStyleTargetsElement({entry, style, postponeFavicons}) {
displayed.add(targetValue);
const element = template.appliesToTarget.cloneNode(true);
if (!newUI.enabled) {
- if (numTargets == 10) {
+ if (numTargets === 10) {
container = container.appendChild(template.extraAppliesTo.cloneNode(true));
} else if (numTargets > 1) {
container.appendChild(template.appliesToSeparator.cloneNode(true));
}
} else if (newUI.favicons) {
let favicon = '';
- if (type == 'domains') {
+ if (type === 'domains') {
favicon = GET_FAVICON_URL + targetValue;
} else if (targetValue.startsWith('chrome-extension:')) {
favicon = OWN_ICON;
- } else if (type != 'regexps') {
+ } else if (type !== 'regexps') {
favicon = targetValue.includes('://') && targetValue.match(/^.*?:\/\/([^/]+)/);
favicon = favicon ? GET_FAVICON_URL + favicon[1] : '';
}
@@ -292,7 +292,7 @@ Object.assign(handleEvent, {
const target = event.target;
const entry = target.closest('.entry');
for (const selector in handleEvent.ENTRY_ROUTES) {
- for (let el = target; el && el != entry; el = el.parentElement) {
+ for (let el = target; el && el !== entry; el = el.parentElement) {
if (el.matches(selector)) {
const handler = handleEvent.ENTRY_ROUTES[selector];
return handleEvent[handler].call(el, event, entry);
@@ -307,8 +307,8 @@ Object.assign(handleEvent, {
}
event.preventDefault();
event.stopPropagation();
- const left = event.button == 0;
- const middle = event.button == 1;
+ const left = event.button === 0;
+ const middle = event.button === 1;
const shift = event.shiftKey;
const ctrl = event.ctrlKey;
const openWindow = left && shift && !ctrl;
@@ -361,7 +361,7 @@ Object.assign(handleEvent, {
buttons: [t('confirmDelete'), t('confirmCancel')],
})
.then(({button, enter, esc}) => {
- if (button == 0 || enter) {
+ if (button === 0 || enter) {
deleteStyleSafe({id});
}
});
@@ -386,10 +386,10 @@ Object.assign(handleEvent, {
},
filterOnChange({target: el, forceRefilter}) {
- const getValue = el => (el.type == 'checkbox' ? el.checked : el.value.trim());
+ const getValue = el => (el.type === 'checkbox' ? el.checked : el.value.trim());
if (!forceRefilter) {
const value = getValue(el);
- if (value == el.lastValue) {
+ if (value === el.lastValue) {
return;
}
el.lastValue = value;
@@ -415,22 +415,22 @@ Object.assign(handleEvent, {
function handleUpdate(style, {reason, method} = {}) {
let entry;
let oldEntry = $(ENTRY_ID_PREFIX + style.id);
- if (oldEntry && method == 'styleUpdated') {
+ if (oldEntry && method === 'styleUpdated') {
handleToggledOrCodeOnly();
}
entry = entry || createStyleElement({style});
if (oldEntry) {
- if (oldEntry.styleNameLowerCase == entry.styleNameLowerCase) {
+ if (oldEntry.styleNameLowerCase === entry.styleNameLowerCase) {
installed.replaceChild(entry, oldEntry);
} else {
oldEntry.remove();
}
}
- if (reason == 'update' && entry.matches('.updatable')) {
+ if (reason === 'update' && entry.matches('.updatable')) {
handleUpdateInstalled();
}
filterAndAppend({entry});
- if (!entry.matches('.hidden') && reason != 'import') {
+ if (!entry.matches('.hidden') && reason !== 'import') {
animateElement(entry);
scrollElementIntoView(entry);
}
@@ -438,12 +438,12 @@ function handleUpdate(style, {reason, method} = {}) {
function handleToggledOrCodeOnly() {
const newStyleMeta = getStyleWithNoCode(style);
const diff = objectDiff(oldEntry.styleMeta, newStyleMeta);
- if (diff.length == 0) {
+ if (diff.length === 0) {
// only code was modified
entry = oldEntry;
oldEntry = null;
}
- if (diff.length == 1 && diff[0].key == 'enabled') {
+ if (diff.length === 1 && diff[0].key === 'enabled') {
oldEntry.classList.toggle('enabled', style.enabled);
oldEntry.classList.toggle('disabled', !style.enabled);
$$('.checker', oldEntry).forEach(el => (el.checked = style.enabled));
@@ -481,8 +481,8 @@ function switchUI({styleOnly} = {}) {
// ensure the global option is processed first
for (const el of [$('#manage.newUI'), ...$$('[id^="manage.newUI."]')]) {
const id = el.id.replace(/^manage\.newUI\.?/, '') || 'enabled';
- const value = el.type == 'checkbox' ? el.checked : Number(el.value);
- const valueChanged = value !== newUI[id] && (id == 'enabled' || current.enabled);
+ const value = el.type === 'checkbox' ? el.checked : Number(el.value);
+ const valueChanged = value !== newUI[id] && (id === 'enabled' || current.enabled);
current[id] = value;
changed[id] = valueChanged;
someChanged |= valueChanged;
@@ -568,7 +568,7 @@ function checkUpdateAll() {
$('#apply-all-updates').classList.add('hidden');
$('#update-all-no-updates').classList.add('hidden');
- const ignoreDigest = this && this.id == 'check-all-updates-force';
+ const ignoreDigest = this && this.id === 'check-all-updates-force';
$$('.updatable:not(.can-update)' + (ignoreDigest ? '' : ':not(.update-problem)'))
.map(el => checkUpdate(el, {single: false}));
@@ -585,7 +585,7 @@ function checkUpdateAll() {
total = value;
break;
case BG.updater.UPDATED:
- if (++updated == 1) {
+ if (++updated === 1) {
$('#apply-all-updates').disabled = true;
$('#apply-all-updates').classList.remove('hidden');
}
@@ -593,7 +593,7 @@ function checkUpdateAll() {
// fallthrough
case BG.updater.SKIPPED:
checked++;
- if (details == BG.updater.EDITED || details == BG.updater.MAYBE_EDITED) {
+ if (details === BG.updater.EDITED || details === BG.updater.MAYBE_EDITED) {
skippedEdited++;
}
reportUpdateState(state, value, details);
@@ -606,13 +606,13 @@ function checkUpdateAll() {
function done() {
document.body.classList.remove('update-in-progress');
- $('#check-all-updates').disabled = total == 0;
+ $('#check-all-updates').disabled = total === 0;
$('#apply-all-updates').disabled = false;
renderUpdatesOnlyFilter({check: updated + skippedEdited > 0});
if (!updated) {
$('#update-all-no-updates').dataset.skippedEdited = skippedEdited > 0;
$('#update-all-no-updates').classList.remove('hidden');
- $('#check-all-updates-force').classList.toggle('hidden', skippedEdited == 0);
+ $('#check-all-updates-force').classList.toggle('hidden', skippedEdited === 0);
}
}
}
@@ -648,16 +648,16 @@ function reportUpdateState(state, style, details) {
if (entry.classList.contains('can-update')) {
break;
}
- const same = details == BG.updater.SAME_MD5 || details == BG.updater.SAME_CODE;
- const edited = details == BG.updater.EDITED || details == BG.updater.MAYBE_EDITED;
+ const same = details === BG.updater.SAME_MD5 || details === BG.updater.SAME_CODE;
+ const edited = details === BG.updater.EDITED || details === BG.updater.MAYBE_EDITED;
entry.dataset.details = details;
if (!details) {
details = t('updateCheckFailServerUnreachable');
- } else if (typeof details == 'number') {
+ } else if (typeof details === 'number') {
details = t('updateCheckFailBadResponseCode', [details]);
- } else if (details == BG.updater.EDITED) {
+ } else if (details === BG.updater.EDITED) {
details = t('updateCheckSkippedLocallyEdited') + '\n' + t('updateCheckManualUpdateHint');
- } else if (details == BG.updater.MAYBE_EDITED) {
+ } else if (details === BG.updater.MAYBE_EDITED) {
details = t('updateCheckSkippedMaybeLocallyEdited') + '\n' + t('updateCheckManualUpdateHint');
}
const message = same ? t('updateCheckSucceededNoUpdate') : details;
@@ -719,7 +719,7 @@ function searchStyles({immediately, container}) {
const searchElement = $('#search');
const query = searchElement.value.toLocaleLowerCase();
const queryPrev = searchElement.lastValue || '';
- if (query == queryPrev && !immediately && !container) {
+ if (query === queryPrev && !immediately && !container) {
return;
}
if (!immediately) {
@@ -741,7 +741,7 @@ function searchStyles({immediately, container}) {
style.url && isMatchingText(style.url) ||
isMatchingStyle(style)));
}
- if (entry.classList.contains('not-matching') != !isMatching) {
+ if (entry.classList.contains('not-matching') !== !isMatching) {
entry.classList.toggle('not-matching', !isMatching);
needsRefilter = true;
}
@@ -850,7 +850,7 @@ function reapplyFilter(container = installed) {
shuffle(false);
setTimeout(shuffle, 0, true);
// single-element job from handleEvent(): add the last wraith
- if (toHide.length == 1 && toHide[0].parentElement != installed) {
+ if (toHide.length === 1 && toHide[0].parentElement !== installed) {
installed.appendChild(toHide[0]);
}
return;
@@ -885,7 +885,7 @@ function reapplyFilter(container = installed) {
const skipGroup = state => {
const start = i;
const first = entry;
- while (entry && entry.classList.contains('hidden') == state) {
+ while (entry && entry.classList.contains('hidden') === state) {
entry = entry.nextElementSibling;
i++;
}
@@ -978,19 +978,19 @@ function objectDiff(first, second, path = '') {
diff.push({path, key, values: [a], type: 'removed'});
continue;
}
- if (a && typeof a.filter == 'function' && b && typeof b.filter == 'function') {
+ if (a && typeof a.filter === 'function' && b && typeof b.filter === 'function') {
if (
- a.length != b.length ||
+ a.length !== b.length ||
a.some((el, i) => {
- const result = !el || typeof el != 'object'
- ? el != b[i]
+ const result = !el || typeof el !== 'object'
+ ? el !== b[i]
: objectDiff(el, b[i], path + key + '[' + i + '].').length;
return result;
})
) {
diff.push({path, key, values: [a, b], type: 'changed'});
}
- } else if (typeof a == 'object' && typeof b == 'object') {
+ } else if (typeof a === 'object' && typeof b === 'object') {
diff.push(...objectDiff(a, b, path + key + '.'));
} else {
diff.push({path, key, values: [a, b], type: 'changed'});
diff --git a/msgbox/msgbox.js b/msgbox/msgbox.js
index a7ebbe2a..8faf8d60 100644
--- a/msgbox/msgbox.js
+++ b/msgbox/msgbox.js
@@ -30,9 +30,9 @@ function messageBox({
key(event) {
const keyCode = event.keyCode || event.which;
if (!event.shiftKey && !event.ctrlKey && !event.altKey && !event.metaKey
- && (keyCode == 13 || keyCode == 27)) {
+ && (keyCode === 13 || keyCode === 27)) {
event.preventDefault();
- resolveWith(keyCode == 13 ? {enter: true} : {esc: true});
+ resolveWith(keyCode === 13 ? {enter: true} : {esc: true});
}
},
scroll() {
@@ -52,7 +52,7 @@ function messageBox({
unbindAndRemoveSelf();
}
const id = 'message-box';
- const putAs = typeof contents == 'string' ? 'innerHTML' : 'appendChild';
+ const putAs = typeof contents === 'string' ? 'innerHTML' : 'appendChild';
messageBox.element = $element({id, className, appendChild: [
$element({appendChild: [
$element({id: `${id}-title`, innerHTML: title}),
diff --git a/options/index.js b/options/index.js
index 6404eefb..10404e5b 100644
--- a/options/index.js
+++ b/options/index.js
@@ -67,7 +67,7 @@ function setupRadioButtons() {
const sets = {};
const onChange = function () {
const newValue = sets[this.name].indexOf(this);
- if (newValue >= 0 && prefs.get(this.name) != newValue) {
+ if (newValue >= 0 && prefs.get(this.name) !== newValue) {
prefs.set(this.name, newValue);
}
};
diff --git a/popup/popup.js b/popup/popup.js
index 42dd69e3..52accdf1 100644
--- a/popup/popup.js
+++ b/popup/popup.js
@@ -278,7 +278,7 @@ Object.assign(handleEvent, {
toggle(event) {
saveStyleSafe({
id: handleEvent.getClickedStyleId(event),
- enabled: this.type == 'checkbox' ? this.checked : this.matches('.enable'),
+ enabled: this.type === 'checkbox' ? this.checked : this.matches('.enable'),
});
},
@@ -293,9 +293,9 @@ Object.assign(handleEvent, {
window.onkeydown = event => {
const keyCode = event.keyCode || event.which;
if (!event.shiftKey && !event.ctrlKey && !event.altKey && !event.metaKey
- && (keyCode == 13 || keyCode == 27)) {
+ && (keyCode === 13 || keyCode === 27)) {
event.preventDefault();
- confirm(keyCode == 13);
+ confirm(keyCode === 13);
}
};
function confirm(ok) {
@@ -342,9 +342,9 @@ Object.assign(handleEvent, {
maybeEdit(event) {
if (!(
- event.button == 0 && (event.ctrlKey || event.metaKey) ||
- event.button == 1 ||
- event.button == 2)) {
+ event.button === 0 && (event.ctrlKey || event.metaKey) ||
+ event.button === 1 ||
+ event.button === 2)) {
return;
}
// open an editor on middleclick
@@ -401,10 +401,10 @@ function detectSloppyRegexps({entry, style}) {
for (const section of style.sections) {
for (const regexp of section.regexps) {
for (let pass = 1; pass <= 2; pass++) {
- const cacheKey = pass == 1 ? regexp : BG.SLOPPY_REGEXP_PREFIX + regexp;
+ const cacheKey = pass === 1 ? regexp : BG.SLOPPY_REGEXP_PREFIX + regexp;
if (!rxCache.has(cacheKey)) {
// according to CSS4 @document specification the entire URL must match
- const anchored = pass == 1 ? '^(?:' + regexp + ')$' : '^' + regexp + '$';
+ const anchored = pass === 1 ? '^(?:' + regexp + ')$' : '^' + regexp + '$';
const rx = tryRegExp(anchored);
rxCache.set(cacheKey, rx || false);
}