From 19c71868a09ce24972345c928233eda280bbcaf5 Mon Sep 17 00:00:00 2001 From: narcolepticinsomniac Date: Sat, 1 Jun 2019 05:12:52 -0400 Subject: [PATCH] Improve height restriction for popup config dialog (#721) * Improve height restriction for popup config dialog Noticed unnecessary overflow in Github Dark's config dialog. We should allow it to utilize available height. * Shave off 2px to allow for borders without overflow --- manage/config-dialog.js | 4 ++-- msgbox/msgbox.css | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/manage/config-dialog.js b/manage/config-dialog.js index de50b7b7..e4126422 100644 --- a/manage/config-dialog.js +++ b/manage/config-dialog.js @@ -433,8 +433,8 @@ function configDialog(style) { const MIN_HEIGHT = 250 + PADDING; colorpicker.remove(); - width = constrain(MIN_WIDTH, 800, width + PADDING); - height = constrain(MIN_HEIGHT, 600, height + PADDING); + width = constrain(MIN_WIDTH, 798, width + PADDING); + height = constrain(MIN_HEIGHT, 598, height + PADDING); document.body.style.setProperty('min-width', width + 'px', 'important'); document.body.style.setProperty('min-height', height + 'px', 'important'); } diff --git a/msgbox/msgbox.css b/msgbox/msgbox.css index 8c9dc019..0afaa940 100644 --- a/msgbox/msgbox.css +++ b/msgbox/msgbox.css @@ -150,6 +150,7 @@ justify-content: center; } #message-box.stylus-popup > div { + max-height: 570px; max-width: 90vw; top: auto; right: auto;