From 14cae1987ccd39bfc6843352cfc35623d6a3066a Mon Sep 17 00:00:00 2001
From: NunoSempere <nuno.sempere@protonmail.com>
Date: Sat, 7 Jan 2023 00:31:12 +0100
Subject: [PATCH] tweak: various qol improvements

---
 README.md                                  |  8 +++++++-
 plugins/libre_redirect/libre_redirect.c    |  2 +-
 user-scripts/ubuntu-20.04/notes-desktop.md | 13 +++++++++++++
 user-scripts/ubuntu-20.04/whatsapp.desktop | 10 ++++++++++
 4 files changed, 31 insertions(+), 2 deletions(-)
 create mode 100644 user-scripts/ubuntu-20.04/notes-desktop.md
 create mode 100755 user-scripts/ubuntu-20.04/whatsapp.desktop

diff --git a/README.md b/README.md
index 567f10d..ae943d4 100644
--- a/README.md
+++ b/README.md
@@ -17,13 +17,19 @@ This is my personal version. Contribute upstream to [github.com/mini-rose/rose](
 
 ### To do
 
+
+- [ ] Add "open in new window" functionality. <https://stackoverflow.com/questions/40180757/webkit2gtk-get-new-window-link>
+  - Useful for opening links in new tab when clicking on them and selecting that option
+  - And for actually opening links with the href newtab option.
+- [ ] Find out what each of the css elements refers to.
+
+Done: 
 - [x] String substitution on uri in order to redirect to better frontends.
 - [x] Present "standard" browser keybindings as an alternative.
 - [x] Fix zoom in new tab
 - [x] Reader mode
 - [x] Add reader mode to config.def.
 - [x] Make tab bar slightly prettier.
-- [ ] Find out what each of the css elements refers to.
 
 ### Known bugs
 
diff --git a/plugins/libre_redirect/libre_redirect.c b/plugins/libre_redirect/libre_redirect.c
index f1eb8bc..9a4b8c0 100644
--- a/plugins/libre_redirect/libre_redirect.c
+++ b/plugins/libre_redirect/libre_redirect.c
@@ -38,7 +38,7 @@ int libre_redirect(const char* uri, char* output){
       "https://wikipedia.org"
     };
     char* alternatives[] = { 
-      "https://yt.artemislena.eu", 
+      "https://invidious.flokinet.to", /* "https://yt.artemislena.eu",  */
       "https://teddit.nunosempere.com", 
       "https://scribe.rip", 
       "https://simplytranslate.org/",
diff --git a/user-scripts/ubuntu-20.04/notes-desktop.md b/user-scripts/ubuntu-20.04/notes-desktop.md
new file mode 100644
index 0000000..3fa4da7
--- /dev/null
+++ b/user-scripts/ubuntu-20.04/notes-desktop.md
@@ -0,0 +1,13 @@
+For some reason, the Ubuntu environment assigns a program to the rose desktop tab if it is called from within /usr/bin/rose, even if from the Whatsapp desktop file.
+
+The solution is to make a syslink from rose to whatsapp:
+
+```
+$ ln -s /usr/bin/rose /usr/bin/whatsapp
+```
+
+and then call whatsapp from:
+
+```
+/usr/bin/whatsapp https://web.whatsapp.com/
+```
diff --git a/user-scripts/ubuntu-20.04/whatsapp.desktop b/user-scripts/ubuntu-20.04/whatsapp.desktop
new file mode 100755
index 0000000..4f0f901
--- /dev/null
+++ b/user-scripts/ubuntu-20.04/whatsapp.desktop
@@ -0,0 +1,10 @@
+#!/usr/bin/env xdg-open
+[Desktop Entry]
+Version=1.0
+Type=Application
+Terminal=false
+Exec= /usr/bin/whatsapp https://web.whatsapp.com
+Name=Whatsapp
+Comment=Whatsapp messaging service.
+Icon=/home/loki/Pictures/fresh/misc/whatsapp_icon.svg
+