From ff7c6dae0945507701102ce12cb8f6a29066089d Mon Sep 17 00:00:00 2001 From: Ian Philips Date: Wed, 4 May 2022 11:39:15 -0400 Subject: [PATCH] Simplify get answer items logic --- web/components/answers/answers-panel.tsx | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/web/components/answers/answers-panel.tsx b/web/components/answers/answers-panel.tsx index a4eab64d..f315b514 100644 --- a/web/components/answers/answers-panel.tsx +++ b/web/components/answers/answers-panel.tsx @@ -52,10 +52,10 @@ export function AnswersPanel(props: { const chosenTotal = _.sum(Object.values(chosenAnswers)) - const answerItems = getAnswers( + const answerItems = getAnswerItems( contract, - user, - winningAnswers.length > 0 ? winningAnswers.map((a) => a.id) : [] + losingAnswers.length > 0 ? losingAnswers : sortedAnswers, + user ) const onChoose = (answerId: string, prob: number) => { @@ -140,20 +140,14 @@ export function AnswersPanel(props: { ) } -function getAnswers( +function getAnswerItems( contract: FullContract, - user: User | undefined | null, - ignoreAnswerOutcomes: string[] + answers: Answer[], + user: User | undefined | null ) { - const { answers } = contract - let outcomes = _.uniq( answers.map((answer) => answer.number.toString()) - ).filter( - (outcome) => - getOutcomeProbability(contract, outcome) > 0.0001 && - !ignoreAnswerOutcomes.includes(outcome) - ) + ).filter((outcome) => getOutcomeProbability(contract, outcome) > 0.0001) outcomes = _.sortBy(outcomes, (outcome) => getOutcomeProbability(contract, outcome) ).reverse()