From f5eee0694d329f84582f9a85bfd4e46bdb85b51c Mon Sep 17 00:00:00 2001 From: James Grugett Date: Mon, 10 Oct 2022 12:14:19 -0500 Subject: [PATCH] Small group updates refactor --- functions/src/update-metrics.ts | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/functions/src/update-metrics.ts b/functions/src/update-metrics.ts index a7e3b13b..fe0273db 100644 --- a/functions/src/update-metrics.ts +++ b/functions/src/update-metrics.ts @@ -250,16 +250,10 @@ export async function updateMetricsCore() { try { const groupUpdates = groups.map((group, index) => { const groupContractIds = contractsByGroup[index] as GroupContractDoc[] - const groupContracts = groupContractIds - .map((e) => contractsById[e.contractId]) - .filter((e) => e !== undefined) as Contract[] - const bets = groupContracts.map((e) => { - if (e != null && e.id in betsByContract) { - return betsByContract[e.id] ?? [] - } else { - return [] - } - }) + const groupContracts = filterDefined( + groupContractIds.map((e) => contractsById[e.contractId]) + ) + const bets = groupContracts.map((e) => betsByContract[e.id] ?? []) const creatorScores = scoreCreators(groupContracts) const traderScores = scoreTraders(groupContracts, bets)