From eb9b14d6d54aec19e0ede56a49a72121a1383e68 Mon Sep 17 00:00:00 2001
From: Marshall Polaris <marshall@pol.rs>
Date: Sun, 10 Jul 2022 13:46:00 -0700
Subject: [PATCH] Migrate unsubscribe function to v2 (#637)

* Migrate unsubscribe function to v2

* Move Stripe import because I forgot to do it before
---
 .../src/email-templates/market-close.html     |   2 +-
 .../src/email-templates/market-resolved.html  |   2 +-
 functions/src/emails.ts                       |  20 ++--
 functions/src/index.ts                        |   4 +-
 functions/src/unsubscribe.ts                  | 109 +++++++++---------
 5 files changed, 69 insertions(+), 68 deletions(-)

diff --git a/functions/src/email-templates/market-close.html b/functions/src/email-templates/market-close.html
index 00e8b439..150987cc 100644
--- a/functions/src/email-templates/market-close.html
+++ b/functions/src/email-templates/market-close.html
@@ -613,7 +613,7 @@
                       >our Discord</a
                     >! Or,
                     <a
-                      href="https://us-central1-mantic-markets.cloudfunctions.net/unsubscribe?id={{userId}}&type=market-resolve"
+                      href="https://unsubscribe-nggbo3neva-uc.a.run.app?id={{userId}}&type=market-resolve"
                       style="
                         font-family: 'Helvetica Neue', Helvetica, Arial,
                           sans-serif;
diff --git a/functions/src/email-templates/market-resolved.html b/functions/src/email-templates/market-resolved.html
index 42d4e2d8..f109d31e 100644
--- a/functions/src/email-templates/market-resolved.html
+++ b/functions/src/email-templates/market-resolved.html
@@ -635,7 +635,7 @@
                       >our Discord</a
                     >! Or,
                     <a
-                      href="https://us-central1-mantic-markets.cloudfunctions.net/unsubscribe?id={{userId}}&type=market-resolved"
+                      href="https://unsubscribe-nggbo3neva-uc.a.run.app?id={{userId}}&type=market-resolved"
                       style="
                         font-family: 'Helvetica Neue', Helvetica, Arial,
                           sans-serif;
diff --git a/functions/src/emails.ts b/functions/src/emails.ts
index 40e8900c..e0e2da63 100644
--- a/functions/src/emails.ts
+++ b/functions/src/emails.ts
@@ -1,4 +1,4 @@
-import { DOMAIN, PROJECT_ID } from '../../common/envs/constants'
+import { DOMAIN, ENV_CONFIG } from '../../common/envs/constants'
 import { Answer } from '../../common/answer'
 import { Bet } from '../../common/bet'
 import { getProbability } from '../../common/calculate'
@@ -141,7 +141,8 @@ export const sendWelcomeEmail = async (
   const firstName = name.split(' ')[0]
 
   const emailType = 'generic'
-  const unsubscribeLink = `https://us-central1-${PROJECT_ID}.cloudfunctions.net/unsubscribe?id=${userId}&type=${emailType}`
+  const { cloudRunId, cloudRunRegion } = ENV_CONFIG
+  const unsubscribeLink = `https://unsubscribe-${cloudRunId}-${cloudRunRegion}.a.run.app?id=${userId}&type=${emailType}`
 
   await sendTemplateEmail(
     privateUser.email,
@@ -173,7 +174,8 @@ export const sendOneWeekBonusEmail = async (
   const firstName = name.split(' ')[0]
 
   const emailType = 'generic'
-  const unsubscribeLink = `https://us-central1-${PROJECT_ID}.cloudfunctions.net/unsubscribe?id=${userId}&type=${emailType}`
+  const { cloudRunId, cloudRunRegion } = ENV_CONFIG
+  const unsubscribeLink = `https://unsubscribe-${cloudRunId}-${cloudRunRegion}.a.run.app?id=${userId}&type=${emailType}`
 
   await sendTemplateEmail(
     privateUser.email,
@@ -205,7 +207,8 @@ export const sendThankYouEmail = async (
   const firstName = name.split(' ')[0]
 
   const emailType = 'generic'
-  const unsubscribeLink = `https://us-central1-${PROJECT_ID}.cloudfunctions.net/unsubscribe?id=${userId}&type=${emailType}`
+  const { cloudRunId, cloudRunRegion } = ENV_CONFIG
+  const unsubscribeLink = `https://unsubscribe-${cloudRunId}-${cloudRunRegion}.a.run.app?id=${userId}&type=${emailType}`
 
   await sendTemplateEmail(
     privateUser.email,
@@ -277,8 +280,9 @@ export const sendNewCommentEmail = async (
 
   const { question, creatorUsername, slug } = contract
   const marketUrl = `https://${DOMAIN}/${creatorUsername}/${slug}#${comment.id}`
-
-  const unsubscribeUrl = `https://us-central1-${PROJECT_ID}.cloudfunctions.net/unsubscribe?id=${userId}&type=market-comment`
+  const emailType = 'market-comment'
+  const { cloudRunId, cloudRunRegion } = ENV_CONFIG
+  const unsubscribeUrl = `https://unsubscribe-${cloudRunId}-${cloudRunRegion}.a.run.app?id=${userId}&type=${emailType}`
 
   const { name: commentorName, avatarUrl: commentorAvatarUrl } = commentCreator
   const { text } = comment
@@ -359,7 +363,9 @@ export const sendNewAnswerEmail = async (
   const { name, avatarUrl, text } = answer
 
   const marketUrl = `https://${DOMAIN}/${creatorUsername}/${slug}`
-  const unsubscribeUrl = `https://us-central1-${PROJECT_ID}.cloudfunctions.net/unsubscribe?id=${userId}&type=market-answer`
+  const emailType = 'market-answer'
+  const { cloudRunId, cloudRunRegion } = ENV_CONFIG
+  const unsubscribeUrl = `https://unsubscribe-${cloudRunId}-${cloudRunRegion}.a.run.app?id=${userId}&type=${emailType}`
 
   const subject = `New answer on ${question}`
   const from = `${name} <info@manifold.markets>`
diff --git a/functions/src/index.ts b/functions/src/index.ts
index 0d0de3ba..380e4f93 100644
--- a/functions/src/index.ts
+++ b/functions/src/index.ts
@@ -3,12 +3,10 @@ import * as admin from 'firebase-admin'
 admin.initializeApp()
 
 // v1
-export * from './stripe'
 export * from './create-user'
 export * from './on-create-bet'
 export * from './on-create-comment-on-contract'
 export * from './on-view'
-export * from './unsubscribe'
 export * from './update-metrics'
 export * from './update-stats'
 export * from './backup-db'
@@ -41,3 +39,5 @@ export * from './withdraw-liquidity'
 export * from './create-group'
 export * from './resolve-market'
 export * from './get-daily-bonuses'
+export * from './unsubscribe'
+export * from './stripe'
diff --git a/functions/src/unsubscribe.ts b/functions/src/unsubscribe.ts
index a41a7155..48dd29c0 100644
--- a/functions/src/unsubscribe.ts
+++ b/functions/src/unsubscribe.ts
@@ -1,71 +1,66 @@
-import * as functions from 'firebase-functions'
+import { onRequest } from 'firebase-functions/v2/https'
 import * as admin from 'firebase-admin'
 import { getUser } from './utils'
 import { PrivateUser } from '../../common/user'
 
-export const unsubscribe = functions
-  .runWith({ minInstances: 1 })
-  .https.onRequest(async (req, res) => {
-    const id = req.query.id as string
-    let type = req.query.type as string
-    if (!id || !type) {
-      res.status(400).send('Empty id or type parameter.')
-      return
-    }
+export const unsubscribe = onRequest({ minInstances: 1 }, async (req, res) => {
+  const id = req.query.id as string
+  let type = req.query.type as string
+  if (!id || !type) {
+    res.status(400).send('Empty id or type parameter.')
+    return
+  }
 
-    if (type === 'market-resolved') type = 'market-resolve'
+  if (type === 'market-resolved') type = 'market-resolve'
 
-    if (
-      ![
-        'market-resolve',
-        'market-comment',
-        'market-answer',
-        'generic',
-      ].includes(type)
-    ) {
-      res.status(400).send('Invalid type parameter.')
-      return
-    }
+  if (
+    !['market-resolve', 'market-comment', 'market-answer', 'generic'].includes(
+      type
+    )
+  ) {
+    res.status(400).send('Invalid type parameter.')
+    return
+  }
 
-    const user = await getUser(id)
+  const user = await getUser(id)
 
-    if (!user) {
-      res.send('This user is not currently subscribed or does not exist.')
-      return
-    }
+  if (!user) {
+    res.send('This user is not currently subscribed or does not exist.')
+    return
+  }
 
-    const { name } = user
+  const { name } = user
 
-    const update: Partial<PrivateUser> = {
-      ...(type === 'market-resolve' && {
-        unsubscribedFromResolutionEmails: true,
-      }),
-      ...(type === 'market-comment' && {
-        unsubscribedFromCommentEmails: true,
-      }),
-      ...(type === 'market-answer' && {
-        unsubscribedFromAnswerEmails: true,
-      }),
-      ...(type === 'generic' && {
-        unsubscribedFromGenericEmails: true,
-      }),
-    }
+  const update: Partial<PrivateUser> = {
+    ...(type === 'market-resolve' && {
+      unsubscribedFromResolutionEmails: true,
+    }),
+    ...(type === 'market-comment' && {
+      unsubscribedFromCommentEmails: true,
+    }),
+    ...(type === 'market-answer' && {
+      unsubscribedFromAnswerEmails: true,
+    }),
+    ...(type === 'generic' && {
+      unsubscribedFromGenericEmails: true,
+    }),
+  }
 
-    await firestore.collection('private-users').doc(id).update(update)
+  await firestore.collection('private-users').doc(id).update(update)
 
-    if (type === 'market-resolve')
-      res.send(
-        `${name}, you have been unsubscribed from market resolution emails on Manifold Markets.`
-      )
-    else if (type === 'market-comment')
-      res.send(
-        `${name}, you have been unsubscribed from market comment emails on Manifold Markets.`
-      )
-    else if (type === 'market-answer')
-      res.send(
-        `${name}, you have been unsubscribed from market answer emails on Manifold Markets.`
-      )
-    else res.send(`${name}, you have been unsubscribed.`)
-  })
+  if (type === 'market-resolve')
+    res.send(
+      `${name}, you have been unsubscribed from market resolution emails on Manifold Markets.`
+    )
+  else if (type === 'market-comment')
+    res.send(
+      `${name}, you have been unsubscribed from market comment emails on Manifold Markets.`
+    )
+  else if (type === 'market-answer')
+    res.send(
+      `${name}, you have been unsubscribed from market answer emails on Manifold Markets.`
+    )
+  else res.send(`${name}, you have been unsubscribed.`)
+})
 
 const firestore = admin.firestore()