From ead8d17bf651f36220500792f910adc56c105c9c Mon Sep 17 00:00:00 2001 From: James Grugett Date: Mon, 10 Oct 2022 13:01:13 -0500 Subject: [PATCH] Fix type error --- common/calculate-metrics.ts | 21 ++++++++------------- functions/src/update-metrics.ts | 2 +- 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/common/calculate-metrics.ts b/common/calculate-metrics.ts index 874f6b46..0302aa31 100644 --- a/common/calculate-metrics.ts +++ b/common/calculate-metrics.ts @@ -1,13 +1,4 @@ -import { - Dictionary, - groupBy, - keyBy, - last, - sortBy, - sum, - sumBy, - uniq, -} from 'lodash' +import { Dictionary, groupBy, last, sortBy, sum, sumBy, uniq } from 'lodash' import { calculatePayout, getContractBetMetrics } from './calculate' import { Bet, LimitBet } from './bet' import { @@ -275,9 +266,13 @@ export const calculateMetricsByContract = ( let periodMetrics if (c.mechanism === 'cpmm-1' && c.outcomeType === 'BINARY') { - periodMetrics = keyBy(['day', 'week', 'month'] as const, (period) => { - return calculatePeriodProfit(c, bets, period) - }) + const periods = ['day', 'week', 'month'] as const + periodMetrics = Object.fromEntries( + periods.map((period) => [ + period, + calculatePeriodProfit(c, bets, period), + ]) + ) } return { diff --git a/functions/src/update-metrics.ts b/functions/src/update-metrics.ts index 1f5c3d7c..39faadbf 100644 --- a/functions/src/update-metrics.ts +++ b/functions/src/update-metrics.ts @@ -24,7 +24,7 @@ import { Group } from '../../common/group' import { batchedWaitAll } from '../../common/util/promise' import { newEndpointNoAuth } from './api' import { getFunctionUrl } from '../../common/api' -import { filterDefined } from 'common/util/array' +import { filterDefined } from '../../common/util/array' const firestore = admin.firestore() export const scheduleUpdateMetrics = functions.pubsub