From d7b702fe0067bfe0dd202709e54ad347caf3b579 Mon Sep 17 00:00:00 2001
From: James Grugett <jahooma@gmail.com>
Date: Sun, 3 Apr 2022 15:48:25 -0500
Subject: [PATCH] Portfolio page! Add to sidebar when signed in, move about
 into more.

---
 web/components/nav/profile-menu.tsx |  2 +-
 web/components/nav/sidebar.tsx      | 11 ++++++++++-
 web/pages/portfolio.tsx             | 24 ++++++++++++++++++++++++
 web/pages/trades.tsx                | 23 ++++++++---------------
 web/public/sitemap-0.xml            |  2 +-
 5 files changed, 44 insertions(+), 18 deletions(-)
 create mode 100644 web/pages/portfolio.tsx

diff --git a/web/components/nav/profile-menu.tsx b/web/components/nav/profile-menu.tsx
index 990c12bc..01a8fb14 100644
--- a/web/components/nav/profile-menu.tsx
+++ b/web/components/nav/profile-menu.tsx
@@ -17,10 +17,10 @@ export function getNavigationOptions(user?: User | null) {
   }
 
   return [
-    { name: 'Your trades', href: '/trades' },
     { name: 'Add funds', href: '/add-funds' },
     { name: 'Leaderboards', href: '/leaderboards' },
     { name: 'Discord', href: 'https://discord.gg/eHQBNBqXuh' },
+    { name: 'About', href: 'https://docs.manifold.markets' },
     { name: 'Sign out', href: '#', onClick: () => firebaseLogout() },
   ]
 }
diff --git a/web/components/nav/sidebar.tsx b/web/components/nav/sidebar.tsx
index d40873da..2212475c 100644
--- a/web/components/nav/sidebar.tsx
+++ b/web/components/nav/sidebar.tsx
@@ -3,6 +3,7 @@ import {
   UserGroupIcon,
   SearchIcon,
   BookOpenIcon,
+  TableIcon,
   DotsHorizontalIcon,
 } from '@heroicons/react/outline'
 import clsx from 'clsx'
@@ -17,6 +18,12 @@ import { MenuButton } from './menu'
 import { getNavigationOptions, ProfileSummary } from './profile-menu'
 
 const navigation = [
+  { name: 'Home', href: '/home', icon: HomeIcon },
+  { name: 'Markets', href: '/markets', icon: SearchIcon },
+  { name: 'Portfolio', href: '/portfolio', icon: TableIcon },
+]
+
+const signedOutNavigation = [
   { name: 'Home', href: '/home', icon: HomeIcon },
   { name: 'Markets', href: '/markets', icon: SearchIcon },
   { name: 'About', href: 'https://docs.manifold.markets', icon: BookOpenIcon },
@@ -76,6 +83,8 @@ export default function Sidebar() {
   let folds = useFollowedFolds(user) || []
   folds = _.sortBy(folds, 'followCount').reverse()
 
+  const navigationOptions = user === null ? signedOutNavigation : navigation
+
   return (
     <nav
       aria-label="Sidebar"
@@ -107,7 +116,7 @@ export default function Sidebar() {
       </div>
 
       <div className="space-y-1 py-6">
-        {navigation.map((item) => (
+        {navigationOptions.map((item) => (
           <SidebarItem key={item.name} item={item} currentPage={currentPage} />
         ))}
 
diff --git a/web/pages/portfolio.tsx b/web/pages/portfolio.tsx
new file mode 100644
index 00000000..99bb7a0a
--- /dev/null
+++ b/web/pages/portfolio.tsx
@@ -0,0 +1,24 @@
+import Router from 'next/router'
+import { useEffect } from 'react'
+
+import { BetsList } from '../components/bets-list'
+import { Page } from '../components/page'
+import { SEO } from '../components/SEO'
+import { Title } from '../components/title'
+import { useUser } from '../hooks/use-user'
+
+export default function PortfolioPage() {
+  const user = useUser()
+
+  useEffect(() => {
+    if (user === null) Router.replace('/')
+  })
+
+  return (
+    <Page>
+      <SEO title="Portfolio" description="Portfolio" url="/portfolio" />
+      <Title className="mx-4 md:mx-0" text="Portfolio" />
+      {user && <BetsList user={user} />}
+    </Page>
+  )
+}
diff --git a/web/pages/trades.tsx b/web/pages/trades.tsx
index f789aba1..906b631d 100644
--- a/web/pages/trades.tsx
+++ b/web/pages/trades.tsx
@@ -1,24 +1,17 @@
 import Router from 'next/router'
+import { useEffect } from 'react'
 
-import { BetsList } from '../components/bets-list'
-import { Page } from '../components/page'
-import { SEO } from '../components/SEO'
-import { Title } from '../components/title'
 import { useUser } from '../hooks/use-user'
 
+// Deprecated: redirects to /portfolio.
+// Eventually, this will be removed.
 export default function TradesPage() {
   const user = useUser()
 
-  if (user === null) {
-    Router.replace('/')
-    return <></>
-  }
+  useEffect(() => {
+    if (user === null) Router.replace('/')
+    else Router.replace('/portfolio')
+  })
 
-  return (
-    <Page>
-      <SEO title="Your trades" description="Your trades" url="/trades" />
-      <Title className="mx-4 md:mx-0" text="Your trades" />
-      {user && <BetsList user={user} />}
-    </Page>
-  )
+  return <></>
 }
diff --git a/web/public/sitemap-0.xml b/web/public/sitemap-0.xml
index 9db55606..80d0d7e3 100644
--- a/web/public/sitemap-0.xml
+++ b/web/public/sitemap-0.xml
@@ -15,5 +15,5 @@
 <url><loc>https://manifold.markets/markets</loc><changefreq>hourly</changefreq><priority>0.7</priority><lastmod>2022-03-24T16:51:19.526Z</lastmod></url>
 <url><loc>https://manifold.markets/profile</loc><changefreq>hourly</changefreq><priority>0.7</priority><lastmod>2022-03-24T16:51:19.526Z</lastmod></url>
 <url><loc>https://manifold.markets/simulator</loc><changefreq>hourly</changefreq><priority>0.7</priority><lastmod>2022-03-24T16:51:19.526Z</lastmod></url>
-<url><loc>https://manifold.markets/trades</loc><changefreq>hourly</changefreq><priority>0.7</priority><lastmod>2022-03-24T16:51:19.526Z</lastmod></url>
+<url><loc>https://manifold.markets/portfolio</loc><changefreq>hourly</changefreq><priority>0.7</priority><lastmod>2022-03-24T16:51:19.526Z</lastmod></url>
 </urlset>
\ No newline at end of file