From d1ba6d524016a3ee83e62bde2e10979794a09565 Mon Sep 17 00:00:00 2001
From: Ian Philips <iansphilips@gmail.com>
Date: Thu, 18 Aug 2022 16:57:55 -0600
Subject: [PATCH] Turn 9am into a constant

---
 common/numeric-constants.ts            | 1 +
 functions/src/on-create-bet.ts         | 8 +++++++-
 functions/src/reset-betting-streaks.ts | 3 ++-
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/common/numeric-constants.ts b/common/numeric-constants.ts
index 80b5a04b..2153fb27 100644
--- a/common/numeric-constants.ts
+++ b/common/numeric-constants.ts
@@ -5,3 +5,4 @@ export const NUMERIC_GRAPH_COLOR = '#5fa5f9'
 export const NUMERIC_TEXT_COLOR = 'text-blue-500'
 export const UNIQUE_BETTOR_BONUS_AMOUNT = 10
 export const BETTING_STREAK_BONUS_AMOUNT = 1
+export const BETTING_STREAK_RESET_HOUR = 9
diff --git a/functions/src/on-create-bet.ts b/functions/src/on-create-bet.ts
index 059cecef..6bbfb436 100644
--- a/functions/src/on-create-bet.ts
+++ b/functions/src/on-create-bet.ts
@@ -14,6 +14,7 @@ import { Contract } from '../../common/contract'
 import { runTxn, TxnData } from './transact'
 import {
   BETTING_STREAK_BONUS_AMOUNT,
+  BETTING_STREAK_RESET_HOUR,
   UNIQUE_BETTOR_BONUS_AMOUNT,
 } from '../../common/numeric-constants'
 import {
@@ -247,7 +248,12 @@ const notifyFills = async (
 
 const getPreviousBettingStreakResetTime = () => {
   const today = Date.now()
-  let betStreakResetTime = new Date().setUTCHours(9, 0, 0, 0)
+  let betStreakResetTime = new Date().setUTCHours(
+    BETTING_STREAK_RESET_HOUR,
+    0,
+    0,
+    0
+  )
   if (today < betStreakResetTime) {
     betStreakResetTime = betStreakResetTime - DAY_MS
   }
diff --git a/functions/src/reset-betting-streaks.ts b/functions/src/reset-betting-streaks.ts
index f441fecb..0600fa56 100644
--- a/functions/src/reset-betting-streaks.ts
+++ b/functions/src/reset-betting-streaks.ts
@@ -4,10 +4,11 @@ import * as functions from 'firebase-functions'
 import * as admin from 'firebase-admin'
 import { User } from '../../common/user'
 import { DAY_MS } from '../../common/util/time'
+import { BETTING_STREAK_RESET_HOUR } from '../../common/numeric-constants'
 const firestore = admin.firestore()
 
 export const resetBettingStreaksForUsers = functions.pubsub
-  .schedule('0 9 * * *')
+  .schedule(`0 ${BETTING_STREAK_RESET_HOUR} * * *`)
   .onRun(async () => {
     await resetBettingStreaksInternal()
   })