From cf62711c24020360f4d874030d31fb5f966b12a9 Mon Sep 17 00:00:00 2001
From: Sinclair Chen <abc.sinclair@gmail.com>
Date: Tue, 3 May 2022 16:28:28 -0400
Subject: [PATCH] refactor SiteLink to not repeat

---
 web/components/site-link.tsx | 32 +++++++++++++-------------------
 1 file changed, 13 insertions(+), 19 deletions(-)

diff --git a/web/components/site-link.tsx b/web/components/site-link.tsx
index f3c187ef..f863cfb9 100644
--- a/web/components/site-link.tsx
+++ b/web/components/site-link.tsx
@@ -1,5 +1,6 @@
 import clsx from 'clsx'
 import Link from 'next/link'
+import { Children } from 'react'
 
 export const SiteLink = (props: {
   href: string
@@ -9,24 +10,8 @@ export const SiteLink = (props: {
 }) => {
   const { href, children, onClick, className } = props
 
-  return href.startsWith('http') ? (
-    <a
-      href={href}
-      className={clsx(
-        'z-10 break-words hover:underline hover:decoration-indigo-400 hover:decoration-2',
-        className
-      )}
-      style={{ /* For iOS safari */ wordBreak: 'break-word' }}
-      target="_blank"
-      onClick={(e) => {
-        e.stopPropagation()
-        if (onClick) onClick()
-      }}
-    >
-      {children}
-    </a>
-  ) : (
-    <Link href={href}>
+  return (
+    <MaybeLink href={href}>
       <a
         className={clsx(
           'z-10 break-words hover:underline hover:decoration-indigo-400 hover:decoration-2',
@@ -40,6 +25,15 @@ export const SiteLink = (props: {
       >
         {children}
       </a>
-    </Link>
+    </MaybeLink>
+  )
+}
+
+function MaybeLink(props: { href: string; children: any }) {
+  const { href, children } = props
+  return href.startsWith('http') ? (
+    children
+  ) : (
+    <Link href={href}>{children}</Link>
   )
 }