diff --git a/web/components/charts/contract/binary.tsx b/web/components/charts/contract/binary.tsx index b7dc9e18..ab3c7ab9 100644 --- a/web/components/charts/contract/binary.tsx +++ b/web/components/charts/contract/binary.tsx @@ -31,9 +31,9 @@ const getBetPoints = (bets: Bet[]) => { } const BinaryChartTooltip = (props: TooltipProps>) => { - const { data, mouseX, xScale } = props + const { data, x, xScale } = props const [start, end] = xScale.domain() - const d = xScale.invert(mouseX) + const d = xScale.invert(x) return ( {data.obj && } diff --git a/web/components/charts/contract/choice.tsx b/web/components/charts/contract/choice.tsx index 513e020e..a6e46a5d 100644 --- a/web/components/charts/contract/choice.tsx +++ b/web/components/charts/contract/choice.tsx @@ -180,9 +180,9 @@ export const ChoiceContractChart = (props: { const ChoiceTooltip = useMemo( () => (props: TooltipProps>) => { - const { data, mouseX, xScale } = props + const { data, x, xScale } = props const [start, end] = xScale.domain() - const d = xScale.invert(mouseX) + const d = xScale.invert(x) const legendItems = sortBy( data.y.map((p, i) => ({ color: CATEGORY_COLORS[i], diff --git a/web/components/charts/contract/numeric.tsx b/web/components/charts/contract/numeric.tsx index f634b56d..8c2e9388 100644 --- a/web/components/charts/contract/numeric.tsx +++ b/web/components/charts/contract/numeric.tsx @@ -26,11 +26,11 @@ const getNumericChartData = (contract: NumericContract) => { const NumericChartTooltip = ( props: TooltipProps ) => { - const { data, mouseX, xScale } = props - const x = xScale.invert(mouseX) + const { data, x, xScale } = props + const amount = xScale.invert(x) return ( <> - {formatLargeNumber(x)} + {formatLargeNumber(amount)} {formatPct(data.y, 2)} ) diff --git a/web/components/charts/contract/pseudo-numeric.tsx b/web/components/charts/contract/pseudo-numeric.tsx index f8a916bd..93e3d32f 100644 --- a/web/components/charts/contract/pseudo-numeric.tsx +++ b/web/components/charts/contract/pseudo-numeric.tsx @@ -45,9 +45,9 @@ const getBetPoints = (bets: Bet[], scaleP: (p: number) => number) => { const PseudoNumericChartTooltip = ( props: TooltipProps> ) => { - const { data, mouseX, xScale } = props + const { data, x, xScale } = props const [start, end] = xScale.domain() - const d = xScale.invert(mouseX) + const d = xScale.invert(x) return ( {data.obj && } diff --git a/web/components/charts/generic-charts.tsx b/web/components/charts/generic-charts.tsx index 34a8a848..4d42da44 100644 --- a/web/components/charts/generic-charts.tsx +++ b/web/components/charts/generic-charts.tsx @@ -21,8 +21,8 @@ import { AreaPath, AreaWithTopStroke, Point, - MouseProps, SliceMarker, + TooltipParams, TooltipComponent, computeColorStops, formatPct, @@ -89,7 +89,7 @@ export const DistributionChart =

(props: { }) => { const { data, w, h, color, margin, yScale, curve, Tooltip } = props - const [mouse, setMouse] = useState>() + const [ttParams, setTTParams] = useState>() const [viewXScale, setViewXScale] = useState>() const xScale = viewXScale ?? props.xScale @@ -109,13 +109,13 @@ export const DistributionChart =

(props: { const p = selector(mouseX) props.onMouseOver?.(p.prev) if (p.prev) { - setMouse({ x: mouseX, y: mouseY, data: p.prev }) + setTTParams({ x: mouseX, y: mouseY, data: p.prev }) } else { - setMouse(undefined) + setTTParams(undefined) } }) - const onMouseLeave = useEvent(() => setMouse(undefined)) + const onMouseLeave = useEvent(() => setTTParams(undefined)) const onSelect = useEvent((ev: D3BrushEvent

) => { if (ev.selection) { @@ -135,7 +135,7 @@ export const DistributionChart =

(props: { margin={margin} xAxis={xAxis} yAxis={yAxis} - mouse={mouse} + ttParams={ttParams} onSelect={onSelect} onMouseOver={onMouseOver} onMouseLeave={onMouseLeave} @@ -168,7 +168,7 @@ export const MultiValueHistoryChart =

(props: { }) => { const { data, w, h, colors, margin, yScale, yKind, curve, Tooltip } = props - const [mouse, setMouse] = useState>() + const [ttParams, setTTParams] = useState>() const [viewXScale, setViewXScale] = useState>() const xScale = viewXScale ?? props.xScale @@ -208,13 +208,13 @@ export const MultiValueHistoryChart =

(props: { const p = selector(mouseX) props.onMouseOver?.(p.prev) if (p.prev) { - setMouse({ x: mouseX, y: mouseY, data: p.prev }) + setTTParams({ x: mouseX, y: mouseY, data: p.prev }) } else { - setMouse(undefined) + setTTParams(undefined) } }) - const onMouseLeave = useEvent(() => setMouse(undefined)) + const onMouseLeave = useEvent(() => setTTParams(undefined)) const onSelect = useEvent((ev: D3BrushEvent

) => { if (ev.selection) { @@ -234,7 +234,7 @@ export const MultiValueHistoryChart =

(props: { margin={margin} xAxis={xAxis} yAxis={yAxis} - mouse={mouse} + ttParams={ttParams} onSelect={onSelect} onMouseOver={onMouseOver} onMouseLeave={onMouseLeave} @@ -272,7 +272,7 @@ export const SingleValueHistoryChart =

(props: { const { data, w, h, color, margin, yScale, yKind, Tooltip } = props const curve = props.curve ?? curveLinear - const [mouse, setMouse] = useState & SliceExtent>() + const [mouse, setMouse] = useState & SliceExtent>() const [viewXScale, setViewXScale] = useState>() const xScale = viewXScale ?? props.xScale @@ -299,7 +299,7 @@ export const SingleValueHistoryChart =

(props: { }, [w, h, yKind, xScale, yScale]) const selector = dataAtPointSelector(data, xScale) - const onMouseOver = useEvent((mouseX: number, mouseY: number) => { + const onMouseOver = useEvent((mouseX: number) => { const p = selector(mouseX) props.onMouseOver?.(p.prev) const x0 = p.prev ? xScale(p.prev.x) : xScale.range()[0] @@ -310,7 +310,7 @@ export const SingleValueHistoryChart =

(props: { if (p.prev && markerY) { setMouse({ x: mouseX, - y: mouseY, + y: markerY, y0: py0, y1: markerY, data: p.prev, @@ -347,7 +347,9 @@ export const SingleValueHistoryChart =

(props: { margin={margin} xAxis={xAxis} yAxis={yAxis} - mouse={mouse} + ttParams={ + mouse ? { x: mouse.x, y: mouse.y, data: mouse.data } : undefined + } onSelect={onSelect} onMouseOver={onMouseOver} onMouseLeave={onMouseLeave} diff --git a/web/components/charts/helpers.tsx b/web/components/charts/helpers.tsx index a4c6d026..bc225b5b 100644 --- a/web/components/charts/helpers.tsx +++ b/web/components/charts/helpers.tsx @@ -144,7 +144,7 @@ export const SVGChart = (props: { margin: Margin xAxis: Axis yAxis: Axis - mouse: MouseProps | undefined + ttParams: TooltipParams | undefined onSelect?: (ev: D3BrushEvent) => void onMouseOver?: (mouseX: number, mouseY: number) => void onMouseLeave?: () => void @@ -157,7 +157,7 @@ export const SVGChart = (props: { margin, xAxis, yAxis, - mouse, + ttParams, onSelect, onMouseOver, onMouseLeave, @@ -213,13 +213,13 @@ export const SVGChart = (props: { return (

- {mouse && Tooltip && ( + {ttParams && Tooltip && ( (props: { > )} @@ -287,11 +287,9 @@ export const getTooltipPosition = ( return { left, bottom } } -export type TooltipProps = { - mouseX: number - mouseY: number +export type TooltipParams = { x: number; y: number; data: T } +export type TooltipProps = TooltipParams & { xScale: ContinuousScale - data: T } export type TooltipComponent = React.ComponentType> @@ -320,8 +318,6 @@ export const TooltipContainer = (props: { ) } -export type MouseProps = { x: number; y: number; data: T } - export const computeColorStops = ( data: P[], pc: (p: P) => string, diff --git a/web/components/charts/stats.tsx b/web/components/charts/stats.tsx index eb3999d8..d43fcb98 100644 --- a/web/components/charts/stats.tsx +++ b/web/components/charts/stats.tsx @@ -22,8 +22,8 @@ const getPoints = (startDate: number, dailyValues: number[]) => { } const DailyCountTooltip = (props: TooltipProps) => { - const { data, mouseX, xScale } = props - const d = xScale.invert(mouseX) + const { data, x, xScale } = props + const d = xScale.invert(x) return ( {dayjs(d).format('MMM DD')} @@ -33,8 +33,8 @@ const DailyCountTooltip = (props: TooltipProps) => { } const DailyPercentTooltip = (props: TooltipProps) => { - const { data, mouseX, xScale } = props - const d = xScale.invert(mouseX) + const { data, x, xScale } = props + const d = xScale.invert(x) return ( {dayjs(d).format('MMM DD')} diff --git a/web/components/portfolio/portfolio-value-graph.tsx b/web/components/portfolio/portfolio-value-graph.tsx index 62692ae5..35d63c6c 100644 --- a/web/components/portfolio/portfolio-value-graph.tsx +++ b/web/components/portfolio/portfolio-value-graph.tsx @@ -18,8 +18,8 @@ const MARGIN_Y = MARGIN.top + MARGIN.bottom export type GraphMode = 'profit' | 'value' export const PortfolioTooltip = (props: TooltipProps) => { - const { mouseX, xScale } = props - const d = dayjs(xScale.invert(mouseX)) + const { x, xScale } = props + const d = dayjs(xScale.invert(x)) return (
{d.format('MMM/D/YY')}