From ac17be0557be9a32caffeae9480a1b810d6abf9d Mon Sep 17 00:00:00 2001
From: James Grugett <jahooma@gmail.com>
Date: Fri, 9 Sep 2022 17:40:27 -0500
Subject: [PATCH] Group bets by user first

---
 common/scoring.ts | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/common/scoring.ts b/common/scoring.ts
index e5e7bf5f..e88ea5fc 100644
--- a/common/scoring.ts
+++ b/common/scoring.ts
@@ -31,18 +31,8 @@ export function scoreTraders(contracts: Contract[], bets: Bet[][]) {
 }
 
 export function scoreUsersByContract(contract: Contract, bets: Bet[]) {
-  const profits = bets.map((bet) => {
-    const { userId } = bet
-    const payout = getContractBetMetrics(contract, [bet]).profit
-    return { userId, payout }
-  })
-
-  const userScore = mapValues(
-    groupBy(profits, (payout) => payout.userId),
-    (payouts) => sumBy(payouts, ({ payout }) => payout)
-  )
-
-  return userScore
+  const betsByUser = groupBy(bets, bet => bet.userId)
+  return mapValues(betsByUser, bets => getContractBetMetrics(contract, bets).profit)
 }
 
 export function addUserScores(