From 7fdd8bd53917d3e627cbfb79e6cefc74be58ed2a Mon Sep 17 00:00:00 2001 From: Marshall Polaris Date: Sat, 21 May 2022 13:38:21 -0700 Subject: [PATCH] Try to make check job continue but report failure accurately --- .github/workflows/check.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index bb9250b3..84e15df9 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -34,16 +34,15 @@ jobs: - name: Run Prettier on web client working-directory: web run: npx prettier --check . - continue-on-error: true - name: Run ESLint on web client + if: ${{ success() || failure() }} working-directory: web run: yarn lint --max-warnings 0 - continue-on-error: true - name: Run Typescript checker on web client + if: ${{ success() || failure() }} working-directory: web run: tsc --pretty --project tsconfig.json --noEmit - continue-on-error: true - name: Run Typescript checker on cloud functions + if: ${{ success() || failure() }} working-directory: functions run: tsc --pretty --project tsconfig.json --noEmit - continue-on-error: true