From 7dea9cbfa89336bcb2672800e4ac3418ac807280 Mon Sep 17 00:00:00 2001
From: Marshall Polaris <marshall@pol.rs>
Date: Sat, 2 Jul 2022 16:24:03 -0700
Subject: [PATCH] Use `getAll` Firestore technology to improve some code (#612)

---
 functions/src/place-bet.ts   |  5 +----
 functions/src/sell-bet.ts    | 10 +++++-----
 functions/src/sell-shares.ts |  5 ++---
 3 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/functions/src/place-bet.ts b/functions/src/place-bet.ts
index b6c7d267..43906f3c 100644
--- a/functions/src/place-bet.ts
+++ b/functions/src/place-bet.ts
@@ -41,10 +41,7 @@ export const placebet = newEndpoint({}, async (req, auth) => {
     log('Inside main transaction.')
     const contractDoc = firestore.doc(`contracts/${contractId}`)
     const userDoc = firestore.doc(`users/${auth.uid}`)
-    const [contractSnap, userSnap] = await Promise.all([
-      trans.get(contractDoc),
-      trans.get(userDoc),
-    ])
+    const [contractSnap, userSnap] = await trans.getAll(contractDoc, userDoc)
     if (!contractSnap.exists) throw new APIError(400, 'Contract not found.')
     if (!userSnap.exists) throw new APIError(400, 'User not found.')
     log('Loaded user and contract snapshots.')
diff --git a/functions/src/sell-bet.ts b/functions/src/sell-bet.ts
index b3362159..18df4536 100644
--- a/functions/src/sell-bet.ts
+++ b/functions/src/sell-bet.ts
@@ -21,11 +21,11 @@ export const sellbet = newEndpoint({}, async (req, auth) => {
     const contractDoc = firestore.doc(`contracts/${contractId}`)
     const userDoc = firestore.doc(`users/${auth.uid}`)
     const betDoc = firestore.doc(`contracts/${contractId}/bets/${betId}`)
-    const [contractSnap, userSnap, betSnap] = await Promise.all([
-      transaction.get(contractDoc),
-      transaction.get(userDoc),
-      transaction.get(betDoc),
-    ])
+    const [contractSnap, userSnap, betSnap] = await transaction.getAll(
+      contractDoc,
+      userDoc,
+      betDoc
+    )
     if (!contractSnap.exists) throw new APIError(400, 'Contract not found.')
     if (!userSnap.exists) throw new APIError(400, 'User not found.')
     if (!betSnap.exists) throw new APIError(400, 'Bet not found.')
diff --git a/functions/src/sell-shares.ts b/functions/src/sell-shares.ts
index 26374a16..a0c19f2c 100644
--- a/functions/src/sell-shares.ts
+++ b/functions/src/sell-shares.ts
@@ -24,9 +24,8 @@ export const sellshares = newEndpoint({}, async (req, auth) => {
     const contractDoc = firestore.doc(`contracts/${contractId}`)
     const userDoc = firestore.doc(`users/${auth.uid}`)
     const betsQ = contractDoc.collection('bets').where('userId', '==', auth.uid)
-    const [contractSnap, userSnap, userBets] = await Promise.all([
-      transaction.get(contractDoc),
-      transaction.get(userDoc),
+    const [[contractSnap, userSnap], userBets] = await Promise.all([
+      transaction.getAll(contractDoc, userDoc),
       getValues<Bet>(betsQ), // TODO: why is this not in the transaction??
     ])
     if (!contractSnap.exists) throw new APIError(400, 'Contract not found.')