From 7b9aeea0bd68d97e5806a21eec744cd894d10e36 Mon Sep 17 00:00:00 2001
From: Ian Philips <iansphilips@gmail.com>
Date: Tue, 4 Oct 2022 17:12:07 -0600
Subject: [PATCH] Ignore similar bettor's followed user's markets

---
 functions/src/weekly-markets-emails.ts | 46 +++++++++++++++-----------
 1 file changed, 27 insertions(+), 19 deletions(-)

diff --git a/functions/src/weekly-markets-emails.ts b/functions/src/weekly-markets-emails.ts
index 5d338a79..4405c9a5 100644
--- a/functions/src/weekly-markets-emails.ts
+++ b/functions/src/weekly-markets-emails.ts
@@ -283,19 +283,7 @@ const getSimilarBettorsMarkets = async (userId: string) => {
 
   // get the top 10 most similar bettors (excluding this user)
   const similarBettorIds = sortedBettorIds.slice(0, 10)
-  console.log('sortedBettorIds', sortedBettorIds)
-  // get their followed users' markets
-  const followedUsersMarkets = (
-    await Promise.all(
-      similarBettorIds.map(async (bettorId) =>
-        getUserUnBetOnFollowsMarkets(bettorId, userId)
-      )
-    )
-  ).flat()
-  console.log(
-    'top 10 followedUsersMarkets',
-    followedUsersMarkets.map((c) => [c.question, c.creatorId]).slice(0, 10)
-  )
+  console.log('top sortedBettorIds', similarBettorIds)
 
   // get contracts with unique bettor ids with this user
   const contractsSimilarBettorsHaveBetOn = (
@@ -305,15 +293,37 @@ const getSimilarBettorsMarkets = async (userId: string) => {
         .where(
           'uniqueBettorIds',
           'array-contains-any',
-          sortedBettorIds.slice(0, 10)
+          similarBettorIds.slice(0, 10)
         )
         .orderBy('popularityScore', 'desc')
         .limit(100)
     )
   ).filter((contract) => !contract.uniqueBettorIds?.includes(userId))
-  console.log(
-    'top 10 contractsSimilarBettorsHaveBetOn',
+
+  // sort the contracts by how many times similar bettor ids are in their unique bettor ids array
+  const sortedContractsToAppearancesInSimilarBettorsBets =
     contractsSimilarBettorsHaveBetOn
+      .map((contract) => {
+        const appearances = contract.uniqueBettorIds?.filter((bettorId) =>
+          similarBettorIds.includes(bettorId)
+        ).length
+        return [contract, appearances] as [Contract, number]
+      })
+      .sort((a, b) => b[1] - a[1])
+  console.log(
+    'sortedContractsToAppearancesInSimilarBettorsBets',
+    sortedContractsToAppearancesInSimilarBettorsBets.map((c) => [
+      c[0].question,
+      c[1],
+    ])
+  )
+
+  const topMostSimilarContracts =
+    sortedContractsToAppearancesInSimilarBettorsBets.map((entry) => entry[0])
+
+  console.log(
+    'top 10 sortedContractsToAppearancesInSimilarBettorsBets',
+    topMostSimilarContracts
       .map((c) => [
         c.question,
         c.uniqueBettorIds?.filter((bid) => similarBettorIds.includes(bid)),
@@ -321,9 +331,7 @@ const getSimilarBettorsMarkets = async (userId: string) => {
       .slice(0, 10)
   )
 
-  return [...followedUsersMarkets, ...contractsSimilarBettorsHaveBetOn].sort(
-    (a, b) => (b?.popularityScore ?? 0) - (a?.popularityScore ?? 0)
-  )
+  return topMostSimilarContracts
 }
 
 const fiveMinutes = 5 * 60 * 1000