From 6af92c5d68b027fc1a57ba87bd6ba302119b03a1 Mon Sep 17 00:00:00 2001 From: Marshall Polaris Date: Tue, 9 Aug 2022 15:21:09 -0700 Subject: [PATCH] Tear out old contract tracking stuff per James --- web/components/feed/feed-items.tsx | 17 ++--------------- web/lib/firebase/seen-contracts.ts | 22 ---------------------- 2 files changed, 2 insertions(+), 37 deletions(-) delete mode 100644 web/lib/firebase/seen-contracts.ts diff --git a/web/components/feed/feed-items.tsx b/web/components/feed/feed-items.tsx index b8018a1c..d60fb8da 100644 --- a/web/components/feed/feed-items.tsx +++ b/web/components/feed/feed-items.tsx @@ -1,5 +1,5 @@ // From https://tailwindui.com/components/application-ui/lists/feeds -import React, { useCallback } from 'react' +import React from 'react' import { BanIcon, CheckIcon, @@ -22,9 +22,8 @@ import { UserLink } from '../user-page' import BetRow from '../bet-row' import { Avatar } from '../avatar' import { ActivityItem } from './activity-items' -import { pushSeenContract } from 'web/lib/firebase/seen-contracts' import { useUser } from 'web/hooks/use-user' -import { trackClick, trackView } from 'web/lib/firebase/tracking' +import { trackClick } from 'web/lib/firebase/tracking' import { DAY_MS } from 'common/util/time' import NewContractBadge from '../new-contract-badge' import { RelativeTimestamp } from '../relative-timestamp' @@ -39,7 +38,6 @@ import { FeedLiquidity } from './feed-liquidity' import { SignUpPrompt } from '../sign-up-prompt' import { User } from 'common/user' import { PlayMoneyDisclaimer } from '../play-money-disclaimer' -import { VisibilityObserver } from '../visibility-observer' export function FeedItems(props: { contract: Contract @@ -51,19 +49,8 @@ export function FeedItems(props: { const { contract, items, className, betRowClassName, user } = props const { outcomeType } = contract - const onVisibilityUpdated = useCallback( - (visible) => { - if (visible && user) { - pushSeenContract(contract.id) - trackView(user.id, contract.id) - } - }, - [contract.id, user] - ) - return (
-
{items.map((item, activityItemIdx) => (
diff --git a/web/lib/firebase/seen-contracts.ts b/web/lib/firebase/seen-contracts.ts deleted file mode 100644 index f16e5fb5..00000000 --- a/web/lib/firebase/seen-contracts.ts +++ /dev/null @@ -1,22 +0,0 @@ -import { mapValues } from 'lodash' - -const key = 'feed-seen-contracts' - -export const pushSeenContract = (contractId: string) => { - const newSeenContracts = { - ...getSeenContracts(), - [contractId]: Date.now(), - } - setSeenContracts(newSeenContracts) -} - -export const setSeenContracts = (timestampsById: { [k: string]: number }) => { - localStorage.setItem(key, JSON.stringify(timestampsById)) -} - -export const getSeenContracts = () => { - return mapValues( - JSON.parse(localStorage.getItem(key) ?? '{}'), - (time) => +time - ) -}