From 62ea1bab1500fb144c24e0495cb6278a80b9d338 Mon Sep 17 00:00:00 2001
From: mantikoros <sgrugett@gmail.com>
Date: Fri, 10 Dec 2021 21:45:05 -0600
Subject: [PATCH] placeBet: always run 1 instance

---
 functions/src/place-bet.ts | 62 ++++++++++++++++++++------------------
 1 file changed, 32 insertions(+), 30 deletions(-)

diff --git a/functions/src/place-bet.ts b/functions/src/place-bet.ts
index 9a0a2cc0..bc299164 100644
--- a/functions/src/place-bet.ts
+++ b/functions/src/place-bet.ts
@@ -5,46 +5,48 @@ import { Contract } from './types/contract'
 import { User } from './types/user'
 import { Bet } from './types/bet'
 
-export const placeBet = functions.https.onCall(async (data: {
-  amount: number
-  outcome: string
-  contractId: string
-}, context) => {
-  const userId = context?.auth?.uid
-  if (!userId)
-    return { status: 'error', message: 'Not authorized' }
+export const placeBet = functions
+  .runWith({ minInstances: 1 })
+  .https.onCall(async (data: {
+    amount: number
+    outcome: string
+    contractId: string
+  }, context) => {
+    const userId = context?.auth?.uid
+    if (!userId)
+      return { status: 'error', message: 'Not authorized' }
 
-  const { amount, outcome, contractId } = data
+    const { amount, outcome, contractId } = data
 
-  if (outcome !== 'YES' && outcome !== 'NO')
-    return { status: 'error', message: 'Invalid outcome' }
+    if (outcome !== 'YES' && outcome !== 'NO')
+      return { status: 'error', message: 'Invalid outcome' }
 
-  // run as transaction to prevent race conditions
-  return await firestore.runTransaction(async transaction => {
-    const userDoc = firestore.doc(`users/${userId}`)
-    const userSnap = await transaction.get(userDoc)
-    if (!userSnap.exists) return { status: 'error', message: 'User not found' }
-    const user = userSnap.data() as User
+    // run as transaction to prevent race conditions
+    return await firestore.runTransaction(async transaction => {
+      const userDoc = firestore.doc(`users/${userId}`)
+      const userSnap = await transaction.get(userDoc)
+      if (!userSnap.exists) return { status: 'error', message: 'User not found' }
+      const user = userSnap.data() as User
 
-    if (user.balanceUsd < amount)
-      return { status: 'error', message: 'Insufficient balance' }
+      if (user.balanceUsd < amount)
+        return { status: 'error', message: 'Insufficient balance' }
 
-    const contractDoc = firestore.doc(`contracts/${contractId}`)
-    const contractSnap = await transaction.get(contractDoc)
-    if (!contractSnap.exists) return { status: 'error', message: 'Invalid contract' }
-    const contract = contractSnap.data() as Contract
+      const contractDoc = firestore.doc(`contracts/${contractId}`)
+      const contractSnap = await transaction.get(contractDoc)
+      if (!contractSnap.exists) return { status: 'error', message: 'Invalid contract' }
+      const contract = contractSnap.data() as Contract
 
-    const newBetDoc = firestore.collection(`contracts/${contractId}/bets`).doc()
+      const newBetDoc = firestore.collection(`contracts/${contractId}/bets`).doc()
 
-    const { newBet, newPot, newBalance } = getNewBetInfo(user, outcome, amount, contract, newBetDoc.id)
+      const { newBet, newPot, newBalance } = getNewBetInfo(user, outcome, amount, contract, newBetDoc.id)
 
-    transaction.create(newBetDoc, newBet)
-    transaction.update(contractDoc, { pot: newPot })
-    transaction.update(userDoc, { balanceUsd: newBalance })
+      transaction.create(newBetDoc, newBet)
+      transaction.update(contractDoc, { pot: newPot })
+      transaction.update(userDoc, { balanceUsd: newBalance })
 
-    return { status: 'success' }
+      return { status: 'success' }
+    })
   })
-})
 
 const firestore = admin.firestore()