From 5bde99bc4265ef5809406dddbd821f3efabcf89b Mon Sep 17 00:00:00 2001 From: Austin Chen Date: Fri, 29 Apr 2022 18:52:08 -0400 Subject: [PATCH] Fix typing issues --- firestore.rules | 1 + functions/src/transact.ts | 7 +++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/firestore.rules b/firestore.rules index cd92c16f..65783ba1 100644 --- a/firestore.rules +++ b/firestore.rules @@ -1,5 +1,6 @@ rules_version = '2'; +// To pick the right project: `firebase projects:list`, then `firebase use ` // To deploy: `firebase deploy --only firestore:rules` service cloud.firestore { match /databases/{database}/documents { diff --git a/functions/src/transact.ts b/functions/src/transact.ts index 31d67b07..04e58568 100644 --- a/functions/src/transact.ts +++ b/functions/src/transact.ts @@ -13,7 +13,7 @@ export const transact = functions const { amount, fromType, fromId, toId, toType, description } = data - if (fromType !== 'user') + if (fromType !== 'USER') return { status: 'error', message: "From type is only implemented for type 'user'.", @@ -44,7 +44,7 @@ export const transact = functions } } - if (toType === 'user') { + if (toType === 'USER') { const toDoc = firestore.doc(`users/${toId}`) const toSnap = await transaction.get(toDoc) if (!toSnap.exists) { @@ -66,6 +66,9 @@ export const transact = functions toType, amount, + // TODO: Unhardcode once we have non-donation txns + token: 'M$', + category: 'CHARITY', description, })