From 38d9e8190c88f69506f76b555c92db99a93ba384 Mon Sep 17 00:00:00 2001
From: Marshall Polaris <marshall@pol.rs>
Date: Thu, 11 Aug 2022 20:44:51 -0700
Subject: [PATCH] Only load portfolio history inside user page bets tab (#747)

---
 .../portfolio/portfolio-value-section.tsx       | 17 ++++++++++++-----
 web/components/user-page.tsx                    | 11 ++---------
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/web/components/portfolio/portfolio-value-section.tsx b/web/components/portfolio/portfolio-value-section.tsx
index 611a19d1..13880bd4 100644
--- a/web/components/portfolio/portfolio-value-section.tsx
+++ b/web/components/portfolio/portfolio-value-section.tsx
@@ -1,20 +1,27 @@
 import { PortfolioMetrics } from 'common/user'
 import { formatMoney } from 'common/util/format'
 import { last } from 'lodash'
-import { memo, useState } from 'react'
-import { Period } from 'web/lib/firebase/users'
+import { memo, useEffect, useState } from 'react'
+import { Period, getPortfolioHistory } from 'web/lib/firebase/users'
 import { Col } from '../layout/col'
 import { Row } from '../layout/row'
 import { PortfolioValueGraph } from './portfolio-value-graph'
 
 export const PortfolioValueSection = memo(
   function PortfolioValueSection(props: {
-    portfolioHistory: PortfolioMetrics[]
+    userId: string
     disableSelector?: boolean
   }) {
-    const { portfolioHistory, disableSelector } = props
-    const lastPortfolioMetrics = last(portfolioHistory)
+    const { disableSelector, userId } = props
+
     const [portfolioPeriod, setPortfolioPeriod] = useState<Period>('allTime')
+    const [portfolioHistory, setUsersPortfolioHistory] = useState<
+      PortfolioMetrics[]
+    >([])
+    useEffect(() => {
+      getPortfolioHistory(userId).then(setUsersPortfolioHistory)
+    }, [userId])
+    const lastPortfolioMetrics = last(portfolioHistory)
 
     if (portfolioHistory.length === 0 || !lastPortfolioMetrics) {
       return <></>
diff --git a/web/components/user-page.tsx b/web/components/user-page.tsx
index 322ddb96..6a901b13 100644
--- a/web/components/user-page.tsx
+++ b/web/components/user-page.tsx
@@ -5,7 +5,7 @@ import { useRouter } from 'next/router'
 import { LinkIcon } from '@heroicons/react/solid'
 import { PencilIcon } from '@heroicons/react/outline'
 
-import { getPortfolioHistory, User } from 'web/lib/firebase/users'
+import { User } from 'web/lib/firebase/users'
 import { CreatorContractsList } from './contract/contracts-grid'
 import { SEO } from './SEO'
 import { Page } from './page'
@@ -26,7 +26,6 @@ import { FullscreenConfetti } from 'web/components/fullscreen-confetti'
 import { BetsList } from './bets-list'
 import { FollowersButton, FollowingButton } from './following-button'
 import { UserFollowButton } from './follow-button'
-import { PortfolioMetrics } from 'common/user'
 import { GroupsButton } from 'web/components/groups/groups-button'
 import { PortfolioValueSection } from './portfolio/portfolio-value-section'
 import { filterDefined } from 'common/util/array'
@@ -74,9 +73,6 @@ export function UserPage(props: { user: User; currentUser?: User }) {
       ? 0
       : userBets.filter((bet) => !bet.isRedemption && bet.amount !== 0).length
 
-  const [portfolioHistory, setUsersPortfolioHistory] = useState<
-    PortfolioMetrics[]
-  >([])
   const [contractsById, setContractsById] = useState<
     Dictionary<Contract> | undefined
   >()
@@ -91,7 +87,6 @@ export function UserPage(props: { user: User; currentUser?: User }) {
     if (!user) return
     getUsersComments(user.id).then(setUsersComments)
     listContracts(user.id).then(setUsersContracts)
-    getPortfolioHistory(user.id).then(setUsersPortfolioHistory)
   }, [user])
 
   // TODO: display comments on groups
@@ -300,9 +295,7 @@ export function UserPage(props: { user: User; currentUser?: User }) {
                 title: 'Bets',
                 content: (
                   <div>
-                    <PortfolioValueSection
-                      portfolioHistory={portfolioHistory}
-                    />
+                    <PortfolioValueSection userId={user.id} />
                     <BetsList
                       user={user}
                       bets={userBets}