open.source/manifold
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't jam username stuff into user listener hook

Browse Source
This commit is contained in:
Marshall Polaris 2022-09-02 14:13:50 -07:00
parent 8fe3f7a2e0
commit 34b8099398
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
web/components/auth-context.tsx
View File

@ -103,11 +103,9 @@ export function AuthProvider(props: {
}, [setAuthUser]) }, [setAuthUser])
const uid = authUser?.user.id const uid = authUser?.user.id
const username = authUser?.user.username
useEffect(() => { useEffect(() => {
if (uid && username) { if (uid) {
identifyUser(uid) identifyUser(uid)
setUserProperty('username', username)
const userListener = listenForUser(uid, (user) => { const userListener = listenForUser(uid, (user) => {
setAuthUser((currAuthUser) => setAuthUser((currAuthUser) =>
currAuthUser && user ? { ...currAuthUser, user } : null currAuthUser && user ? { ...currAuthUser, user } : null
@ -123,7 +121,14 @@ export function AuthProvider(props: {
privateUserListener() privateUserListener()
} }
} }
}, [uid, username, setAuthUser]) }, [uid, setAuthUser])
const username = authUser?.user.username
useEffect(() => {
if (username != null) {
setUserProperty('username', username)
}
}, [username])
return ( return (
<AuthContext.Provider value={authUser}>{children}</AuthContext.Provider> <AuthContext.Provider value={authUser}>{children}</AuthContext.Provider>