From 2ee067c072f629e5d5eede8f2ca3d654e5a33095 Mon Sep 17 00:00:00 2001
From: Ian Philips <iansphilips@gmail.com>
Date: Tue, 6 Sep 2022 08:14:13 -0600
Subject: [PATCH] Remove member and contract ids from group doc

---
 common/group.ts                        |  4 ----
 functions/src/scripts/update-groups.ts | 17 +++++++++++++++--
 2 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/common/group.ts b/common/group.ts
index 5c716dba..19f3b7b8 100644
--- a/common/group.ts
+++ b/common/group.ts
@@ -12,10 +12,6 @@ export type Group = {
   aboutPostId?: string
   chatDisabled?: boolean
   mostRecentContractAddedTime?: number
-  /** @deprecated - members and contracts now stored as subcollections*/
-  memberIds?: string[] // Deprecated
-  /** @deprecated - members and contracts now stored as subcollections*/
-  contractIds?: string[] // Deprecated
 }
 export const MAX_GROUP_NAME_LENGTH = 75
 export const MAX_ABOUT_LENGTH = 140
diff --git a/functions/src/scripts/update-groups.ts b/functions/src/scripts/update-groups.ts
index 952a0d55..05666ab5 100644
--- a/functions/src/scripts/update-groups.ts
+++ b/functions/src/scripts/update-groups.ts
@@ -86,7 +86,7 @@ async function convertGroupFieldsToGroupDocuments() {
     }
   }
 }
-
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 async function updateTotalContractsAndMembers() {
   const groups = await getGroups()
   for (const group of groups) {
@@ -101,9 +101,22 @@ async function updateTotalContractsAndMembers() {
     })
   }
 }
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
+async function removeUnusedMemberAndContractFields() {
+  const groups = await getGroups()
+  for (const group of groups) {
+    log('removing member and contract ids', group.slug)
+    const groupRef = admin.firestore().collection('groups').doc(group.id)
+    await groupRef.update({
+      memberIds: admin.firestore.FieldValue.delete(),
+      contractIds: admin.firestore.FieldValue.delete(),
+    })
+  }
+}
 
 if (require.main === module) {
   initAdmin()
   // convertGroupFieldsToGroupDocuments()
-  updateTotalContractsAndMembers()
+  // updateTotalContractsAndMembers()
+  removeUnusedMemberAndContractFields()
 }