From 2625ab1549808287357a506afc89ca70a9f1ba54 Mon Sep 17 00:00:00 2001
From: Ian Philips <iansphilips@gmail.com>
Date: Thu, 29 Sep 2022 18:13:33 -0600
Subject: [PATCH] Portfolio email ux

---
 .../weekly-portfolio-update.html              |  2 +-
 functions/src/emails.ts                       |  8 ++---
 functions/src/weekly-portfolio-emails.ts      | 29 +++++++------------
 3 files changed, 16 insertions(+), 23 deletions(-)

diff --git a/functions/src/email-templates/weekly-portfolio-update.html b/functions/src/email-templates/weekly-portfolio-update.html
index fd99837f..921a58e5 100644
--- a/functions/src/email-templates/weekly-portfolio-update.html
+++ b/functions/src/email-templates/weekly-portfolio-update.html
@@ -320,7 +320,7 @@
                                                     style="line-height: 24px; margin: 10px 0; margin-top: 20px; margin-bottom: 20px;"
                                                     data-testid="4XoHRGw1Y">
                                                     <span style="color:#000000;font-family:Arial, Helvetica, sans-serif;font-size:18px;">
-                                                    And here's some of the biggest changes in your portfolio:
+                                                    And here's some recent changes in your investments:
                                                     </span>
                                                 </p>
                                             </div>
diff --git a/functions/src/emails.ts b/functions/src/emails.ts
index 6888cfb1..993fac81 100644
--- a/functions/src/emails.ts
+++ b/functions/src/emails.ts
@@ -643,13 +643,13 @@ export const sendWeeklyPortfolioUpdateEmail = async (
     templateData[`question${i + 1}Title`] = investment.questionTitle
     templateData[`question${i + 1}Url`] = investment.questionUrl
     templateData[`question${i + 1}Prob`] = investment.questionProb
-    templateData[`question${i + 1}Change`] = formatMoney(investment.difference)
-    templateData[`question${i + 1}ChangeStyle`] = investment.questionChangeStyle
+    templateData[`question${i + 1}Change`] = formatMoney(investment.profit)
+    templateData[`question${i + 1}ChangeStyle`] = investment.profitStyle
   })
 
   await sendTemplateEmail(
-    // privateUser.email,
-    'iansphilips@gmail.com',
+    privateUser.email,
+    // 'iansphilips@gmail.com',
     `Here's your weekly portfolio update!`,
     investments.length === 0
       ? 'portfolio-update-no-movers'
diff --git a/functions/src/weekly-portfolio-emails.ts b/functions/src/weekly-portfolio-emails.ts
index 198fa7ca..0167be35 100644
--- a/functions/src/weekly-portfolio-emails.ts
+++ b/functions/src/weekly-portfolio-emails.ts
@@ -195,15 +195,13 @@ export async function sendPortfolioUpdateEmailsToAllUsers() {
               contract,
               betsInLastWeek
             ).profit
-            const marketChange =
-              currentMarketProbability - marketProbabilityAWeekAgo
             const profit =
               betsMadeInLastWeekProfit +
               (currentBetsMadeAWeekAgoValue - betsMadeAWeekAgoValue)
             return {
               currentValue: currentBetsMadeAWeekAgoValue,
               pastValue: betsMadeAWeekAgoValue,
-              difference: profit,
+              profit,
               contractSlug: contract.slug,
               marketProbAWeekAgo: marketProbabilityAWeekAgo,
               questionTitle: contract.question,
@@ -211,17 +209,13 @@ export async function sendPortfolioUpdateEmailsToAllUsers() {
               questionProb: cpmmContract.resolution
                 ? cpmmContract.resolution
                 : Math.round(cpmmContract.prob * 100) + '%',
-              questionChange:
-                (marketChange > 0 ? '+' : '') +
-                Math.round(marketChange * 100) +
-                '%',
-              questionChangeStyle: `color: ${
+              profitStyle: `color: ${
                 profit > 0 ? 'rgba(0,160,0,1)' : '#a80000'
               };`,
             } as PerContractInvestmentsData
           })
         ),
-        (differences) => Math.abs(differences.difference)
+        (differences) => Math.abs(differences.profit)
       ).reverse()
 
       log(
@@ -233,12 +227,10 @@ export async function sendPortfolioUpdateEmailsToAllUsers() {
 
       const [winningInvestments, losingInvestments] = partition(
         investmentValueDifferences.filter(
-          (diff) =>
-            diff.pastValue > 0.01 &&
-            Math.abs(diff.difference / diff.pastValue) > 0.01 // difference is greater than 1%
+          (diff) => diff.pastValue > 0.01 && Math.abs(diff.profit) > 1
         ),
         (investmentsData: PerContractInvestmentsData) => {
-          return investmentsData.difference > 0
+          return investmentsData.profit > 0
         }
       )
       // pick 3 winning investments and 3 losing investments
@@ -251,7 +243,9 @@ export async function sendPortfolioUpdateEmailsToAllUsers() {
         worstInvestments.length === 0 &&
         usersToContractsCreated[privateUser.id].length === 0
       ) {
-        log('No bets in last week, no market movers, no markets created')
+        log(
+          'No bets in last week, no market movers, no markets created. Not sending an email.'
+        )
         await firestore.collection('private-users').doc(privateUser.id).update({
           weeklyPortfolioUpdateEmailSent: true,
         })
@@ -268,7 +262,7 @@ export async function sendPortfolioUpdateEmailsToAllUsers() {
       })
       log('Sent weekly portfolio update email to', privateUser.email)
       count++
-      log('sent out emails to user count:', count)
+      log('sent out emails to users:', count)
     })
   )
 }
@@ -277,11 +271,10 @@ export type PerContractInvestmentsData = {
   questionTitle: string
   questionUrl: string
   questionProb: string
-  questionChange: string
-  questionChangeStyle: string
+  profitStyle: string
   currentValue: number
   pastValue: number
-  difference: number
+  profit: number
 }
 
 export type OverallPerformanceData = {