From 20bd97f828e0d58bcab8a992c4e841d6ef602ff4 Mon Sep 17 00:00:00 2001
From: Ian Philips <iansphilips@gmail.com>
Date: Mon, 25 Apr 2022 15:49:54 -0600
Subject: [PATCH] Separate answers and comments in FR markets

---
 web/components/feed/activity-items.ts | 114 ++++++++------------------
 web/components/feed/feed-items.tsx    |  78 ++----------------
 2 files changed, 38 insertions(+), 154 deletions(-)

diff --git a/web/components/feed/activity-items.ts b/web/components/feed/activity-items.ts
index 09d435d9..7ca896bd 100644
--- a/web/components/feed/activity-items.ts
+++ b/web/components/feed/activity-items.ts
@@ -23,7 +23,6 @@ export type ActivityItem =
   | CloseItem
   | ResolveItem
   | CommentInputItem
-  | AnswerItem
 
 type BaseActivityItem = {
   id: string
@@ -69,16 +68,11 @@ export type BetGroupItem = BaseActivityItem & {
 }
 
 export type AnswerGroupItem = BaseActivityItem & {
-  type: 'answergroup'
+  type: 'answergroup' | 'answer'
   answer: Answer
   items: ActivityItem[]
 }
 
-export type AnswerItem = BaseActivityItem & {
-  type: 'answer'
-  answer: Answer
-}
-
 export type CloseItem = BaseActivityItem & {
   type: 'close'
 }
@@ -239,14 +233,13 @@ function getAnswerGroups(
         (answer) => answer.id === outcome
       ) as Answer
 
-      // let items = groupBets(answerBets, answerComments, contract, user?.id, {
-      //   hideOutcome: true,
-      //   abbreviated,
-      //   smallAvatar: true,
-      //   reversed,
-      // })
-      //
-      let items: ActivityItem[] = []
+      let items = groupBets(answerBets, answerComments, contract, user?.id, {
+        hideOutcome: true,
+        abbreviated,
+        smallAvatar: true,
+        reversed,
+      })
+
       if (abbreviated) items = items.slice(-2)
 
       return {
@@ -262,75 +255,33 @@ function getAnswerGroups(
 
   return answerGroups
 }
+
 function getAnswers(
   contract: FullContract<DPM, FreeResponse>,
   bets: Bet[],
-  comments: Comment[],
-  user: User | undefined | null,
-  options: {
-    sortByProb: boolean
-    abbreviated: boolean
-    reversed: boolean
-  }
+  user: User | undefined | null
 ) {
-  const { sortByProb, abbreviated, reversed } = options
-
   let outcomes = _.uniq(bets.map((bet) => bet.outcome)).filter(
     (outcome) => getOutcomeProbability(contract, outcome) > 0.0001
   )
-  if (abbreviated) {
-    const lastComment = _.last(comments)
-    const lastCommentOutcome = bets.find(
-      (bet) => bet.id === lastComment?.betId
-    )?.outcome
-    const lastBetOutcome = _.last(bets)?.outcome
-    if (lastCommentOutcome && lastBetOutcome) {
-      outcomes = _.uniq([
-        ...outcomes.filter(
-          (outcome) =>
-            outcome !== lastCommentOutcome && outcome !== lastBetOutcome
-        ),
-        lastCommentOutcome,
-        lastBetOutcome,
-      ])
-    }
-    outcomes = outcomes.slice(-2)
-  }
-  if (sortByProb) {
-    outcomes = _.sortBy(outcomes, (outcome) =>
-      getOutcomeProbability(contract, outcome)
-    )
-  } else {
-    // Sort by recent bet.
-    outcomes = _.sortBy(outcomes, (outcome) =>
-      _.findLastIndex(bets, (bet) => bet.outcome === outcome)
-    )
-  }
+  outcomes = _.sortBy(outcomes, (outcome) =>
+    getOutcomeProbability(contract, outcome)
+  )
 
   const answerGroups = outcomes
     .map((outcome) => {
-      const answerBets = bets.filter((bet) => bet.outcome === outcome)
-      const answerComments = comments.filter((comment) =>
-        answerBets.some((bet) => bet.id === comment.betId)
-      )
       const answer = contract.answers?.find(
         (answer) => answer.id === outcome
       ) as Answer
 
-      // let items = groupBets(answerBets, answerComments, contract, user?.id, {
-      //   hideOutcome: true,
-      //   abbreviated,
-      //   smallAvatar: true,
-      //   reversed,
-      // })
-      //
-
       return {
         id: outcome,
         type: 'answer' as const,
         contract,
         answer,
+        items: [] as ActivityItem[],
         user,
+        className: 'border-base-200 flex-1 bg-base-200 p-3 rounded-md',
       }
     })
     .filter((group) => group.answer)
@@ -410,13 +361,24 @@ export function getAllContractActivityItems(
     : [{ type: 'description', id: '0', contract }]
 
   if (outcomeType === 'FREE_RESPONSE') {
+    const onlyUsersBetsOrBetsWithComments = bets.filter((bet) =>
+      comments.some(
+        (comment) => comment.betId === bet.id || bet.userId === user?.id
+      )
+    )
     items.push(
-      ...groupBetsAndComments(bets, comments, contract, user?.id, {
-        hideOutcome: false,
-        abbreviated,
-        smallAvatar: false,
-        reversed,
-      })
+      ...groupBetsAndComments(
+        onlyUsersBetsOrBetsWithComments,
+        comments,
+        contract,
+        user?.id,
+        {
+          hideOutcome: false,
+          abbreviated,
+          smallAvatar: false,
+          reversed,
+        }
+      )
     )
     const commentsByBetId = mapCommentsByBetId(comments)
     items.push({
@@ -428,17 +390,7 @@ export function getAllContractActivityItems(
     })
 
     items.push(
-      ...getAnswers(
-        contract as FullContract<DPM, FreeResponse>,
-        bets,
-        comments,
-        user,
-        {
-          sortByProb: true,
-          abbreviated,
-          reversed,
-        }
-      )
+      ...getAnswers(contract as FullContract<DPM, FreeResponse>, bets, user)
     )
   } else {
     items.push(
diff --git a/web/components/feed/feed-items.tsx b/web/components/feed/feed-items.tsx
index 5152c531..ef8a46a5 100644
--- a/web/components/feed/feed-items.tsx
+++ b/web/components/feed/feed-items.tsx
@@ -1,5 +1,5 @@
 // From https://tailwindui.com/components/application-ui/lists/feeds
-import { Fragment, useRef, useState } from 'react'
+import React, { Fragment, useRef, useState } from 'react'
 import * as _ from 'lodash'
 import {
   BanIcon,
@@ -110,7 +110,7 @@ function FeedItem(props: { item: ActivityItem }) {
     case 'answergroup':
       return <FeedAnswerGroup {...item} />
     case 'answer':
-      return <FeedAnswer {...item} />
+      return <FeedAnswerGroup {...item} />
     case 'close':
       return <FeedClose {...item} />
     case 'resolve':
@@ -202,10 +202,6 @@ export function CommentInput(props: {
   const user = useUser()
   const [comment, setComment] = useState('')
 
-  // if (outcomeType === 'FREE_RESPONSE') {
-  //   return <div />
-  // }
-
   let canCommentOnABet = false
   bets.some((bet) => {
     // make sure there is not already a comment with a matching bet id:
@@ -653,8 +649,9 @@ function FeedAnswerGroup(props: {
   contract: FullContract<any, FreeResponse>
   answer: Answer
   items: ActivityItem[]
+  className?: string
 }) {
-  const { answer, items, contract } = props
+  const { answer, items, contract, className } = props
   const { username, avatarUrl, name, text } = answer
 
   const prob = getDpmOutcomeProbability(contract.totalShares, answer.id)
@@ -662,7 +659,7 @@ function FeedAnswerGroup(props: {
   const [open, setOpen] = useState(false)
 
   return (
-    <Col className="flex-1 gap-2">
+    <Col className={className ? className : 'flex-1 gap-2'}>
       <Modal open={open} setOpen={setOpen}>
         <AnswerBetPanel
           answer={answer}
@@ -732,71 +729,6 @@ function FeedAnswerGroup(props: {
     </Col>
   )
 }
-function FeedAnswer(props: {
-  contract: FullContract<any, FreeResponse>
-  answer: Answer
-}) {
-  const { answer, contract } = props
-  const { username, avatarUrl, name, text } = answer
-
-  const prob = getDpmOutcomeProbability(contract.totalShares, answer.id)
-  const probPercent = formatPercent(prob)
-  const [open, setOpen] = useState(false)
-
-  return (
-    <Col
-      className="border-base-300 flex-1 bg-white p-3"
-      style={{ borderWidth: 2, borderRadius: 6 }}
-    >
-      <Modal open={open} setOpen={setOpen}>
-        <AnswerBetPanel
-          answer={answer}
-          contract={contract}
-          closePanel={() => setOpen(false)}
-          className="sm:max-w-84 !rounded-md bg-white !px-8 !py-6"
-          isModal={true}
-        />
-      </Modal>
-
-      <Row className="my-4 gap-3">
-        <div className="px-1">
-          <div className="flex h-8 w-8 items-center justify-center rounded-full bg-gray-200">
-            <Avatar username={username} avatarUrl={avatarUrl} />
-          </div>
-        </div>
-        <Col className="min-w-0 flex-1 gap-2">
-          <div className="text-sm text-gray-500">
-            <UserLink username={username} name={name} /> answered
-          </div>
-
-          <Col className="align-items justify-between gap-4 sm:flex-row">
-            <span className="whitespace-pre-line text-lg">
-              <Linkify text={text} />
-            </span>
-
-            <Row className="align-items justify-end gap-4">
-              <span
-                className={clsx(
-                  'text-2xl',
-                  tradingAllowed(contract) ? 'text-green-500' : 'text-gray-500'
-                )}
-              >
-                {probPercent}
-              </span>
-              <BuyButton
-                className={clsx(
-                  'btn-sm flex-initial !px-6 sm:flex',
-                  tradingAllowed(contract) ? '' : '!hidden'
-                )}
-                onClick={() => setOpen(true)}
-              />
-            </Row>
-          </Col>
-        </Col>
-      </Row>
-    </Col>
-  )
-}
 
 // TODO: Should highlight the entire Feed segment
 function FeedExpand(props: { setExpanded: (expanded: boolean) => void }) {