From 0959ec7679d981493c6fac21ea425e9602543b9c Mon Sep 17 00:00:00 2001
From: Austin Chen <akrolsmir@gmail.com>
Date: Fri, 4 Feb 2022 10:30:56 -0800
Subject: [PATCH] Show avatar on contract cards

---
 web/components/avatar.tsx        | 38 ++++++++++++++++++-----------
 web/components/contract-card.tsx | 41 ++++++++++++++++++++------------
 web/components/contract-feed.tsx | 34 +++++++-------------------
 3 files changed, 58 insertions(+), 55 deletions(-)

diff --git a/web/components/avatar.tsx b/web/components/avatar.tsx
index 0500fced..e3e58e6c 100644
--- a/web/components/avatar.tsx
+++ b/web/components/avatar.tsx
@@ -1,12 +1,15 @@
 import Router from 'next/router'
 import clsx from 'clsx'
+import { UserCircleIcon } from '@heroicons/react/solid'
 
 export function Avatar(props: {
   username?: string
   avatarUrl?: string
   noLink?: boolean
+  size?: number
 }) {
-  const { username, avatarUrl, noLink } = props
+  const { username, avatarUrl, noLink, size } = props
+  const s = size || 10
 
   const onClick =
     noLink && username
@@ -16,19 +19,26 @@ export function Avatar(props: {
           Router.push(`/${username}`)
         }
   return (
-    <div className="rounded-full bg-gray-400 w-10 h-10">
-      <img
-        className={clsx(
-          'rounded-full bg-gray-400 flex items-center justify-center',
-          !noLink && 'cursor-pointer',
-          !avatarUrl && 'hidden'
-        )}
-        src={avatarUrl}
-        width={40}
-        height={40}
-        onClick={onClick}
-        alt={username}
-      />
+    <div className={`rounded-full bg-white w-${s} h-${s}`}>
+      {avatarUrl ? (
+        <img
+          className={clsx(
+            'rounded-full bg-gray-400 flex items-center justify-center',
+            !noLink && 'cursor-pointer'
+          )}
+          src={avatarUrl}
+          width={40}
+          height={40}
+          onClick={onClick}
+          alt={username}
+        />
+      ) : (
+        // TODO: After 2022-03-01, can just assume that all contracts have an avatarUrl
+        <UserCircleIcon
+          className={`w-${s} h-${s} text-gray-500`}
+          aria-hidden="true"
+        />
+      )}
     </div>
   )
 }
diff --git a/web/components/contract-card.tsx b/web/components/contract-card.tsx
index 77d32166..84690fae 100644
--- a/web/components/contract-card.tsx
+++ b/web/components/contract-card.tsx
@@ -9,12 +9,13 @@ import {
   contractPath,
 } from '../lib/firebase/contracts'
 import { Col } from './layout/col'
-import { parseTags } from '../../common/util/parse'
 import dayjs from 'dayjs'
 import { TrendingUpIcon } from '@heroicons/react/solid'
 import { DateTimeTooltip } from './datetime-tooltip'
 import { ClockIcon } from '@heroicons/react/outline'
 import { fromNow } from '../lib/util/time'
+import { Avatar } from './avatar'
+import { Spacer } from './layout/spacer'
 
 export function ContractCard(props: {
   contract: Contract
@@ -37,7 +38,15 @@ export function ContractCard(props: {
         <Link href={contractPath(contract)}>
           <a className="absolute left-0 right-0 top-0 bottom-0" />
         </Link>
-        <Row className="justify-between gap-4 mb-2">
+
+        <AbbrContractDetails
+          contract={contract}
+          showHotVolume={showHotVolume}
+          showCloseTime={showCloseTime}
+        />
+        <Spacer h={3} />
+
+        <Row className="justify-between gap-4">
           <p className="font-medium text-indigo-700">{question}</p>
           <ResolutionOrChance
             className="items-center"
@@ -45,11 +54,6 @@ export function ContractCard(props: {
             probPercent={probPercent}
           />
         </Row>
-        <AbbrContractDetails
-          contract={contract}
-          showHotVolume={showHotVolume}
-          showCloseTime={showCloseTime}
-        />
       </div>
     </div>
   )
@@ -104,7 +108,7 @@ export function ResolutionOrChance(props: {
   )
 }
 
-export function AbbrContractDetails(props: {
+function AbbrContractDetails(props: {
   contract: Contract
   showHotVolume?: boolean
   showCloseTime?: boolean
@@ -115,13 +119,20 @@ export function AbbrContractDetails(props: {
 
   return (
     <Col className={clsx('text-sm text-gray-500 gap-2')}>
-      <Row className="gap-2 flex-wrap">
-        <UserLink
-          className="whitespace-nowrap"
-          name={creatorName}
-          username={creatorUsername}
-        />
-        <div>•</div>
+      <Row className="justify-between items-center">
+        <Row className="gap-2 items-center">
+          <Avatar
+            username={creatorUsername}
+            avatarUrl={contract.creatorAvatarUrl}
+            size={6}
+          />
+          <UserLink
+            className="whitespace-nowrap"
+            name={creatorName}
+            username={creatorUsername}
+          />
+        </Row>
+
         {showHotVolume ? (
           <div className="whitespace-nowrap">
             <TrendingUpIcon className="h-5 w-5 text-gray-500 inline" />{' '}
diff --git a/web/components/contract-feed.tsx b/web/components/contract-feed.tsx
index 2279e2fb..32db9013 100644
--- a/web/components/contract-feed.tsx
+++ b/web/components/contract-feed.tsx
@@ -283,19 +283,10 @@ function FeedQuestion(props: { contract: Contract }) {
 
   return (
     <>
-      {contract.creatorAvatarUrl ? (
-        <Avatar
-          username={contract.creatorUsername}
-          avatarUrl={contract.creatorAvatarUrl}
-        />
-      ) : (
-        // TODO: After 2022-03-01, can just assume that all contracts have an avatarUrl
-        <div className="relative px-1">
-          <div className="h-8 w-8 bg-gray-200 rounded-full flex items-center justify-center">
-            <StarIcon className="h-5 w-5 text-gray-500" aria-hidden="true" />
-          </div>
-        </div>
-      )}
+      <Avatar
+        username={contract.creatorUsername}
+        avatarUrl={contract.creatorAvatarUrl}
+      />
       <div className="min-w-0 flex-1 py-1.5">
         <div className="text-sm text-gray-500 mb-2">
           <UserLink
@@ -337,19 +328,10 @@ function FeedDescription(props: { contract: Contract }) {
 
   return (
     <>
-      {contract.creatorAvatarUrl ? (
-        <Avatar
-          username={contract.creatorUsername}
-          avatarUrl={contract.creatorAvatarUrl}
-        />
-      ) : (
-        // TODO: After 2022-03-01, can just assume that all contracts have an avatarUrl
-        <div className="relative px-1">
-          <div className="h-8 w-8 bg-gray-200 rounded-full flex items-center justify-center">
-            <StarIcon className="h-5 w-5 text-gray-500" aria-hidden="true" />
-          </div>
-        </div>
-      )}
+      <Avatar
+        username={contract.creatorUsername}
+        avatarUrl={contract.creatorAvatarUrl}
+      />
       <div className="min-w-0 flex-1 py-1.5">
         <div className="text-sm text-gray-500">
           <UserLink