From aa4a5dc3ef3bb2b92229432d7ef21c4ce09e9a7d Mon Sep 17 00:00:00 2001
From: kyos <carlos@kyos.ninja>
Date: Wed, 9 Aug 2017 19:56:46 +0200
Subject: [PATCH 1/7] Added option to upload a new format to a given book

---
 cps/static/css/style.css                    |  3 +++
 cps/static/js/edit_books.js                 |  8 ++++++
 cps/templates/book_edit.html                | 12 +++++++--
 cps/translations/es/LC_MESSAGES/messages.po |  4 +++
 cps/web.py                                  | 29 +++++++++++++++++++++
 5 files changed, 54 insertions(+), 2 deletions(-)

diff --git a/cps/static/css/style.css b/cps/static/css/style.css
index 87f7b4c5..f934b62a 100644
--- a/cps/static/css/style.css
+++ b/cps/static/css/style.css
@@ -62,3 +62,6 @@ span.glyphicon.glyphicon-tags {padding-right: 5px;color: #999;vertical-align: te
 #shelf-action-errors {
     margin-left: 5px;
 }
+
+.upload-format-input-text {display: initial;}
+#btn-upload-format {display: none;}
diff --git a/cps/static/js/edit_books.js b/cps/static/js/edit_books.js
index 5438e7b0..0b4ecd45 100644
--- a/cps/static/js/edit_books.js
+++ b/cps/static/js/edit_books.js
@@ -200,3 +200,11 @@ $("#search").on("change input.typeahead:selected", function(){
       });
     });
 });
+
+$("#btn-upload-format").on('change', function () {
+    var filename = $(this).val();
+    if (filename.substring(3,11) == 'fakepath') {
+        filename = filename.substring(12);
+    } // Remove c:\fake at beginning from localhost chrome
+    $('#upload-format').html(filename);
+});
diff --git a/cps/templates/book_edit.html b/cps/templates/book_edit.html
index 9bd1e644..a292e68d 100644
--- a/cps/templates/book_edit.html
+++ b/cps/templates/book_edit.html
@@ -1,7 +1,7 @@
 {% extends "layout.html" %}
 {% block body %}
 {% if book %}
-<form role="form" action="{{ url_for('edit_book', book_id=book.id) }}" method="post">
+<form role="form" action="{{ url_for('edit_book', book_id=book.id) }}" method="post" enctype="multipart/form-data">
 
   <div class="col-sm-3 col-lg-3 col-xs-12">
     <div class="cover">
@@ -115,7 +115,15 @@
           </div>
         {% endfor %}
       {% endif %}
-
+      {% if g.user.role_upload() or g.user.role_admin()%}
+        {% if g.allow_upload %}
+          <div role="group" aria-label="Upload new book format">
+            <label class="btn btn-default btn-file" for="btn-upload-format">{{ _('Upload format') }}</label>
+            <div class="upload-format-input-text" id="upload-format"></div>
+            <input id="btn-upload-format" name="btn-upload-format" type="file">
+          </div>
+        {% endif %}
+      {% endif %}
 
     <div class="checkbox">
       <label>
diff --git a/cps/translations/es/LC_MESSAGES/messages.po b/cps/translations/es/LC_MESSAGES/messages.po
index 39676523..34b51eb9 100644
--- a/cps/translations/es/LC_MESSAGES/messages.po
+++ b/cps/translations/es/LC_MESSAGES/messages.po
@@ -480,6 +480,10 @@ msgstr "Descarga"
 msgid "Upload"
 msgstr "Subir archivo"
 
+#: cps/templates/detail.html:14
+msgid "Upload format"
+msgstr "Subir formato"
+
 #: cps/templates/admin.html:15
 msgid "Edit"
 msgstr "Editar"
diff --git a/cps/web.py b/cps/web.py
index ad548226..ee14108d 100755
--- a/cps/web.py
+++ b/cps/web.py
@@ -2719,6 +2719,35 @@ def edit_book(book_id):
 
     # Update book
     edited_books_id = set()
+
+    # Check and handle Uploaded file
+    if 'btn-upload-format' in request.files and '.' in request.files['btn-upload-format'].filename:
+        requested_file = request.files['btn-upload-format']
+        file_ext = requested_file.filename.rsplit('.', 1)[-1].lower()
+        if file_ext not in ALLOWED_EXTENSIONS:
+            flash(_('File extension "%s" is not allowed to be uploaded to this server' % file_ext), category="error")
+            return redirect(url_for('index'))
+
+        file_name = book.path.rsplit('/', 1)[-1]
+        filepath = config.config_calibre_dir + os.sep + book.path
+        filepath = os.path.normpath(filepath)
+        saved_filename = filepath + os.sep + file_name + '.' + file_ext
+        file_size = os.path.getsize(requested_file.stream.name)
+
+        try:
+            requested_file.save(saved_filename)
+        except OSError:
+            flash(_(u"Failed to store file %s." % saved_filename), category="error")
+            return redirect(url_for('index'))
+
+        is_format = db.session.query(db.Data).filter(db.Data.book == book_id).filter(db.Data.format == file_ext.upper()).first()
+        if is_format:
+            # Format entry already exists, no need to update the database
+            pass
+        else:
+            db_format = db.Data(book_id, file_ext.upper(), file_size, file_name)
+            db.session.add(db_format)
+
     to_save = request.form.to_dict()
     if book.title != to_save["book_title"]:
         book.title = to_save["book_title"]

From 9a17a09cc7811756841f0cca2b247025c8d5c5f6 Mon Sep 17 00:00:00 2001
From: kyos <carlos@kyos.ninja>
Date: Thu, 10 Aug 2017 12:34:54 +0200
Subject: [PATCH 2/7] Fixed codacy requirements

---
 cps/static/js/edit_books.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/cps/static/js/edit_books.js b/cps/static/js/edit_books.js
index 0b4ecd45..5dca150f 100644
--- a/cps/static/js/edit_books.js
+++ b/cps/static/js/edit_books.js
@@ -201,10 +201,10 @@ $("#search").on("change input.typeahead:selected", function(){
     });
 });
 
-$("#btn-upload-format").on('change', function () {
+$("#btn-upload-format").on("change", function () {
     var filename = $(this).val();
-    if (filename.substring(3,11) == 'fakepath') {
+    if (filename.substring(3,11) === "fakepath") {
         filename = filename.substring(12);
     } // Remove c:\fake at beginning from localhost chrome
-    $('#upload-format').html(filename);
+    $("#upload-format").html(filename);
 });

From 9086f4e0e731ee595ac9ef748cbf122889c79f4a Mon Sep 17 00:00:00 2001
From: kyos <carlos@kyos.ninja>
Date: Wed, 9 Aug 2017 19:56:46 +0200
Subject: [PATCH 3/7] Added option to upload a new format to a given book

---
 cps/static/css/style.css                    |  3 +++
 cps/static/js/edit_books.js                 |  8 ++++++
 cps/templates/book_edit.html                | 12 +++++++--
 cps/translations/es/LC_MESSAGES/messages.po |  4 +++
 cps/web.py                                  | 29 +++++++++++++++++++++
 5 files changed, 54 insertions(+), 2 deletions(-)

diff --git a/cps/static/css/style.css b/cps/static/css/style.css
index 673623c5..e5510dd6 100644
--- a/cps/static/css/style.css
+++ b/cps/static/css/style.css
@@ -90,3 +90,6 @@ input.pill:not(:checked) + label .glyphicon {
 #meta-info img { max-height: 150px; max-width: 100px; cursor: pointer; }
 
 .padded-bottom { margin-bottom: 15px; }
+
+.upload-format-input-text {display: initial;}
+#btn-upload-format {display: none;}
diff --git a/cps/static/js/edit_books.js b/cps/static/js/edit_books.js
index 71dc2656..879c57f4 100644
--- a/cps/static/js/edit_books.js
+++ b/cps/static/js/edit_books.js
@@ -205,3 +205,11 @@ $("#search").on("change input.typeahead:selected", function() {
         });
     });
 });
+
+$("#btn-upload-format").on('change', function () {
+    var filename = $(this).val();
+    if (filename.substring(3,11) == 'fakepath') {
+        filename = filename.substring(12);
+    } // Remove c:\fake at beginning from localhost chrome
+    $('#upload-format').html(filename);
+});
diff --git a/cps/templates/book_edit.html b/cps/templates/book_edit.html
index 36e31f5e..0276ad3f 100644
--- a/cps/templates/book_edit.html
+++ b/cps/templates/book_edit.html
@@ -1,7 +1,7 @@
 {% extends "layout.html" %}
 {% block body %}
 {% if book %}
-<form role="form" action="{{ url_for('edit_book', book_id=book.id) }}" method="post">
+<form role="form" action="{{ url_for('edit_book', book_id=book.id) }}" method="post" enctype="multipart/form-data">
 
   <div class="col-sm-3 col-lg-3 col-xs-12">
     <div class="cover">
@@ -115,7 +115,15 @@
           </div>
         {% endfor %}
       {% endif %}
-
+      {% if g.user.role_upload() or g.user.role_admin()%}
+        {% if g.allow_upload %}
+          <div role="group" aria-label="Upload new book format">
+            <label class="btn btn-default btn-file" for="btn-upload-format">{{ _('Upload format') }}</label>
+            <div class="upload-format-input-text" id="upload-format"></div>
+            <input id="btn-upload-format" name="btn-upload-format" type="file">
+          </div>
+        {% endif %}
+      {% endif %}
 
     <div class="checkbox">
       <label>
diff --git a/cps/translations/es/LC_MESSAGES/messages.po b/cps/translations/es/LC_MESSAGES/messages.po
index 6e618d72..305b619a 100644
--- a/cps/translations/es/LC_MESSAGES/messages.po
+++ b/cps/translations/es/LC_MESSAGES/messages.po
@@ -475,6 +475,10 @@ msgstr "Descarga"
 msgid "Upload"
 msgstr "Subir archivo"
 
+#: cps/templates/detail.html:14
+msgid "Upload format"
+msgstr "Subir formato"
+
 #: cps/templates/admin.html:15
 msgid "Edit"
 msgstr "Editar"
diff --git a/cps/web.py b/cps/web.py
index 1437743b..4147ab1c 100755
--- a/cps/web.py
+++ b/cps/web.py
@@ -2724,6 +2724,35 @@ def edit_book(book_id):
 
     # Update book
     edited_books_id = set()
+
+    # Check and handle Uploaded file
+    if 'btn-upload-format' in request.files and '.' in request.files['btn-upload-format'].filename:
+        requested_file = request.files['btn-upload-format']
+        file_ext = requested_file.filename.rsplit('.', 1)[-1].lower()
+        if file_ext not in ALLOWED_EXTENSIONS:
+            flash(_('File extension "%s" is not allowed to be uploaded to this server' % file_ext), category="error")
+            return redirect(url_for('index'))
+
+        file_name = book.path.rsplit('/', 1)[-1]
+        filepath = config.config_calibre_dir + os.sep + book.path
+        filepath = os.path.normpath(filepath)
+        saved_filename = filepath + os.sep + file_name + '.' + file_ext
+        file_size = os.path.getsize(requested_file.stream.name)
+
+        try:
+            requested_file.save(saved_filename)
+        except OSError:
+            flash(_(u"Failed to store file %s." % saved_filename), category="error")
+            return redirect(url_for('index'))
+
+        is_format = db.session.query(db.Data).filter(db.Data.book == book_id).filter(db.Data.format == file_ext.upper()).first()
+        if is_format:
+            # Format entry already exists, no need to update the database
+            pass
+        else:
+            db_format = db.Data(book_id, file_ext.upper(), file_size, file_name)
+            db.session.add(db_format)
+
     to_save = request.form.to_dict()
     if book.title != to_save["book_title"]:
         book.title = to_save["book_title"]

From e5b4bed01c5fdb595ab66cee74293a87d099d55e Mon Sep 17 00:00:00 2001
From: kyos <carlos@kyos.ninja>
Date: Thu, 10 Aug 2017 12:34:54 +0200
Subject: [PATCH 4/7] Fixed codacy requirements

---
 cps/static/js/edit_books.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/cps/static/js/edit_books.js b/cps/static/js/edit_books.js
index 879c57f4..13fba74c 100644
--- a/cps/static/js/edit_books.js
+++ b/cps/static/js/edit_books.js
@@ -206,10 +206,10 @@ $("#search").on("change input.typeahead:selected", function() {
     });
 });
 
-$("#btn-upload-format").on('change', function () {
+$("#btn-upload-format").on("change", function () {
     var filename = $(this).val();
-    if (filename.substring(3,11) == 'fakepath') {
+    if (filename.substring(3,11) === "fakepath") {
         filename = filename.substring(12);
     } // Remove c:\fake at beginning from localhost chrome
-    $('#upload-format').html(filename);
+    $("#upload-format").html(filename);
 });

From be15f3781fd1e5a1379d19012c00b7cbc2779104 Mon Sep 17 00:00:00 2001
From: kyos <carlos@kyos.ninja>
Date: Mon, 11 Sep 2017 11:17:29 +0200
Subject: [PATCH 5/7] Fixed issue reported by Jkrehm to prevent filesize to
 fail

---
 cps/web.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cps/web.py b/cps/web.py
index 4147ab1c..6151da98 100755
--- a/cps/web.py
+++ b/cps/web.py
@@ -2737,7 +2737,7 @@ def edit_book(book_id):
         filepath = config.config_calibre_dir + os.sep + book.path
         filepath = os.path.normpath(filepath)
         saved_filename = filepath + os.sep + file_name + '.' + file_ext
-        file_size = os.path.getsize(requested_file.stream.name)
+        file_size = os.path.getsize(saved_filename)
 
         try:
             requested_file.save(saved_filename)

From cbf2bb450de6e275bae464857360faf7fafd1f8b Mon Sep 17 00:00:00 2001
From: kyos <carlos@kyos.ninja>
Date: Mon, 11 Sep 2017 11:47:39 +0200
Subject: [PATCH 6/7] Fixed issue calculating filesize of the uploaded book

---
 cps/web.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cps/web.py b/cps/web.py
index 6151da98..2ba24fc5 100755
--- a/cps/web.py
+++ b/cps/web.py
@@ -2737,7 +2737,6 @@ def edit_book(book_id):
         filepath = config.config_calibre_dir + os.sep + book.path
         filepath = os.path.normpath(filepath)
         saved_filename = filepath + os.sep + file_name + '.' + file_ext
-        file_size = os.path.getsize(saved_filename)
 
         try:
             requested_file.save(saved_filename)
@@ -2745,6 +2744,7 @@ def edit_book(book_id):
             flash(_(u"Failed to store file %s." % saved_filename), category="error")
             return redirect(url_for('index'))
 
+        file_size = os.path.getsize(saved_filename)
         is_format = db.session.query(db.Data).filter(db.Data.book == book_id).filter(db.Data.format == file_ext.upper()).first()
         if is_format:
             # Format entry already exists, no need to update the database

From 8937599ba7b9e990ac2d05b34518300045b9ea85 Mon Sep 17 00:00:00 2001
From: kyos <carlos@kyos.ninja>
Date: Mon, 11 Sep 2017 17:18:11 +0200
Subject: [PATCH 7/7] Fixed codacy code control

---
 cps/static/js/edit_books.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cps/static/js/edit_books.js b/cps/static/js/edit_books.js
index 13fba74c..061a803e 100644
--- a/cps/static/js/edit_books.js
+++ b/cps/static/js/edit_books.js
@@ -208,7 +208,7 @@ $("#search").on("change input.typeahead:selected", function() {
 
 $("#btn-upload-format").on("change", function () {
     var filename = $(this).val();
-    if (filename.substring(3,11) === "fakepath") {
+    if (filename.substring(3, 11) === "fakepath") {
         filename = filename.substring(12);
     } // Remove c:\fake at beginning from localhost chrome
     $("#upload-format").html(filename);