Fix for #1385 (Private shelves are listed twice in the "Add to shelf" dropdown menu)
This commit is contained in:
		
							parent
							
								
									33472567de
								
							
						
					
					
						commit
						f7269d8df2
					
				| 
						 | 
					@ -240,7 +240,7 @@
 | 
				
			||||||
                     data-remove-href="{{ url_for('shelf.remove_from_shelf', book_id=entry.id, shelf_id=shelf.id) }}"
 | 
					                     data-remove-href="{{ url_for('shelf.remove_from_shelf', book_id=entry.id, shelf_id=shelf.id) }}"
 | 
				
			||||||
                     data-shelf-action="add"
 | 
					                     data-shelf-action="add"
 | 
				
			||||||
                  >
 | 
					                  >
 | 
				
			||||||
                    {{shelf.name}}
 | 
					                    {{shelf.name}}{% if shelf.is_public == 1 %} {{_('(Public)')}}{% endif %}
 | 
				
			||||||
                  </a>
 | 
					                  </a>
 | 
				
			||||||
                </li>
 | 
					                </li>
 | 
				
			||||||
              {% endif %}
 | 
					              {% endif %}
 | 
				
			||||||
| 
						 | 
					@ -257,7 +257,7 @@
 | 
				
			||||||
                >
 | 
					                >
 | 
				
			||||||
                  <span {% if not shelf.is_public or g.user.role_edit_shelfs() %}
 | 
					                  <span {% if not shelf.is_public or g.user.role_edit_shelfs() %}
 | 
				
			||||||
                        class="glyphicon glyphicon-remove"
 | 
					                        class="glyphicon glyphicon-remove"
 | 
				
			||||||
                        {% endif %}></span> {{shelf.name}}
 | 
					                        {% endif %}></span> {{shelf.name}}{% if shelf.is_public == 1 %} {{_('(Public)')}}{% endif %}
 | 
				
			||||||
                </a>
 | 
					                </a>
 | 
				
			||||||
              {% endif %}
 | 
					              {% endif %}
 | 
				
			||||||
            {%endfor%}
 | 
					            {%endfor%}
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -15,13 +15,10 @@
 | 
				
			||||||
                <span class="caret"></span>
 | 
					                <span class="caret"></span>
 | 
				
			||||||
              </button>
 | 
					              </button>
 | 
				
			||||||
              <ul id="add-to-shelves" class="dropdown-menu" aria-labelledby="add-to-shelf">
 | 
					              <ul id="add-to-shelves" class="dropdown-menu" aria-labelledby="add-to-shelf">
 | 
				
			||||||
                {% for shelf in g.user.shelf %}
 | 
					 | 
				
			||||||
                  {% if shelf.is_public != 1 %}
 | 
					 | 
				
			||||||
                    <li><a href="{{ url_for('shelf.search_to_shelf', shelf_id=shelf.id) }}"> {{shelf.name}}</a></li>
 | 
					 | 
				
			||||||
                  {% endif %}
 | 
					 | 
				
			||||||
                {% endfor %}
 | 
					 | 
				
			||||||
                {% for shelf in g.shelves_access %}
 | 
					                {% for shelf in g.shelves_access %}
 | 
				
			||||||
                  <li><a href="{{ url_for('shelf.search_to_shelf', shelf_id=shelf.id) }}">{{shelf.name}}</a></li>
 | 
					                  {% if not shelf.id in books_shelfs and ( not shelf.is_public or g.user.role_edit_shelfs() ) %}
 | 
				
			||||||
 | 
					                    <li><a href="{{ url_for('shelf.search_to_shelf', shelf_id=shelf.id) }}"> {{shelf.name}}{% if shelf.is_public == 1 %} {{_('(Public)')}}{% endif %}</a></li>
 | 
				
			||||||
 | 
					                  {% endif %}
 | 
				
			||||||
                {%endfor%}
 | 
					                {%endfor%}
 | 
				
			||||||
              </ul>
 | 
					              </ul>
 | 
				
			||||||
            </div>
 | 
					            </div>
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
		Reference in New Issue
	
	Block a user