From 7ade2ecd359cd6c2c72997f21f0175da08e9bf7e Mon Sep 17 00:00:00 2001
From: Cory Sitko <csitko@gmail.com>
Date: Tue, 10 Oct 2017 10:18:28 -0400
Subject: [PATCH 1/5] make is_active, is_authenticated, and is_anonymous
 properties on the Anonymous class so that the login_required decorator will
 work correctly and disable anonymous browsing

---
 cps/templates/detail.html |  4 ++--
 cps/templates/index.xml   |  2 +-
 cps/templates/layout.html | 18 +++++++++---------
 cps/templates/read.html   |  2 +-
 cps/ub.py                 |  3 +++
 cps/web.py                | 20 ++++++++++----------
 6 files changed, 26 insertions(+), 23 deletions(-)

diff --git a/cps/templates/detail.html b/cps/templates/detail.html
index c230b069..4a9fa8fb 100644
--- a/cps/templates/detail.html
+++ b/cps/templates/detail.html
@@ -42,7 +42,7 @@
             {% if g.user.kindle_mail and g.user.is_authenticated %}
             <a href="{{url_for('send_to_kindle', book_id=entry.id)}}" id="sendbtn" class="btn btn-primary" role="button"><span class="glyphicon glyphicon-send"></span> {{_('Send to Kindle')}}</a>
             {% endif %}
-          {% if (g.user.role_download() and g.user.is_anonymous()) or g.user.is_authenticated %}
+          {% if (g.user.role_download() and g.user.is_anonymous) or g.user.is_authenticated %}
               <div class="btn-group" role="group">
                 <button id="read-in-browser" type="button" class="btn btn-primary dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
                   <span class="glyphicon glyphicon-eye-open"></span> {{_('Read in browser')}}
@@ -157,7 +157,7 @@
         </p>
         </div>
       {% endif %}
-      {% if not g.user.is_anonymous() %}
+      {% if not g.user.is_anonymous %}
 
         <div class="custom_columns">
           <p>
diff --git a/cps/templates/index.xml b/cps/templates/index.xml
index f0a6e2e0..99358941 100644
--- a/cps/templates/index.xml
+++ b/cps/templates/index.xml
@@ -34,7 +34,7 @@
     <id>{{url_for('feed_discover')}}</id>
     <content type="text">{{_('Show Random Books')}}</content>
   </entry>
-{% if not current_user.is_anonymous() %}
+{% if not current_user.is_anonymous %}
   <entry>
     <title>{{_('Read Books')}}</title>
     <link rel="subsection" href="{{url_for('feed_read_books')}}" type="application/atom+xml;profile=opds-catalog"/>
diff --git a/cps/templates/layout.html b/cps/templates/layout.html
index 6eded615..f2a16a02 100644
--- a/cps/templates/layout.html
+++ b/cps/templates/layout.html
@@ -34,7 +34,7 @@
           </button>
           <a class="navbar-brand" href="{{url_for('index')}}">{{instance}}</a>
         </div>
-        {% if g.user.is_authenticated() or g.user.is_anonymous() %}
+        {% if g.user.is_authenticated or g.user.is_anonymous %}
           <form class="navbar-form navbar-left" role="search" action="{{url_for('search')}}" method="GET">
             <div class="form-group input-group input-group-sm">
               <label for="query" class="sr-only">{{_('Search')}}</label>
@@ -46,13 +46,13 @@
           </form>
         {% endif %}
         <div class="navbar-collapse collapse">
-          {% if g.user.is_authenticated() or g.user.is_anonymous() %}
+          {% if g.user.is_authenticated or g.user.is_anonymous %}
           <ul class="nav navbar-nav ">
             <li><a href="{{url_for('advanced_search')}}"><span class="glyphicon glyphicon-search"></span><span class="hidden-sm"> {{_('Advanced Search')}}</span></a></li>
           </ul>
           {% endif %}
           <ul class="nav navbar-nav navbar-right" id="main-nav">
-            {% if g.user.is_authenticated() or g.user.is_anonymous() %}
+            {% if g.user.is_authenticated or g.user.is_anonymous %}
               {% if g.user.role_upload() or g.user.role_admin()%}
                 {% if g.allow_upload %}
                     <li>
@@ -68,14 +68,14 @@
                 <li><a id="top_admin" href="{{url_for('admin')}}"><span class="glyphicon glyphicon-dashboard"></span><span class="hidden-sm"> {{_('Admin')}}</span></a></li>
               {% endif %}
               <li><a id="top_user" href="{{url_for('profile')}}"><span class="glyphicon glyphicon-user"></span><span class="hidden-sm"> {{g.user.nickname}}</span></a></li>
-              {% if not g.user.is_anonymous() %}
+              {% if not g.user.is_anonymous %}
               <li><a id="logout" href="{{url_for('logout')}}"><span class="glyphicon glyphicon-log-out"></span><span class="hidden-sm"> {{_('Logout')}}</span></a></li>
               {% endif %}
             {% endif %}
-            {% if not g.user.is_authenticated() %}
+            {% if not g.user.is_authenticated %}
             <li><a id="login" href="{{url_for('login')}}"><span class="glyphicon glyphicon-log-in"></span> {{_('Login')}}</a></li>
             {% endif %}
-            {% if g.allow_registration and not g.user.is_authenticated() %}
+            {% if g.allow_registration and not g.user.is_authenticated %}
             <li><a id="register" href="{{url_for('register')}}"><span class="glyphicon glyphicon-user"></span> {{_('Register')}}</a></li>
             {% endif %}
           </ul>
@@ -101,7 +101,7 @@
     {% endfor %}
     <div class="container-fluid">
       <div class="row-fluid">
-        {% if g.user.is_authenticated() or g.user.is_anonymous() %}
+        {% if g.user.is_authenticated or g.user.is_anonymous %}
         <div class="col-sm-2">
           <nav class="navigation">
             <ul class="list-unstyled" id="scnd-nav" intent in-standard-append="nav.navigation" in-mobile-after="#main-nav" in-mobile-class="nav navbar-nav">
@@ -142,7 +142,7 @@
               {% if g.user.filter_language() == 'all' and g.user.show_language() %}
                 <li id="nav_lang"><a href="{{url_for('language_overview')}}"><span class="glyphicon glyphicon-flag"></span> {{_('Languages')}} </a></li>
               {%endif%}
-              {% if g.user.is_authenticated() or g.user.is_anonymous() %}
+              {% if g.user.is_authenticated or g.user.is_anonymous %}
                 <li class="nav-head hidden-xs">{{_('Public Shelves')}}</li>
                 {% for shelf in g.public_shelfes %}
                   <li><a href="{{url_for('show_shelf', shelf_id=shelf.id)}}"><span class="glyphicon glyphicon-list"></span> {{shelf.name}}</a></li>
@@ -151,7 +151,7 @@
                 {% for shelf in g.user.shelf %}
                   <li><a href="{{url_for('show_shelf', shelf_id=shelf.id)}}"><span class="glyphicon glyphicon-list"></span> {{shelf.name}}</a></li>
                 {% endfor %}
-              {% if not g.user.is_anonymous() %}
+              {% if not g.user.is_anonymous %}
                 <li id="nav_createshelf" class="create-shelf"><a href="{{url_for('create_shelf')}}">{{_('Create a Shelf')}}</a></li>
                 <li id="nav_about"><a href="{{url_for('stats')}}"><span class="glyphicon glyphicon-info-sign"></span> {{_('About')}}</a></li>
               {% endif %}
diff --git a/cps/templates/read.html b/cps/templates/read.html
index 97d451d0..d972c2f6 100644
--- a/cps/templates/read.html
+++ b/cps/templates/read.html
@@ -84,7 +84,7 @@
               bookUrl: "{{ url_for('static', filename=bookid) }}/",
               bookmarkUrl: "{{ url_for('bookmark', book_id=bookid, book_format='EPUB') }}",
               bookmark: "{{ bookmark.bookmark_key if bookmark != None }}",
-              useBookmarks: {{ g.user.is_authenticated() | tojson }}
+              useBookmarks: {{ g.user.is_authenticated | tojson }}
           };
       </script>
       <script src="{{ url_for('static', filename='js/libs/jquery.min.js') }}"></script>
diff --git a/cps/ub.py b/cps/ub.py
index c6c062d1..f867274e 100644
--- a/cps/ub.py
+++ b/cps/ub.py
@@ -182,12 +182,15 @@ class Anonymous(AnonymousUserMixin, UserBase):
     def role_admin(self):
         return False
 
+    @property
     def is_active(self):
         return False
 
+    @property
     def is_anonymous(self):
         return self.anon_browse
 
+    @property
     def is_authenticated(self):
         return False
 
diff --git a/cps/web.py b/cps/web.py
index 96f5518d..1b493cfb 100755
--- a/cps/web.py
+++ b/cps/web.py
@@ -866,7 +866,7 @@ def get_opds_download_link(book_id, book_format):
     book = db.session.query(db.Books).filter(db.Books.id == book_id).first()
     data = db.session.query(db.Data).filter(db.Data.book == book.id).filter(db.Data.format == book_format.upper()).first()
     app.logger.info(data.name)
-    if current_user.is_authenticated():
+    if current_user.is_authenticated:
         helper.update_download(book_id, int(current_user.id))
     file_name = book.title
     if len(book.authors) > 0:
@@ -1309,7 +1309,7 @@ def show_book(book_id):
         for entry in shelfs:
             book_in_shelfs.append(entry.shelf)
 
-        if not current_user.is_anonymous():
+        if not current_user.is_anonymous:
             matching_have_read_book = ub.session.query(ub.ReadBook).filter(ub.and_(ub.ReadBook.user_id == int(current_user.id),
                                                                    ub.ReadBook.book_id == book_id)).all()
             have_read = len(matching_have_read_book) > 0 and matching_have_read_book[0].is_read
@@ -1717,7 +1717,7 @@ def feed_get_cover(book_id):
 
 
 def render_read_books(page, are_read, as_xml=False):
-    if not current_user.is_anonymous():
+    if not current_user.is_anonymous:
         readBooks = ub.session.query(ub.ReadBook).filter(ub.ReadBook.user_id == int(current_user.id)).filter(ub.ReadBook.is_read == True).all()
         readBookIds = [x.book_id for x in readBooks]
         if are_read:
@@ -1791,7 +1791,7 @@ def read_book(book_id, book_format):
     if not os.path.exists(book_dir):
         os.mkdir(book_dir)
     bookmark = None
-    if current_user.is_authenticated():
+    if current_user.is_authenticated:
         bookmark = ub.session.query(ub.Bookmark).filter(ub.and_(ub.Bookmark.user_id == int(current_user.id),
                                                             ub.Bookmark.book_id == book_id,
                                                             ub.Bookmark.format == book_format.upper())).first()
@@ -1842,7 +1842,7 @@ def get_download_link(book_id, book_format):
     data = db.session.query(db.Data).filter(db.Data.book == book.id).filter(db.Data.format == book_format.upper()).first()
     if data:
         # collect downloaded books only for registered user and not for anonymous user
-        if current_user.is_authenticated():
+        if current_user.is_authenticated:
             helper.update_download(book_id, int(current_user.id))
         file_name = book.title
         if len(book.authors) > 0:
@@ -1876,7 +1876,7 @@ def get_download_link_ext(book_id, book_format, anyname):
 def register():
     if not config.config_public_reg:
         abort(404)
-    if current_user is not None and current_user.is_authenticated():
+    if current_user is not None and current_user.is_authenticated:
         return redirect(url_for('index'))
 
     if request.method == "POST":
@@ -1913,7 +1913,7 @@ def register():
 def login():
     if not config.db_configured:
         return redirect(url_for('basic_configuration'))
-    if current_user is not None and current_user.is_authenticated():
+    if current_user is not None and current_user.is_authenticated:
         return redirect(url_for('index'))
     if request.method == "POST":
         form = request.form.to_dict()
@@ -1940,7 +1940,7 @@ def login():
 @app.route('/logout')
 @login_required
 def logout():
-    if current_user is not None and current_user.is_authenticated():
+    if current_user is not None and current_user.is_authenticated:
         logout_user()
     return redirect(url_for('login'))
 
@@ -2206,7 +2206,7 @@ def delete_shelf(shelf_id):
 @app.route("/shelf/<int:shelf_id>")
 @login_required_if_no_ano
 def show_shelf(shelf_id):
-    if current_user.is_anonymous():
+    if current_user.is_anonymous:
         shelf = ub.session.query(ub.Shelf).filter(ub.Shelf.is_public == 1, ub.Shelf.id == shelf_id).first()
     else:
         shelf = ub.session.query(ub.Shelf).filter(ub.or_(ub.and_(ub.Shelf.user_id == int(current_user.id),
@@ -2241,7 +2241,7 @@ def order_shelf(shelf_id):
             setattr(book, 'order', to_save[str(book.book_id)])
             counter += 1
         ub.session.commit()
-    if current_user.is_anonymous():
+    if current_user.is_anonymous:
         shelf = ub.session.query(ub.Shelf).filter(ub.Shelf.is_public == 1, ub.Shelf.id == shelf_id).first()
     else:
         shelf = ub.session.query(ub.Shelf).filter(ub.or_(ub.and_(ub.Shelf.user_id == int(current_user.id),

From cc758517e7a79c7b55021a73a2a03c35c0f4c384 Mon Sep 17 00:00:00 2001
From: Cory Sitko <csitko@gmail.com>
Date: Tue, 10 Oct 2017 14:13:28 -0400
Subject: [PATCH 2/5] updated login_required_if_no_ano to correct switch
 anonymous on/off when changed in admin

---
 cps/web.py | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/cps/web.py b/cps/web.py
index 1b493cfb..9935d7d4 100755
--- a/cps/web.py
+++ b/cps/web.py
@@ -384,9 +384,12 @@ app.jinja_env.globals['url_for_other_page'] = url_for_other_page
 
 
 def login_required_if_no_ano(func):
-    if config.config_anonbrowse == 1:
-        return func
-    return login_required(func)
+    @wraps(func)
+    def decorated_view(*args, **kwargs):
+        if config.config_anonbrowse == 1:
+            return func(*args, **kwargs)
+        return login_required(func)(*args, **kwargs)
+    return decorated_view
 
 
 def remote_login_required(f):

From 8fd67fb1fcf25507c7364e814e356020e18a8fd8 Mon Sep 17 00:00:00 2001
From: Cory Sitko <csitko@gmail.com>
Date: Tue, 10 Oct 2017 18:14:19 -0400
Subject: [PATCH 3/5] UserBase methods should be properties not classmethods

---
 cps/ub.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/cps/ub.py b/cps/ub.py
index f867274e..fe1ba719 100644
--- a/cps/ub.py
+++ b/cps/ub.py
@@ -51,7 +51,7 @@ DEVELOPMENT = False
 
 
 class UserBase:
-    @classmethod
+    @property
     def is_authenticated(self):
         return True
 
@@ -97,11 +97,11 @@ class UserBase:
     def role_delete_books(self):
         return bool((self.role is not None)and(self.role & ROLE_DELETE_BOOKS == ROLE_DELETE_BOOKS))
 
-    @classmethod
+    @property
     def is_active(self):
         return True
 
-    @classmethod
+    @property
     def is_anonymous(self):
         return False
 

From 5e4c8c6c65fc8d4bbe09dd39eb805d9d63112cd7 Mon Sep 17 00:00:00 2001
From: Cory Sitko <csitko@gmail.com>
Date: Tue, 10 Oct 2017 20:48:50 -0400
Subject: [PATCH 4/5] fixed is_authenticated check

---
 cps/templates/shelf.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cps/templates/shelf.html b/cps/templates/shelf.html
index c6c11734..aaecdf9c 100644
--- a/cps/templates/shelf.html
+++ b/cps/templates/shelf.html
@@ -2,7 +2,7 @@
 {% block body %}
 <div class="discover">
   <h2>{{title}}</h2>
-  {% if g.user.is_authenticated() %}
+  {% if g.user.is_authenticated %}
     {% if (g.user.role_edit_shelfs() and shelf.is_public ) or not shelf.is_public  %}
       <div data-toggle="modal" data-target="#DeleteShelfDialog" class="btn btn-danger">{{ _('Delete this Shelf') }} </div>
       <a href="{{ url_for('edit_shelf', shelf_id=shelf.id) }}" class="btn btn-primary">{{ _('Edit Shelf name') }} </a>

From 9182d8912816c27e67e452334df370c8fdc89ba4 Mon Sep 17 00:00:00 2001
From: OzzieIsaacs <ozzie.fernandez.isaacs@gmail.com>
Date: Fri, 13 Oct 2017 19:31:03 +0200
Subject: [PATCH 5/5] # Fix 361

---
 cps/templates/layout.html | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/cps/templates/layout.html b/cps/templates/layout.html
index f2a16a02..f611ed90 100644
--- a/cps/templates/layout.html
+++ b/cps/templates/layout.html
@@ -72,10 +72,8 @@
               <li><a id="logout" href="{{url_for('logout')}}"><span class="glyphicon glyphicon-log-out"></span><span class="hidden-sm"> {{_('Logout')}}</span></a></li>
               {% endif %}
             {% endif %}
-            {% if not g.user.is_authenticated %}
-            <li><a id="login" href="{{url_for('login')}}"><span class="glyphicon glyphicon-log-in"></span> {{_('Login')}}</a></li>
-            {% endif %}
             {% if g.allow_registration and not g.user.is_authenticated %}
+            <li><a id="login" href="{{url_for('login')}}"><span class="glyphicon glyphicon-log-in"></span> {{_('Login')}}</a></li>
             <li><a id="register" href="{{url_for('register')}}"><span class="glyphicon glyphicon-user"></span> {{_('Register')}}</a></li>
             {% endif %}
           </ul>
@@ -138,7 +136,9 @@
               {% if g.user.show_series() %}
               <li id="nav_serie"><a href="{{url_for('series_list')}}"><span class="glyphicon glyphicon-bookmark"></span> {{_('Series')}}</a></li>
               {%endif%}
+              {% if g.user.show_author() %}
               <li id="nav_author"><a href="{{url_for('author_list')}}"><span class="glyphicon glyphicon-user"></span> {{_('Authors')}}</a></li>
+              {%endif%}
               {% if g.user.filter_language() == 'all' and g.user.show_language() %}
                 <li id="nav_lang"><a href="{{url_for('language_overview')}}"><span class="glyphicon glyphicon-flag"></span> {{_('Languages')}} </a></li>
               {%endif%}